From: Michael Albinus <michael.albinus@gmx.de>
To: Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org>
Cc: 33394@debbugs.gnu.org
Subject: bug#33394: 27.0.50; trampver cannot determine repository version
Date: Thu, 15 Nov 2018 12:40:17 +0100 [thread overview]
Message-ID: <87tvkifu1q.fsf@gmx.de> (raw)
In-Reply-To: <CAAoeO9i5aUgEXT_9HM8OjZCQP=3Z0BkQcerHan+1nTevdBVa+w@mail.gmail.com> (Geoffrey Ferrari's message of "Thu, 15 Nov 2018 09:45:43 +0000")
Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org> writes:
Hi Geoffrey,
> The issue can be traced to the definition of tramp-repository-branch
> in
> trampver.el. This calls:
>
> (emacs-repository-get-branch
> (locate-dominating-file (locate-library "tramp") ".git"))
>
> However, (locate-dominating-file (locate-library "tramp") ".git")
> evaluates to nil, meaning that above is equivalent to
> (emacs-repository-get-branch nil).
>
> This causes the function emacs-repository-get-branch (in version.el)
> to
> rely on the variable source-directory i.e. which references the source
> directory where the emacs
> binary was built, which of course does not exist on an end user's
> system.
Yes. However, the initial value of tramp-repository-branch is
--8<---------------cut here---------------start------------->8---
(ignore-errors
;; Suppress message from `emacs-repository-get-branch'.
(let ((inhibit-message t))
;; `emacs-repository-get-branch' has been introduced with Emacs 27.1.
(with-no-warnings
(emacs-repository-get-branch
(locate-dominating-file (locate-library "tramp") ".git")))))
--8<---------------cut here---------------end--------------->8---
I'm wondering why you see an error, although the code is wrapped by
`ignore-errors'.
Best regards, Michael.
next prev parent reply other threads:[~2018-11-15 11:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 9:45 bug#33394: 27.0.50; trampver cannot determine repository version Geoffrey Ferrari
2018-11-15 11:40 ` Michael Albinus [this message]
2018-11-15 11:56 ` Geoffrey Ferrari
2018-11-15 12:56 ` Michael Albinus
2018-11-15 13:10 ` Geoffrey Ferrari
2018-11-15 13:19 ` Michael Albinus
2020-04-01 4:09 ` Clément Pit-Claudel
2020-04-01 10:13 ` Michael Albinus
2020-04-01 13:03 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvkifu1q.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=33394@debbugs.gnu.org \
--cc=geoffrey.ferrari@oriel.oxon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).