From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35362: 26.2; [debbugs.el] Automate commit -> debbugs flow (posting patches, closing bugs after pushing) Date: Tue, 23 Apr 2019 10:03:39 +0200 Message-ID: <87tvep87xg.fsf@gmx.de> References: <874l6rtnjo.fsf@gmail.com> <871s1vtm9h.fsf@gmail.com> <87wojns7ia.fsf@gmail.com> <875zr7cepw.fsf@gmx.de> <87d0ldsu6w.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173281"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35362@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 10:04:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIqPW-000iqf-EB for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 10:04:14 +0200 Original-Received: from localhost ([127.0.0.1]:49740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIqPV-0000sr-Ch for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 04:04:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIqPL-0000s6-R0 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 04:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIqPK-0002yF-Je for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 04:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIqPK-0002y5-Es for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 04:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIqPK-0003ht-61 for bug-gnu-emacs@gnu.org; Tue, 23 Apr 2019 04:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2019 08:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35362-submit@debbugs.gnu.org id=B35362.155600662914229 (code B ref 35362); Tue, 23 Apr 2019 08:04:02 +0000 Original-Received: (at 35362) by debbugs.gnu.org; 23 Apr 2019 08:03:49 +0000 Original-Received: from localhost ([127.0.0.1]:52271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIqP7-0003hQ-8t for submit@debbugs.gnu.org; Tue, 23 Apr 2019 04:03:49 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:40843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIqP5-0003hB-Hx for 35362@debbugs.gnu.org; Tue, 23 Apr 2019 04:03:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556006621; bh=gaz4Ds2lm8XJBXvYsPLEFTL/NaBdaQhYq0z89fFmIPM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=hR9Rx4kT6FC+iQOZlT/FgL9e8Avzaj0KsT/HT7lC7iGaIGJ9XvEkzJwZzuO4tohee XJdockna2wJ7ui2uByQF6sqb20TnYdZJozC+AcwXUBNcjnC02othALXgvrgaXQgoLC FG2GFeSWCVWNOFEoBM7Iwj00hnQa5RSwpea6w/Ok= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.38.216]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LwrwO-1glhQa3GFk-016L1Q; Tue, 23 Apr 2019 10:03:40 +0200 In-Reply-To: <87d0ldsu6w.fsf@gmail.com> (Noam Postavsky's message of "Mon, 22 Apr 2019 15:42:31 -0400") X-Provags-ID: V03:K1:9laCsk2Nfv2ouE3mDkoB+FuQSPR0gsR2H52E4gqK1m9YTM2CG/q Lnu8zPp84t7Io/TwLtIHMkB1DBzn0fsEiI1AVzYeCpUdnCMBjbuonLlPDmOaZUyifBVyBqa qCMQnddd6OGo8n8TeZBMBYisguiJ4qo0aHYzqPVm3HL8nLe48ysAA7y8PKfo8p0uGgR2GM3 EzyPlLuFNLVYo+WFt3LAA== X-UI-Out-Filterresults: notjunk:1;V03:K0:zXLW4/SxLiA=:JUW549hvj9iRUNl/kuzhhV iigU5jff22RyH1X6CDPp4pW9cEX7GpfyBCXYuk3/plEcSsWtjHXDSmLIAK+9GVt+76ik2IHyq Pa893wMqqpodGu8lQSyxIBN88cGVVJYowyHPU2mjLESuFxZIEMGVwIQfQ9X6QJ6Zn15wQsl+N 1CVmd5ChdKI4gtWa5UOOeZmDiQGIw/DkjxtcwRHSabfGVFYB75sSp/jp99JlT7jlu4hALkE2k w81jFxcqobSFqkLE4CfD9Jp9KPcjiwKgbZNs2lno6e8q3INl7FXyGsq+HF1hWjYmgqha+KOM+ ykDgQ54yUSVz9j+4it+luvYtUbuIQZrqDB/WajCMmTEPOSZakTP6u2wyq7oneY+OFOVApuC/j xD8L3tMM9qZkVg/D7aAoYfmXyGazuR06MSjRIfM52RuWJHvWMQLAQNVR8C4vr62Pqhafutzbl F6TCza1OibcrXG20trd6otjUr5Pl4u09/KiNvYi/wC96eqFR301um9P/vONWcjQxEFoiF0Tpm JFarXk/ziIb/4Va2NqumPsJVn8TfLSn9HHolxw5cLSZ2sMCKjIKrlhw28+Ojxj/WgDMEz8TkM PD2l/WNkklrw0tRvBquHWot418nxZqUJiXhTqge3ViLm7/t9ceGgo1JGNOJW8wePPGsnEsojc kvz/mjzd0IHCGB0ZBZaG06oP3qrlPqIeVZICoG9XtMBPrLgG1k4kGfDdQs7YVt7tA+PEuC+R5 1P30TQjxveiC8pAwUa81BAiSTOJwibt5ZTB0z+fU2oBe/Kj9k956Ttxn9QH+AY/o6QUvW99D X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158101 Archived-At: Noam Postavsky writes: Hi Noam, >> All your defcustoms miss a :version tag. I guess, "27.1" is proper. > > Oh, hmm. Shouldn't the version correspond to the debbugs.el package > version, since it's not tied to the Emacs version as such? I usually take the Emacs version for the :version attribute. Debbug's own version would be better tagged with :package-version; I haven't used this attribute, 'tho. >> debbugs-gnu.el supports both gnus and rmail. Do we miss something for >> rmail then? >> >> (I'm not an rmail user, but Eli is.) > > Possibly yes, I haven't used rmail so I'm not sure how to test that out. Me neither. Let's keep it as it is, waiting for protest ... or patches. >>> +(defun debbugs-gnu--git-insert (&rest args) >>> + "Insert output of running git with ARGS. >>> +Throws error if git returns non-zero. Uses `debbugs-gnu-git-program'." >>> + (unless (eql 0 (apply #'process-file >>> + debbugs-gnu-git-program nil '(t t) nil >>> + args)) >>> + (error "git %s failed: %s" (car args) (buffer-string)))) >> >> Why not `vc-git--call'? > > I thought relying on a function marked as internal would not be a good > idea for an ELPA package which should potentially work across multiple > versions of Emacs. Otherwise vc-git--call should work fine too. Right. However, this function is stable for years. And its implementation looks more robust than your version. > Once you have committed a patch fixing a bug you usually want to post > it to the bug thread for review and testing. And when the patch is > deemed satisfactory and pushed to the official repository, the bug > should be marked closed. Well, this is about local commits, which haven't been pushed yet. Or maybe pushed already, but in a branch. Could you pls say? > For example, suppose you are reading the message of ``Bug#1234: All other examples in this manual use 12345. Do we want to follow? > Invoke the command @code{debbugs-gnu-pick-commits} and press Should we give this command a key binding? > @kbd{RET} to accept the default bug number (which will be 1234 since This should be @kbd{@key{RET}}, like at other places in this manual. > @vindex debbugs-gnu-read-commit-range-hook > The query for commit (or commit range) to use is controlled by > @code{debbugs-gnu-read-commit-range-hook}. Initially it has an entry > which operates in @samp{*vc-change-log*} buffers: the default will be > the commit under point, or the commit range contained in the region if > it is active. I don't understand (yet), how the description of this variable helps. Is the user expected to change the value herself, somehow? Otherwise, we might to keep this description out. > Additionally, if the remote url matches an entry in > @code{debbugs-gnu-git-remote-info-alist}, then its @code{commit-url} > subitem is appended to the commit description. By default this > variable is configured for the GNU Emacs and GNU ELPA repositories. Maybe you add a short sentence, that it is expected that people adapt this user option if they run an own Emacs fork, located somewhere else, or if they host a repository for own packages. Best regards, Michael.