From: Noam Postavsky <npostavs@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: 36539@debbugs.gnu.org
Subject: bug#36539: elec-pair.elc gets surreptitiously loaded (almost) unconditionally at start up.
Date: Sun, 07 Jul 2019 14:47:51 -0400 [thread overview]
Message-ID: <87tvbx3cmg.fsf@gmail.com> (raw)
In-Reply-To: <20190707182941.GA4053@ACM> (Alan Mackenzie's message of "Sun, 7 Jul 2019 18:29:41 +0000")
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
Alan Mackenzie <acm@muc.de> writes:
> Just as a matter of interest, I commented out the pertinent form in
> emacs-lisp-mode, did a make bootstrap, emacs -Q, and elec-pair.elc was
> still present in my Emacs. :-(
>
> I don't know why, or how, but it is. With your patch (below), have you
> tested whether or not elec-pair.elc hasn't been loaded on starting
> Emacs? If it hasn't been loaded, you've found some trick that eludes
> me.
How are you checking? M-: (featurep 'elec-pair) RET returns nil for me.
Assuming you have help-enable-completion-auto-load set to t (the
default), it's pretty easy to load various things just by hitting TAB in
response to describe-function or describe-variable.
>> + (add-hook 'electric-pair-mode-hook #'emacs-lisp-set-electric-text-pairs t)
>
> Shouldn't that be .....-text pairs nil t), to make a local value of the
> ^^^
> hook? The remove-hook (above) seems to be expecting a local value.
Oops, yes, thanks for catching that.
>> + (setq-local electric-quote-string t)
>> (setq imenu-case-fold-search nil)
>> (add-function :before-until (local 'eldoc-documentation-function)
>> #'elisp-eldoc-documentation-function)
>> --
>> 2.11.0
>>
>
> As a matter of interest, what is that 2.11.0 that I keep seeing at the
> bottom of patches?
Looks like 'git format-patch' adds the git version at the bottom.
$ git --version
git version 2.11.0
[-- Attachment #2: updated patch --]
[-- Type: text/plain, Size: 1926 bytes --]
From c3a99c7260e07692c8d02a9cd9d38f6ef188311c Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sun, 7 Jul 2019 12:22:37 -0400
Subject: [PATCH] Don't load elec-pair in elisp-mode (Bug#36539)
* lisp/progmodes/elisp-mode.el (emacs-lisp-set-electric-text-pairs):
New function.
(emacs-lisp-mode): Add it to electric-pair-mode-hook.
---
lisp/progmodes/elisp-mode.el | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index c86277a309..78a87f2d32 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -233,6 +233,12 @@ emacs-lisp-mode-hook
:type 'hook
:group 'lisp)
+(defun emacs-lisp-set-electric-text-pairs ()
+ (defvar electric-pair-text-pairs)
+ (setq-local electric-pair-text-pairs
+ (append '((?\` . ?\') (?‘ . ?’)) electric-pair-text-pairs))
+ (remove-hook 'electric-pair-mode-hook #'emacs-lisp-set-electric-text-pairs t))
+
;;;###autoload
(define-derived-mode emacs-lisp-mode prog-mode "Emacs-Lisp"
"Major mode for editing Lisp code to run in Emacs.
@@ -245,12 +251,8 @@ emacs-lisp-mode
(defvar project-vc-external-roots-function)
(lisp-mode-variables nil nil 'elisp)
(add-hook 'after-load-functions #'elisp--font-lock-flush-elisp-buffers)
- (unless noninteractive
- (require 'elec-pair)
- (defvar electric-pair-text-pairs)
- (setq-local electric-pair-text-pairs
- (append '((?\` . ?\') (?‘ . ?’)) electric-pair-text-pairs))
- (setq-local electric-quote-string t))
+ (add-hook 'electric-pair-mode-hook #'emacs-lisp-set-electric-text-pairs nil t)
+ (setq-local electric-quote-string t)
(setq imenu-case-fold-search nil)
(add-function :before-until (local 'eldoc-documentation-function)
#'elisp-eldoc-documentation-function)
--
2.11.0
next prev parent reply other threads:[~2019-07-07 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 14:14 bug#36539: elec-pair.elc gets surreptitiously loaded (almost) unconditionally at start up Alan Mackenzie
2019-07-07 16:57 ` Noam Postavsky
2019-07-07 18:29 ` Alan Mackenzie
2019-07-07 18:45 ` Eli Zaretskii
2019-07-07 19:14 ` Alan Mackenzie
2019-07-07 18:47 ` Noam Postavsky [this message]
2019-07-07 19:10 ` Alan Mackenzie
2019-07-07 19:17 ` Eli Zaretskii
2019-07-13 11:54 ` Eli Zaretskii
2019-07-13 22:41 ` Noam Postavsky
2019-07-19 0:09 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvbx3cmg.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36539@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).