From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#36644: Git log search Date: Tue, 16 Jul 2019 23:15:32 +0300 Organization: LINKOV.NET Message-ID: <87tvbliw37.fsf@mail.linkov.net> References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="16526"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 36644@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 16 22:29:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hnU4W-0004Bs-58 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jul 2019 22:29:12 +0200 Original-Received: from localhost ([::1]:52166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnU4T-0007NR-K7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jul 2019 16:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38831) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnU4O-0007Dy-CD for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 16:29:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnU4N-0000Mk-9x for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 16:29:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42402) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnU4N-0000Mb-6T for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 16:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hnU4N-0006dF-1D for bug-gnu-emacs@gnu.org; Tue, 16 Jul 2019 16:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jul 2019 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs Original-Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156330889525392 (code B ref 36644); Tue, 16 Jul 2019 20:29:02 +0000 Original-Received: (at 36644) by debbugs.gnu.org; 16 Jul 2019 20:28:15 +0000 Original-Received: from localhost ([127.0.0.1]:51219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnU3a-0006bU-Mf for submit@debbugs.gnu.org; Tue, 16 Jul 2019 16:28:14 -0400 Original-Received: from bonobo.birch.relay.mailchannels.net ([23.83.209.22]:19435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hnU3X-0006b4-9s for 36644@debbugs.gnu.org; Tue, 16 Jul 2019 16:28:11 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1721E8C089F; Tue, 16 Jul 2019 20:28:10 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-1-113.trex.outbound.svc.cluster.local [100.96.1.113]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8DF358C2545; Tue, 16 Jul 2019 20:28:09 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Tue, 16 Jul 2019 20:28:09 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Sponge-Zesty: 1deb99d3782fc62f_1563308889895_2443496174 X-MC-Loop-Signature: 1563308889895:3267189229 X-MC-Ingress-Time: 1563308889895 Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 7BF56803B9; Tue, 16 Jul 2019 13:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=V/4PaUFVFCW/9iIDNerA4lMe3+U=; b= da2mHHzBDKTwdyj5xDKbKcePyd6jPpOXj/LPC+y3ihMdafzsjA0roXUqvf8tTzB6 2v2eGJrWn0jlaCcEZ5TaaGZTg1FTlFNKAjGNlQcFw3fHhjuhHKkHE42FZyxcgzLR qX8KCV7W/AyixRM6mLzh6M9TpSSE9quLrNPt49l1tvw= Original-Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 6FAAA803B3; Tue, 16 Jul 2019 13:28:05 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a6 In-Reply-To: <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> (Dmitry Gutov's message of "Tue, 16 Jul 2019 17:25:39 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddriedtgdduheegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrddufeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrudefgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163206 Archived-At: >>> Is pattern a regexp or a verbatim string? That should be documented. >> >> Fixed to use string. > > Since --grep expects a regexp, shouldn't PATTERN be passed through > regexp-quote as well? Though it expects Emacs regexps, so it doesn't quote > parens or pipes. Should this still be used when the need is to pass regexps to the backend search command verbatim? >>> Git supports regexps, but maybe we should look at what other backends >>> can support as well. >> >> It seems the most compatible type is string. > > OK, if that is your conclusion. I'm still not sure. Regexps are more useful. >>> I wonder if the format of the output should be specified as well. >>> E.g. by saying that it's the same as for print-log, long version. >> >> Fixed by saying it's long version. >> >> Should it support short format as well? > > I don't know. How would it be used? Short format displays one line per entry and allows expanding after pressing RET. OTOH, when using long format we could highlight all matches in log entries that will be immediately visible after the command finishes (like in vc-git-grep output buffers). However, when allowed to use regexp patterns, I don't know how to highlight matches in git-log output buffer using Emacs regexps when pattern uses e.g. Perl-compatible regexp allowed in git-log. >> Should it have a key binding? >> >> For example, `vc-log-incoming' is bound to `C-x v I', >> `vc-log-outgoing' is bound to key `C-x v O', so logically >> `vc-log-search' would be bound to `C-x v s', but unfortunately >> it's already taken by `vc-create-tag'. > > 'C-x v S', then? This is good mnemonic keybinding. The only doubt when adding a new keybinding is to think if it could be more useful as a prefix key. Maybe in this case upper-case shifted 'S' is not good as a prefix key. Otherwise such prefix key could accommodate other vc search related commands like grep vc files, etc.