From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35481: 25.2; table.el should use 'font-lock-face' instead of 'face' Date: Thu, 28 Nov 2019 18:27:28 -0500 Message-ID: <87tv6nd1jz.fsf@gmail.com> References: <89093c47-6449-8518-1d77-d43ba9b68891@gmail.com> <87d0eeow6p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111863"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Sebastian Urban , 35481@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 29 00:28:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iaTDP-000Sx1-8l for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Nov 2019 00:28:51 +0100 Original-Received: from localhost ([::1]:53970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaTDN-0002z6-6I for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Nov 2019 18:28:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43217) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaTCg-0002wk-Rf for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 18:28:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaTCd-0000d8-Vc for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 18:28:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iaTCb-0000Zn-Tc for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 18:28:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iaTCb-0003D3-R1 for bug-gnu-emacs@gnu.org; Thu, 28 Nov 2019 18:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Nov 2019 23:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed easy patch Original-Received: via spool by 35481-submit@debbugs.gnu.org id=B35481.157498365812306 (code B ref 35481); Thu, 28 Nov 2019 23:28:01 +0000 Original-Received: (at 35481) by debbugs.gnu.org; 28 Nov 2019 23:27:38 +0000 Original-Received: from localhost ([127.0.0.1]:59243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaTCD-0003CP-Rd for submit@debbugs.gnu.org; Thu, 28 Nov 2019 18:27:38 -0500 Original-Received: from mail-qk1-f178.google.com ([209.85.222.178]:46453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaTCC-0003C9-Tr for 35481@debbugs.gnu.org; Thu, 28 Nov 2019 18:27:37 -0500 Original-Received: by mail-qk1-f178.google.com with SMTP id f5so5674833qkm.13 for <35481@debbugs.gnu.org>; Thu, 28 Nov 2019 15:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jIoeH2x5FVf+keXSou7t5jTXxm6iPQ+oadvDMZ7Fe4k=; b=uaxJCxrqp73uqHL0qIu+DftksNA3nmnlysTuEMB1tQ7ZSiOTb2HxJZcW97KYRLvSTr Ah4RW/tbSFLcYf8OrkjJKmShEdHKq8B1qz6hUflb15lvVEKOGcmCM+B0GtvLOExHEx9O af4RU8YzhfiX+lrYjzXrAJMrb7Czxa2E7uDYwWzaVduGn73ptKelYnSRdGGKY5EHbQj6 mrGR5c61FiQ4DJSjYT+x1T78Q/E4A2116H8a1PHGFcP2Q/sXXtskTiwYE27YsijWJyB9 dDYDdpJGFZ77Elbx9nzaeslkf8R+cFCpYHerfNGUoQY/a3gZXSq/+7+oGPIgppODe8UK BNsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jIoeH2x5FVf+keXSou7t5jTXxm6iPQ+oadvDMZ7Fe4k=; b=heiP/XllQW0ObpW5HhM88EU3f6Vji5wyvAx3bttZvO77+PW267GK3+FBSKvvseS8kO 8FggiNpSSgqR27M1S9Gh+8SvcMuEJ1tU8fguNZWabO8Q/7o70hFSY4G/wDNDfXYxyuGr XKyZ5/fuB/+obdvlx6z3GruvjvdJ0nQeBFVI0+YzBjThI0MMlD8puhF/QL2b7lUk3Xu7 Zt9WfA8UiCi3r2iXnSJeFElfVjcsToxlzLsXB7+cg3MZdEDg/IOOEcCicgaX4NR6NENv xx+fpRH2Fw7JR5hPjeRuwvRzS/CUIE+yZNg2Wdhz8TvMA0gzZlUP5fwlYtNRpY8OhK8Q DiRQ== X-Gm-Message-State: APjAAAWNHGRyzynD6dR5Vd3BtryOcEHFy7Q5SKwL7YMifqbCqIQbkUki 40wudrDBphPS4jnivw31A+HYQjiE X-Google-Smtp-Source: APXvYqzDcAlhqyW5azTnN/35N1x1Rk07rBX3gWHkzR/mmjsSol7lOIfikjIaB/s+9rlsOytkrYWVgQ== X-Received: by 2002:a37:8504:: with SMTP id h4mr12904226qkd.276.1574983649414; Thu, 28 Nov 2019 15:27:29 -0800 (PST) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id o2sm9293055qkf.68.2019.11.28.15.27.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Nov 2019 15:27:29 -0800 (PST) In-Reply-To: <87d0eeow6p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Oct 2019 20:44:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172627 Archived-At: Lars Ingebrigtsen writes: > The patch below does this, but I'm not sure it's right. When we're > using font-lock-face instead of face, then things work as normal when > we're using global-font-lock-mode, but if that's off, then we won't get > any faces at all. > > Which would be bad. I missed this the first time around, but, why would that be bad? If the user turns off font-lock-mode then not getting faces should be expected, no?