From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41372: 28.0.50; [PATCH] Wrong value of tab-bar-tab-name-ellipsis Date: Wed, 20 May 2020 01:35:56 +0300 Organization: LINKOV.NET Message-ID: <87tv0b7dtf.fsf@mail.linkov.net> References: <87imguchpw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="78724"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41372@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 00:47:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbB0z-000KNp-L0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 00:47:13 +0200 Original-Received: from localhost ([::1]:39838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbB0y-0006DS-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 18:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbB0p-0006B8-D6 for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbB0p-0007CT-3x for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbB0p-0004QI-2g for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:47:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 May 2020 22:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41372 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41372-submit@debbugs.gnu.org id=B41372.158992841416962 (code B ref 41372); Tue, 19 May 2020 22:47:03 +0000 Original-Received: (at 41372) by debbugs.gnu.org; 19 May 2020 22:46:54 +0000 Original-Received: from localhost ([127.0.0.1]:51421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbB0g-0004PP-69 for submit@debbugs.gnu.org; Tue, 19 May 2020 18:46:54 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:42555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbB0U-0004Od-Ol for 41372@debbugs.gnu.org; Tue, 19 May 2020 18:46:43 -0400 X-Originating-IP: 91.129.97.200 Original-Received: from mail.gandi.net (m91-129-97-200.cust.tele2.ee [91.129.97.200]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CEFEF20007; Tue, 19 May 2020 22:46:35 +0000 (UTC) In-Reply-To: <87imguchpw.fsf@gmail.com> (Matthias Meulien's message of "Mon, 18 May 2020 00:35:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180627 Archived-At: > When I evaluate (char-displayable-p ?…) from current frame (under X) it > evaluates to a valid font but, after I customized > `tab-bar-tab-name-function` to equal `tab-bar-tab-name-truncated`, tab > names are truncated using three dots characters. Thanks for the patch. One problem is that the patch hard-codes the ellipsis, so that the user loses the ability to configure it. A better way would be to leave defvar tab-bar-tab-name-ellipsis, but by default set its value to nil. So when it's non-nil, then use its value, otherwise use "…"/"..." by default. > -(defvar tab-bar-tab-name-ellipsis > - (if (char-displayable-p ?…) "…" "...")) > - > (defun tab-bar-tab-name-truncated () > "Generate tab name from the buffer of the selected window. > -Truncate it to the length specified by `tab-bar-tab-name-truncated-max'. > -Append ellipsis `tab-bar-tab-name-ellipsis' in this case." > - (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window))))) > +Truncate it to the length specified by `tab-bar-tab-name-truncated-max'." > + (let ((tab-name (buffer-name (window-buffer (minibuffer-selected-window)))) > + (ellipsis (if (char-displayable-p ?…) "…" "..."))) > (if (< (length tab-name) tab-bar-tab-name-truncated-max) > tab-name > (propertize (truncate-string-to-width > tab-name tab-bar-tab-name-truncated-max nil nil > - tab-bar-tab-name-ellipsis) > + ellipsis)