unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39735@debbugs.gnu.org, ynyaaa@gmail.com
Subject: bug#39735: 27.0.60; bugs about XBM images
Date: Sun, 02 Aug 2020 16:36:03 +0200	[thread overview]
Message-ID: <87tuxlglnw.fsf@gnus.org> (raw)
In-Reply-To: <835za1ceqe.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Aug 2020 17:19:21 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> Eli, would it make sense to do a backwards-incompatible change here and
>> rename the XBM parameters to :xbm-width and :xbm-height?
>
> Given the relative unimportance of XBM, that doesn't sound like a good
> idea.
>
> Can't we instead add new parameters, so that the change is
> backwards-compatible?

Do you mean adding :display-width and :display-height to the XBM
handlers (that would work like :width/:height in all the other image
handlers)?  I guess that would work, but it's rather awkward -- the code
that calls `create-image' would then have to check whether the image is
XBM or not to know what parameters to use...

Since XBM is so obscure, we could just document that XBM just doesn't
support scaling, and that it's an error to give those parameters (unless
you really mean XBM dimensions).  But again, that also means that
somebody that writes a loop of `create-images' must be careful to not
call it on XBM images...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-02 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-22 14:09 bug#39735: 27.0.60; bugs about XBM images ynyaaa
2020-08-02  8:38 ` Lars Ingebrigtsen
2020-08-02 14:19   ` Eli Zaretskii
2020-08-02 14:36     ` Lars Ingebrigtsen [this message]
2020-08-02 16:26       ` Eli Zaretskii
2020-08-02 17:04         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuxlglnw.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=39735@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=ynyaaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).