From: Sean Whitton <spwhitton@spwhitton.name>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43120@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice
Date: Thu, 03 Sep 2020 16:23:54 -0700 [thread overview]
Message-ID: <87tuwewik5.fsf@iris.silentflame.com> (raw)
In-Reply-To: <87o8mpd1fw.fsf@gnus.org>
Hello Lars,
On Tue 01 Sep 2020 at 04:19PM +02, Lars Ingebrigtsen wrote:
> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> I think the fix would be to clear completion-content-when-empty when the
>> minibuffer exits, instead of leaving data from the last completion
>> there.
>
> Oh yeah, definitely -- it should be cleared on minibuffer exit. I'm
> guessing that should go in... `completion--complete-and-exit'? Would
> it be possible for you to propose a patch that does that? I don't use
> fido-mode myself, and it's probably easier for you to test whether
> that's the right fix.
I'm certainly happy to test a patch but I don't think that can be the
right place to clear the variable.
The docstring for that function says it exits from a require-match
minibuffer. But completion gets used in other minibuffers too. So we
need to clear the variable somewhere which gets called for every
minibuffer exit.
--
Sean Whitton
next prev parent reply other threads:[~2020-09-03 23:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 21:00 bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Sean Whitton
2020-08-30 23:50 ` João Távora
2020-08-31 16:37 ` Sean Whitton
2020-09-01 14:16 ` Lars Ingebrigtsen
2020-09-01 18:27 ` João Távora
2020-09-03 12:40 ` João Távora
2020-09-03 13:11 ` Lars Ingebrigtsen
2020-09-03 13:13 ` João Távora
2020-09-03 13:51 ` Lars Ingebrigtsen
2020-09-03 13:55 ` João Távora
2020-09-01 14:19 ` Lars Ingebrigtsen
2020-09-03 23:23 ` Sean Whitton [this message]
2020-09-04 2:11 ` Lars Ingebrigtsen
2020-09-04 3:22 ` Sean Whitton
2020-09-04 3:27 ` Lars Ingebrigtsen
2020-09-04 14:47 ` Sean Whitton
2020-09-05 12:25 ` Lars Ingebrigtsen
2020-09-05 15:32 ` Sean Whitton
2020-09-05 21:12 ` Lars Ingebrigtsen
2020-09-06 18:26 ` bug#19032: " João Távora
2020-09-07 10:30 ` Lars Ingebrigtsen
2020-09-07 10:37 ` bug#19032: " João Távora
2020-09-07 11:43 ` Lars Ingebrigtsen
2020-09-07 17:30 ` Stefan Monnier
2020-09-08 6:52 ` João Távora
2020-09-08 8:59 ` bug#19032: " João Távora
2020-09-09 14:01 ` OGAWA Hirofumi
2020-09-09 16:11 ` bug#19032: " João Távora
2020-09-09 17:52 ` Stefan Monnier
2020-09-09 19:13 ` bug#19032: " João Távora
2020-09-09 19:52 ` Stefan Monnier
2020-09-09 19:54 ` bug#19032: " João Távora
2020-09-09 19:57 ` João Távora
2020-09-09 20:35 ` bug#19032: " Stefan Monnier
2020-09-09 22:08 ` João Távora
2020-09-10 4:36 ` Stefan Monnier
2020-09-10 18:51 ` bug#19032: " Juri Linkov
2020-09-10 19:15 ` João Távora
2020-09-09 18:58 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuwewik5.fsf@iris.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=43120@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).