From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: dick.r.chiang@gmail.com Newsgroups: gmane.emacs.bugs Subject: bug#43202: patch Date: Fri, 04 Sep 2020 09:01:08 -0400 Message-ID: <87tuwdr90r.fsf@dick> Mime-Version: 1.0 Content-Type: text/x-diff Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16637"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) To: 43202@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 04 15:02:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEBMC-00048Y-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 15:02:20 +0200 Original-Received: from localhost ([::1]:37320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEBMB-0001ru-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Sep 2020 09:02:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEBLu-0001qh-Uq for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEBLu-0000zW-LG for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEBLu-0002Bc-Hk for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: dick.r.chiang@gmail.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Sep 2020 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43202 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15992244796229 (code B ref -1); Fri, 04 Sep 2020 13:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Sep 2020 13:01:19 +0000 Original-Received: from localhost ([127.0.0.1]:37938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBLC-0001c7-Vn for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:01:19 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:43908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEBLB-0001b5-No for submit@debbugs.gnu.org; Fri, 04 Sep 2020 09:01:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEBLB-0001Ij-CJ for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:01:17 -0400 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:36741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEBL9-0000vD-FR for bug-gnu-emacs@gnu.org; Fri, 04 Sep 2020 09:01:16 -0400 Original-Received: by mail-qt1-x831.google.com with SMTP id n10so4498803qtv.3 for ; Fri, 04 Sep 2020 06:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version :content-disposition; bh=1GMD20sdtIL5hAFr8BakS5fB+e6QdjC8AcdEdVVY1Ug=; b=XvqEGfVghsPwggI8OzAXYq9HzMoz+GwIL7is43wE/w4qBHCFqbz/ZV9vXYAfjUNSNr 41ZGoUJA1POO7u5lGZYpSETZv8tn6L6m/s3WJEPhX3WylXBVe/3RprafqfCK4Rq+grDq dQNpq7Ghl1ocMlcRvNr7BZfpGUFT7nTe8KrxVDipfWYQ2nt0otkmkFVVUF4reWx0UjXL vOnsuaCiPJp15b7YDFbuGUom20itUsj0K4qatM2zRrrnM2kkIPfNKGAFfGmGpmrZpXAY 7hUi5EnRBRggVRub32DBoUjH7lJQ/DMSBsFIKnuPC4KdxlN+9sQyc+MPRpjFOiw4Wyzo k15Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-disposition; bh=1GMD20sdtIL5hAFr8BakS5fB+e6QdjC8AcdEdVVY1Ug=; b=fqvBYGVQOHb+ILubVu/0AsSNkMgbr/tOzcITdaxXFQ7JkzYvEXqH+iRgIHmnQUrCAN ZnBSypCbjtRhKf+7NHEWIZWhCmRwWa+LXx5OUQNRZxswmhqvLVwyGAdQ9npGJbzlT0RK mNveydic72kMUpk+m1W6zP0B5UrEpRuHGh5p+DdlyLKO/wMa4Bq1AUTsi/SXA9sEbdXe i9KFZXTsFknF2AmiRf34yy6niw6qabr0FqUowyLcDE47U9jtJVtQDVSScpBUK3bSVhWJ l+l+/njiNFOp8vu73pMK4Mv1xh/0XEoHUJj+jZeIBHUfwzzCZRlERueP0vj2C5yU0Sni ffeg== X-Gm-Message-State: AOAM531HDOKkZILydhsRYTimpbI+mALfzHrN+W3/0QG+BZApAxFB7j66 5y9rPeiJkVW6zYjwVyKro8vFjIgOkPU= X-Google-Smtp-Source: ABdhPJxWeUgrljgwheRSFC+QFzNZVI9le2h+4jJxAAKJDg9kWckXzcgHlVs6GHe06i1Mk5m1FK35Xw== X-Received: by 2002:aed:364a:: with SMTP id e68mr8250663qtb.260.1599224471565; Fri, 04 Sep 2020 06:01:11 -0700 (PDT) Original-Received: from localhost (pool-108-30-234-29.nycmny.fios.verizon.net. [108.30.234.29]) by smtp.gmail.com with ESMTPSA id c13sm4464169qtq.5.2020.09.04.06.01.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Sep 2020 06:01:09 -0700 (PDT) Content-Disposition: inline; filename=0001-Squashed-commit-of-the-following.patch Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=dick.r.chiang@gmail.com; helo=mail-qt1-x831.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187124 Archived-At: >From 50446fc44e54a989db0863b5c8c887043e1226f9 Mon Sep 17 00:00:00 2001 From: dickmao Date: Fri, 4 Sep 2020 08:57:58 -0400 Subject: [PATCH] Squashed commit of the following: commit 4ceb578a9c9a93ea44f61e7453aae5b8c2ed90e6 Author: dickmao Date: Fri Sep 4 08:55:39 2020 -0400 avoid `Wrong type argument` in `list-processes--refresh` Should not expect sequencep from `process-command` for network, serial, pipe. * lisp/simple.el (list-processes--refresh): network, serial, *or pipe*. * test/src/process-tests.el (process-test-stopped-pipe): add a test. --- lisp/simple.el | 2 +- test/src/process-tests.el | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lisp/simple.el b/lisp/simple.el index eedbff2d08..e7eb33b200 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -4374,7 +4374,7 @@ list-processes--refresh ((thread-name (process-thread p))) (t "--"))) (cmd - (if (memq type '(network serial)) + (if (memq type '(network serial pipe)) (let ((contact (process-contact p t t))) (if (eq type 'network) (format "(%s %s)" diff --git a/test/src/process-tests.el b/test/src/process-tests.el index e15ad47f96..c45b00a776 100644 --- a/test/src/process-tests.el +++ b/test/src/process-tests.el @@ -105,6 +105,15 @@ process-test-stderr-buffer (goto-char (point-min)) (looking-at "hello stderr!"))))) +(ert-deftest process-test-stopped-pipe () + (skip-unless (executable-find "cat")) + (with-temp-buffer + (let ((proc (make-pipe-process :name "pipe" :buffer (current-buffer) + :command '("cat") :stop t))) + (unwind-protect + (should (list-processes--refresh)) + (delete-process proc))))) + (ert-deftest process-test-stderr-filter () (skip-unless (executable-find "bash")) (let* ((sentinel-called nil) -- 2.26.2