From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log Date: Wed, 09 Sep 2020 15:01:45 +0200 Message-ID: <87tuw79k92.fsf@gnus.org> References: <87d2kk4zcn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36332"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 16254@debbugs.gnu.org, Stefan Monnier To: Christoph Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 09 15:03:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzkm-0009Jx-Mt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 15:03:12 +0200 Original-Received: from localhost ([::1]:52904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFzkl-0005Xj-IQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 09:03:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFzkc-0005Sz-Fs for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 09:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFzkc-0001qg-5A for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 09:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFzkc-0006su-2d for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 09:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2020 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16254 X-GNU-PR-Package: emacs Original-Received: via spool by 16254-submit@debbugs.gnu.org id=B16254.159965652726365 (code B ref 16254); Wed, 09 Sep 2020 13:03:02 +0000 Original-Received: (at 16254) by debbugs.gnu.org; 9 Sep 2020 13:02:07 +0000 Original-Received: from localhost ([127.0.0.1]:57764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzji-0006rA-JY for submit@debbugs.gnu.org; Wed, 09 Sep 2020 09:02:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzjf-0006qG-PA for 16254@debbugs.gnu.org; Wed, 09 Sep 2020 09:02:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yxodHLWJ8AbsYFqn4/3Jb33mFGuXOoZb70/bFvaGhfI=; b=D1GEuDbQZHqZd1hoXLtBI7xTNh NerWWa3JyusVWYUDoI/hGsSwqMQAy58gimm3ohcLylZbhiTKlT3s7O4sb5OvQME9unIlAvjig5dQI mC4zkVV1Ygu87wanMJXnaqG3KXEdiLDJJDOVEPCpn1kFmhkAWoA1yk4CetW6LPRpX2Vk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzjO-0002mI-Kk; Wed, 09 Sep 2020 15:01:56 +0200 X-Now-Playing: LCD Soundsystem's _Freak Out Starry Eyes_: "Freak Out Starry Eyes" In-Reply-To: (Christoph's message of "Thu, 26 Dec 2013 19:47:07 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187642 Archived-At: Christoph writes: > The following patch adds detection (and filtering) of unregistered members to > vc-dired-deduce-fileset. > If the marked files have any unregistered files among them, the unregistered files > are filtered out. > If all files are unregistered, an error is shown. This also covers the main case of > selecting just one unregistered file/directory. [...] > (defun vc-dired-deduce-fileset () > - (let ((backend (vc-responsible-backend default-directory))) > - (unless backend (error "Directory not under VC")) > - (list backend > - (dired-map-over-marks (dired-get-filename nil t) nil)))) > + "Deduce a set of files and a backend to which to apply an > +operation from all the marked items in a dired buffer. Resulting > +fileset only includes items that are version controlled." > + (let ((backend (vc-responsible-backend default-directory)) > + (fileset > + (delq nil (mapcar > + (lambda (x) (if (not (equal (vc-backend x) nil)) x)) > + (dired-map-over-marks > + (dired-get-filename nil t) > + nil))))) The code in question has changed substantially since this patch was proposed six years ago. It's now: (defun dired-vc-deduce-fileset (&optional state-model-only-files not-state-changing) (let ((backend (vc-responsible-backend default-directory)) (files (dired-get-marked-files nil nil nil nil t)) only-files-list state model) If I'm reading it correctly, it... more or less covers the same things that this patch was supposed to do (but in a totally different way?), so I guess this patch is no longer necessary. So I'm closing this bug report. If there still is something here that needs fixing, please respond to the debbugs address, and we'll reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no