From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42708: Let users copy "*Char Help*" buffer Date: Mon, 09 Nov 2020 14:39:24 +0100 Message-ID: <87tutymyyb.fsf@gnus.org> References: <87r1smy1du.5.fsf@jidanni.org> <877duerlw2.fsf@mail.linkov.net> <87h7the985.fsf@gnus.org> <87a6z8pr7f.fsf@mail.linkov.net> <87bljogscr.fsf@gnus.org> <87r1q27rvz.fsf@gnus.org> <87pn4u1fxq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24246"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42708@debbugs.gnu.org, rms@gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 09 14:51:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc7aF-00069k-MK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Nov 2020 14:51:47 +0100 Original-Received: from localhost ([::1]:54528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc7aE-0000zI-MZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Nov 2020 08:51:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc7Ot-0005X9-2I for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 08:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kc7Os-0000s1-KQ for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 08:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kc7Os-0004XV-H0 for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 08:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Nov 2020 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 42708-submit@debbugs.gnu.org id=B42708.160492918317419 (code B ref 42708); Mon, 09 Nov 2020 13:40:02 +0000 Original-Received: (at 42708) by debbugs.gnu.org; 9 Nov 2020 13:39:43 +0000 Original-Received: from localhost ([127.0.0.1]:34278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc7OZ-0004Wt-6p for submit@debbugs.gnu.org; Mon, 09 Nov 2020 08:39:43 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:41868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc7OX-0004Wf-BJ for 42708@debbugs.gnu.org; Mon, 09 Nov 2020 08:39:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0nuW7a1vz+b+fJv3RTxBNaK3bslbqX2s/B6/pCWOG+s=; b=ZM+ZJdQh8yRFMwwh515FCAGRic BfoOj/PUu+xNvYJM4I72v2mkPUqTbB4wZqXbEees1uqc3c/b4IVg5kcfBT7lde+D7yanddduUlokB hy7z36eO0/99axI0omAxzHE2g8L6kEy8yALCmVUJHiL9mG5D3opQwaaAmBIpWdtKoUr4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc7OH-0006Jr-Fz; Mon, 09 Nov 2020 14:39:31 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWNcEWKazxBPTcZ GRhqVjalop5iW1D////0J7WRAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QLCQ0fOKZZqPwAAAF1SURB VDjLjdNLbsIwEAbgCSpdZ1BOMKZdV3EPUFo3ayph1mDA9z9C52EnQINUL6I4n//xIwkANOh8aW/I zXogjR6CuwYbBqjwHqQtDHQYNAK0VlgeAbApoGMq/Ghhegju33ApQH8BZXKNQMuQJtCeAt+1IV0D DlKLa2Lb5Tp5BSfQtCGfCzT8vBuSAWcMuuUWClCFI3aS2Foic60RUMESOU3QYLeRUtwR8LXUgd8j Fgg3oMUFUCC7aXIF3YfASaDFzXDuMFxD8vIcN1/nq50LZMcHwltw9UhkN+GZ4SSfVee9fQzLnVxj ZEgyNd7DnkUOcR5kulmQW1dhr6/LQNbzWSHKsj8Meo1U0IiB10hP0i5RI98GGvEKFC2SFSySFF4s ImfCv4BGssJrjLsKsNDIkOospRa0K1vSfQRgRT7MRARmIwBPNBthCHMRhZw1crv9AtZqJMofRTTB GBHoaT3CGBHgYYcRakTB0+sINWLQ0x3Qhe9+AZmV4HV5ZwfbAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIwLTExLTA5VDEzOjMxOjU1KzAwOjAwL19ydgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMS0w OVQxMzozMTo1NSswMDowMF4CysoAAAAASUVORK5CYII= X-Now-Playing: Chrome Hoof's _Chrome Black Gold_: "When the Lightning Strikes" In-Reply-To: <87pn4u1fxq.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 03 Nov 2020 20:57:37 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192921 Archived-At: Juri Linkov writes: > I tried to reproduce the original test case. i.e. to type 'C' > (dired-do-copy) and select the "*Char Help*" buffer with C-x o. > The result is weird: the cursor in displayed in the minibuffer, > but the selected window is "*Char Help*". Here's a patch to fix this: [...] > - (let ((cursor-in-echo-area t) > - (executing-kbd-macro executing-kbd-macro) > + (let ((executing-kbd-macro executing-kbd-macro) I haven't tried the patch -- does this have any other effect than fixing the problem with the cursor in the wrong buffer? I'm not quite clear on what the effects of cursor-in-echo-area are... > After looking more at 'read-char-choice', it seems that special handling > of 'inhibit-keyboard-quit' and 'executing-kbd-macro' is not needed > anymore? And maybe also adding the 'minibuffer-prompt' face is not > needed too. Then what remains to do in 'read-char-choice' is to call > 'read-char-from-minibuffer' and to show 'help-form-show' for 'help-char' key? Sounds reasonable (without having looked at the code more than cursorily). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no