From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#45798: 28.0.50; nsm-check-local-subnet-ipv4 fails with nsm-trust-local-network Date: Tue, 12 Jan 2021 10:34:36 +0100 Message-ID: <87turm1osz.fsf@gmail.com> References: <875z43wa2o.fsf@tcd.ie> <87mtxf2oy6.fsf@gmail.com> <87lfczt6ti.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16818"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45798@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 10:35:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzG5V-0004Gj-3Y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 10:35:41 +0100 Original-Received: from localhost ([::1]:34470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzG5T-0000GS-Uq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 04:35:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzG4t-0000FY-KC for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 04:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzG4s-00056k-5k for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 04:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzG4s-00052m-31 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 04:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 09:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45798 X-GNU-PR-Package: emacs Original-Received: via spool by 45798-submit@debbugs.gnu.org id=B45798.161044408719351 (code B ref 45798); Tue, 12 Jan 2021 09:35:02 +0000 Original-Received: (at 45798) by debbugs.gnu.org; 12 Jan 2021 09:34:47 +0000 Original-Received: from localhost ([127.0.0.1]:59302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzG4c-000523-T6 for submit@debbugs.gnu.org; Tue, 12 Jan 2021 04:34:47 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:39772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzG4a-00051m-KA for 45798@debbugs.gnu.org; Tue, 12 Jan 2021 04:34:45 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id c5so1716503wrp.6 for <45798@debbugs.gnu.org>; Tue, 12 Jan 2021 01:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=v75M7cRSjdRsI3v2//V7TRMzDiu9/kMSGAPpHwZzN/c=; b=gL/2JzaZ9iJoKR0hk2x6EBLKjAlkeeSfni9fMU27WEr7xA0+9UlG5RTm+yR4r8yjGV LIg4f2x8GE77tZg3mUVf60H5/bXzrKkr37POYPxdc1EcBTypk7gi/XuifLTLEc2U1tpf fe0g/lHtc77Z7HqDGJ8MNVDnYzlfFgI01Q7tR1sltY9wmsbsApzlm9GP1EkmUFqdgFba sX3ophHcFkNcMPizoFeMhaRvqlx5sM3t/v8ym85zxqmhZNP+5fRqp3+jo6TOn0gdYyYg o8kNOW/Wo/lGiaJ6MOSmflQhC2TKxyOyF/GZOG4AwyQ/XgFvnILvuWaFr80Q/hYejeKj IQDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=v75M7cRSjdRsI3v2//V7TRMzDiu9/kMSGAPpHwZzN/c=; b=j+yTi27M1U5Nd7drMLWWru71iwZAiYN3aUuU08wVv5c+7X2RC0Ey6d3H8r46RvwJHX VTy0FGWqAdBDV9b+RuFDkTp5GVT9iG0fiW0LG2KWZoPkuUkOUD9N+8GoXKpbqxzMHK5d BYy5tO7jwggFwSBil+49kfoZ5h/HfACIdkzmh/brd4eW7Sjvxffwk8qKApT1LoEt1si4 m7/hCecliqmaNoEFPBZM1Oz4mziZxMWiDk3DwG7UnadcIjo41OehUMVgqSNNk7wi5KvX cZHRbAZrGtpSrMlz7TZDKg5pV3O45fHS4+FKIXcEyFoHyVkwKmLfvT3mvYnG7alYMjPw 6cyQ== X-Gm-Message-State: AOAM531K06UACziDbBXo/hXkIltpUQphkcxK8g/sRMbmIeAr2kh63o8A BDEVpk7nO7414eCJ4mkgP9RhqD+rBRzGPg== X-Google-Smtp-Source: ABdhPJzhaKqd4IQQtIQGiBDdoEUUhCGJog7gryp00MwXa7taINF+A66SaVkkrkHvwP4SDmZCr3oQbw== X-Received: by 2002:a5d:68ce:: with SMTP id p14mr3255158wrw.386.1610444078198; Tue, 12 Jan 2021 01:34:38 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a861:69b6:6aaf:dbd3:8964]) by smtp.gmail.com with ESMTPSA id z6sm3750229wrw.58.2021.01.12.01.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 01:34:37 -0800 (PST) In-Reply-To: <87lfczt6ti.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 11 Jan 2021 23:03:21 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197779 Archived-At: "Basil L. Contovounesios" writes: > Oops, sorry! I must have been looking at the wrong value. There are > two cases where nsm-network-same-subnet returns non-nil, and in both > cases: > > addresses: > ([10752 5200 16395 3073 0 0 0 139 0] > [10752 5200 16395 3073 0 0 0 113 0] > [10752 5200 16395 3073 0 0 0 138 0] > [10752 5200 16395 3073 0 0 0 100 0] > [74 125 193 139 0] [74 125 193 101 0] > [74 125 193 102 0] [74 125 193 138 0] > [74 125 193 100 0] [74 125 193 113 0]) > > network-interface-list: > ((wlp3s0 [65152 0 0 0 38609 2370 19874 38730 0] > [65152 0 0 0 65535 65535 65535 65535 0] > [65535 65535 65535 65535 0 0 0 0 0]) > (wlp3s0 [10754 32900 8418 50048 62480 33512 14881 61151 0] > [10754 32900 8418 50048 65535 65535 65535 65535 0] > [65535 65535 65535 65535 0 0 0 0 0]) > (lo [0 0 0 0 0 0 0 1 0] [0 0 0 0 0 0 0 1 0] > [65535 65535 65535 65535 65535 65535 65535 65535 0]) > (wlp3s0 [192 168 0 144 0] [192 168 0 255 0] [255 255 255 0 0]) > (lo [127 0 0 1 0] [127 255 255 255 0] [255 0 0 0 0])) > > info: > (lo [0 0 0 0 0 0 0 1 0] [0 0 0 0 0 0 0 1 0] > [65535 65535 65535 65535 65535 65535 65535 65535 0]) > > The only difference is in 'ip': > > 1. [10752 5200 16395 3073 0 0 0 139 0] > 2. [10752 5200 16395 3073 0 0 0 113 0] What idiot wrote this code? Try this patch: diff --git a/lisp/net/nsm.el b/lisp/net/nsm.el index 3f3e713371..0ce65a35ea 100644 --- a/lisp/net/nsm.el +++ b/lisp/net/nsm.el @@ -239,7 +239,7 @@ nsm-should-check (mapc (lambda (info) (let ((local-ip (nth 1 info)) - (mask (nth 2 info))) + (mask (nth 3 info))) (when (nsm-network-same-subnet (substring local-ip 0 -1) (substring mask 0 -1)