From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Bastian Beranek Newsgroups: gmane.emacs.bugs Subject: bug#46299: 28.0.50; Value of tab-bar-show not respected in new frames. Date: Tue, 16 Feb 2021 16:31:59 +0100 Message-ID: <87tuqchvv4.fsf@gmail.com> References: <871rdv4xog.fsf@gmail.com> <55ebad56-b440-198a-653e-1660040d5eae@gmx.at> <38b988fd-2ad6-a596-23a0-1d765249f718@gmx.at> <87tuqjydku.fsf@mail.linkov.net> <871rdlr4vc.fsf@mail.linkov.net> <87ft1zsu75.fsf@mail.linkov.net> <87im6ulbzz.fsf@mail.linkov.net> <87sg5xwskc.fsf@gmail.com> <87pn11z2n6.fsf@mail.linkov.net> <878s7pdlsi.fsf@gmail.com> <87im6sffct.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10680"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46299@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 16 16:33:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lC2Ly-0002ge-Dz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Feb 2021 16:33:30 +0100 Original-Received: from localhost ([::1]:52750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC2Lx-000483-BG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Feb 2021 10:33:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC2LW-00045N-RO for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 10:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lC2LW-0001b2-9D for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 10:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lC2LW-0002Cx-7i for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 10:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastian Beranek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Feb 2021 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46299 X-GNU-PR-Package: emacs Original-Received: via spool by 46299-submit@debbugs.gnu.org id=B46299.16134895327390 (code B ref 46299); Tue, 16 Feb 2021 15:33:02 +0000 Original-Received: (at 46299) by debbugs.gnu.org; 16 Feb 2021 15:32:12 +0000 Original-Received: from localhost ([127.0.0.1]:41255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lC2Ki-0001um-64 for submit@debbugs.gnu.org; Tue, 16 Feb 2021 10:32:12 -0500 Original-Received: from mail-ej1-f47.google.com ([209.85.218.47]:35066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lC2Kg-0001pW-MN for 46299@debbugs.gnu.org; Tue, 16 Feb 2021 10:32:11 -0500 Original-Received: by mail-ej1-f47.google.com with SMTP id g5so13727615ejt.2 for <46299@debbugs.gnu.org>; Tue, 16 Feb 2021 07:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=d77x7uQwpP4SamDKCBpeocfvP7VekTm0/CpSBnIJ0qw=; b=TEOKg5SdErU1C8oUQgcZPtMu/CxvXadZq9P1rRnd8XkVdXMqCSL5r9HPDgx8cyQhpy 4gCbrw+udR/1QrSgj97TJRS4VcZ1/EYimssIYOuN37vfhwCKVA9ruV6FeyzRKkGCxR5Y NJl2kKeMPvDIZve1wN/SHgjFsnLBN0AWNlODh7Ww+GDBpFVw24QO2aIcXwcKE4xud9hY +7hBWcIkyFHlZtRLWoc4nmF+YteLprjeZzZtEcHQIR39sldoCfZTPvZBLsPho3Jsk6SH DAHi0bWP1tdbjjDnwwGTMZSapUiCIjkq0J88OI41nxTvcGnp6oUMfO07rxDog/lqXOnl qsOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=d77x7uQwpP4SamDKCBpeocfvP7VekTm0/CpSBnIJ0qw=; b=nwfGL1dFHLbcZrdHiwhaS5Yy5fWHPyoowKlAJjsrOawSJqIXQA1+U6QVsvbyGx3bR5 SzkN1Yl9jU763FnFQhqJ8TOlOdBUch6RvQFZtQq+3riBhHBB3wMfeqZC8B3vXsfUNHry 8NZL+JWZ+edAafW5wqF9HITW9lw9RZtAtA94GbNqgOs/aR5Mqm/s4t5EaDoWH/OlY3to o3i5UvoJih2Oc74loECvyTvcuE6ndm9lV7DVDO3F030SucE2X/VPMmR8a//Yb8hsroDU ugurx7OraGj9qVjlJgGUtefCdcmB+YAb2lWMTmzAFL7tHsQRpqgsiOvT4TPMTYYnzcVO mZVQ== X-Gm-Message-State: AOAM530EXj1L2gzxo+Y9gJkrXZDZzHNNhyWSiMr0UdQ/vWsT/VTAoKge OYVUY5SB2mg/FOH2CLR6Dz0Ku3EzlDhjFg== X-Google-Smtp-Source: ABdhPJxSVv55v4Pxc4oPyEpMjQBcxDIlLjEoycRpqsL3IYoJMjrd/IrNNoheSC+zIV+exeENMyGSmg== X-Received: by 2002:a17:906:82da:: with SMTP id a26mr2754271ejy.447.1613489523941; Tue, 16 Feb 2021 07:32:03 -0800 (PST) Original-Received: from bastian-desktop.gmail.com (b2b-130-180-23-226.unitymedia.biz. [130.180.23.226]) by smtp.gmail.com with ESMTPSA id qk14sm14045170ejb.13.2021.02.16.07.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Feb 2021 07:32:02 -0800 (PST) In-Reply-To: <87im6sffct.fsf@gmail.com> (Bastian Beranek's message of "Tue, 16 Feb 2021 11:59:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200126 Archived-At: --=-=-= Content-Type: text/plain Bastian Beranek writes: > Is this acceptable? > > Proposed patch is attached. > I made a mistake in that patch: In (frame-parameter ... ) the first argument should have been "frame" not "nil". Please find a fixed version attached. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-lisp-tab-bar.el-Fix-behavior-of-toggle-frame-tab-bar.patch >From d4d40915ad6537fdd11555dfed2273303c564fb9 Mon Sep 17 00:00:00 2001 From: Bastian Beranek Date: Tue, 16 Feb 2021 11:35:35 +0100 Subject: [PATCH] * lisp/tab-bar.el: Fix behavior of toggle-frame-tab-bar (bug #46299) (toggle-frame-tab-bar): Add frame parameter to protect tab bar state. (tab-bar--update-tab-bar-lines): Check parameter. --- lisp/tab-bar.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 4e47ae2c10..f0210e1a42 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -161,7 +161,8 @@ tab-bar--update-tab-bar-lines (t frames)))) ;; Loop over all frames and update default-frame-alist (dolist (frame frame-lst) - (set-frame-parameter frame 'tab-bar-lines (tab-bar--tab-bar-lines-for-frame frame)))) + (unless (frame-parameter frame 'tab-bar-lines-keep-state) + (set-frame-parameter frame 'tab-bar-lines (tab-bar--tab-bar-lines-for-frame frame))))) (when (eq frames t) (setq default-frame-alist (cons (cons 'tab-bar-lines (if (and tab-bar-mode (eq tab-bar-show t)) 1 0)) @@ -233,7 +234,9 @@ toggle-frame-tab-bar (add-hook 'after-make-frame-functions 'toggle-frame-tab-bar)" (interactive) (set-frame-parameter frame 'tab-bar-lines - (if (> (frame-parameter frame 'tab-bar-lines) 0) 0 1))) + (if (> (frame-parameter frame 'tab-bar-lines) 0) 0 1)) + (set-frame-parameter frame 'tab-bar-lines-keep-state + (not (frame-parameter frame 'tab-bar-lines-keep-state)))) (defvar tab-bar-map (make-sparse-keymap) "Keymap for the tab bar. -- 2.30.1 --=-=-=--