From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Wed, 14 Apr 2021 21:12:55 +0200 Message-ID: <87tuo8of2g.fsf_-_@gmail.com> References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> <87eefh9176.fsf@mail.linkov.net> <5c7b677f-0f4a-bbef-8c1f-42cd024c7314@yandex.ru> <87czuzxysf.fsf@mail.linkov.net> <874kg9mj7f.fsf@gmail.com> <87h7k8n3uy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16319"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov , Ramesh Nedunchezian , 47566@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 14 21:14:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWkxs-000497-2B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 21:14:16 +0200 Original-Received: from localhost ([::1]:56562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWkxq-0008U9-VZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Apr 2021 15:14:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWkxe-0008Tp-Mv for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 15:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52430) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWkxe-0000N5-EJ for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWkxe-0002IR-7T for bug-gnu-emacs@gnu.org; Wed, 14 Apr 2021 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Apr 2021 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-submit@debbugs.gnu.org id=B47566.16184275878755 (code B ref 47566); Wed, 14 Apr 2021 19:14:02 +0000 Original-Received: (at 47566) by debbugs.gnu.org; 14 Apr 2021 19:13:07 +0000 Original-Received: from localhost ([127.0.0.1]:35743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWkwk-0002H9-MO for submit@debbugs.gnu.org; Wed, 14 Apr 2021 15:13:06 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:40724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWkwg-0002Gd-JC for 47566@debbugs.gnu.org; Wed, 14 Apr 2021 15:13:04 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id 12so20927381wrz.7 for <47566@debbugs.gnu.org>; Wed, 14 Apr 2021 12:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WdysyFkFRI7lrdj3AWCHY6SUTPL4G0XAGBwDkCMFih4=; b=tCe1qgBl1tCRXdeMWLqddlEiRDAMc5lX9C4s7B3va07GVPA9xUtcU/Ahvo5ww+DbqW T2i54HA6gaIJo/+uzmf4S4GFWyqqFYDhvJCBhSPMDHNQQMluPrCyUxQH4LhqfMYgl5M9 I/T5OH1ab2IjW0FuIxUj/gKQNMZyMGoKTmQaRxztdwgs3hXxsLe+G9eWT3JdlwtVeysJ PvMvzDiVkGEUYUxzqsZId6xTyhIwqQniUnxOwsYvAaZefbZxjdBXE6pEMsGs6tbBdGia gTBjxFEYfc6h/nJAQutddVmekB3cDBH425PwTLX05cEKeN8eAvymalbprQ04SE4TZyy7 3uYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WdysyFkFRI7lrdj3AWCHY6SUTPL4G0XAGBwDkCMFih4=; b=qhOFqgrkGxbxv+RWCXMjVkT9Dueoj/u3vzgJDnbqsdqZds1czRoAkymg7YJbfr9RsR CJSWupdXiAy9q/UP8waCRD/TwRSJcwVpam7nALZiu1Jv4VWTchpAq4UhGEh0dSmejrFm DmbKq4riZH1kM2KjPUePXrl6CQ8w9ByMQvrw8jD5g8F9SeDmLcKbpgc4M7j3HQfObVz0 KBpGzbksVMs7PgV9JweiV2pKcbYMzfz+2FGO3gHJySs0k0mk1xo5X6sJqdqCgbVEQYos 97954zDCnOIEP3W7dDstILoM59Y2J4UVc67rkCelkv0JUkHGXC2lYzcNpbhUXbpBQTp4 yh5Q== X-Gm-Message-State: AOAM533RW/iHAUWCfGG645KztZ3Kw7iRuZ8IuGwrqYRccslYl8DPRtIK 0172gZlaxsVepAdrQSpnONU= X-Google-Smtp-Source: ABdhPJz7h8CSeWTyRVvRRp6E4zLE44XTQQ2HM3vDQ/a9ADDbAmCXeIe4o7fdWkiBzjyj7VxEoNKaeQ== X-Received: by 2002:adf:d1ed:: with SMTP id g13mr29685049wrd.86.1618427576869; Wed, 14 Apr 2021 12:12:56 -0700 (PDT) Original-Received: from my-little-tumbleweed ([2a01:e0a:20e:d340:922b:34ff:fe95:9aed]) by smtp.gmail.com with ESMTPSA id f12sm291005wrr.61.2021.04.14.12.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 12:12:56 -0700 (PDT) In-Reply-To: <87h7k8n3uy.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Apr 2021 21:10:12 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204028 Archived-At: Juri Linkov writes: >> An entry in mode-line-modes, =C3=A0 la compilation-in-progress, would be >> lovely IMO. > > compilation-in-progress is a good example of an unobtrusive indicator > in the mode line. Now added to repeat-mode. Thanks! Was this bit intentional? > ;;;###autoload > (put 'mode-line-defining-kbd-macro 'risky-local-variable t) Also, AFAICT the indication (whether in the mode-line or in the echo area) only shows up once I start repeating a key (e.g. after C-x o o), not when I first hit a repeatable key (e.g. after C-x o). Is this intended? I figure it would make sense to display the indication before the user starts repeating, since the indication can serve as a warning that repetition might occur. At any rate, thanks a lot for working on this. (And thanks to all for the addition to diff-hl!) > PS: like your message-subject-re-regexp turned the subject into > "Re: peat lambda" on emacs-devel, it removed the bug number > from the subject here :) =F0=9F=A4=A6 Thanks for the heads-up. IIUC message-subject-re-regexp is us= ed both by Gnus summary buffers to "canonicalize" subjects in order to only show them for thread roots, *and* by message-mode to strip cruft before adding "Re:" to a reply. I'll need to figure a way to decorrelate those two uses=E2=80=A6 (This is completely off-topic of course; I'm just thinking out loud)