unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: Olivier Certner <ocert.dev@free.fr>
Cc: emacs-erc@gnu.org, 46775@debbugs.gnu.org
Subject: bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes
Date: Wed, 07 Jul 2021 05:30:41 -0700	[thread overview]
Message-ID: <87tul671ce.fsf__23868.2004668348$1625661079$gmane$org@neverwas.me> (raw)
In-Reply-To: <2016416.4WAli8B44Z@ravel> (Olivier Certner's message of "Tue, 06 Jul 2021 18:34:48 +0200")

Olivier Certner <ocert.dev@free.fr> writes:

> The trick is that `erc-track-minor-mode' may be enabled or disabled 
> independently of the whole module. In particular, it may not be activated at 
> all if the (global) keybindings it wants to install, which don't abide by the 
> rules for minor modes maps, are already bound at the time of module's 
> activation.

Right, thanks for patiently explaining an RTFM-worthy question. So like
the doc string says: "for the sole purpose of providing the C-c C-SPC
and C-c C-@ keybindings" (basically for toggling during sessions). I
guess I was dazed into a stupor by encountering two global minor modes
for the same module with only the word "-minor" to distinguish them.

Anyway, it's obviously decades too late to reconsider modules doubling
as minor modes. But perhaps it's still worth reexamining
`erc-update-modules' at some point. As a quick aside:

Currently, we rely on a module's options for conveying per-connection
specifics, when supported. Some options, like `erc-enable-logging', are
buffer local but require extra attention to exploit on a per-connection
basis. And while the macro `erc-define-module' does have a `local-p'
param, I don't think it's actually being used anywhere. This is probably
in part due to `erc-update-modules' only ever enabling (and never
disabling) modules and also running just a hair too early, i.e., right
before a new ERC buffer is made current.

Perhaps a discussion dedicated to this topic may be beneficial at some
point.

> `erc-user-is-active' seems in fact to be used for more than one purpose. In 
> particular, it also triggers an update of channels in the mode line. What's 
> exactly the problem with hooking on 001?

The 001 hook only runs in server buffers. And when it does,
`erc-server-connected' is always nil.

> There is a lot of room for improvement in this module. In particular in 
> determining how some user is "active" (none of the current possibilities 
> really suits my needs).

Then hopefully we can (eventually) make it smarter. I get the feeling
this module, when fully realized, might provide an experience
that's actually superior to that offered by dedicated clients.





      parent reply	other threads:[~2021-07-07 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 17:14 bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes Olivier Certner
2021-02-25 17:24 ` Olivier Certner
2021-02-26  8:51   ` Lars Ingebrigtsen
2021-02-26  9:03     ` Olivier Certner
2021-06-09 13:07 ` J.P.
2021-07-06 14:23 ` bug#46775: Updated patches Olivier Certner
2021-09-12  5:25   ` bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes Amin Bandali
     [not found] ` <877dj3xk3e.fsf@neverwas.me>
2021-07-06 16:34   ` Olivier Certner
     [not found]   ` <2016416.4WAli8B44Z@ravel>
2021-07-07 12:30     ` J.P. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87tul671ce.fsf__23868.2004668348$1625661079$gmane$org@neverwas.me' \
    --to=jp@neverwas.me \
    --cc=46775@debbugs.gnu.org \
    --cc=emacs-erc@gnu.org \
    --cc=ocert.dev@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).