From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Fri, 06 Aug 2021 11:20:29 +0300 Organization: LINKOV.NET Message-ID: <87tuk356ia.fsf@mail.linkov.net> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> <877dh18lj3.fsf@mail.linkov.net> <83y29gjvjh.fsf@gnu.org> <8735rn8jz6.fsf@mail.linkov.net> <83sfznhywm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 06 10:28:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBvD9-0005Yd-Cc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 10:28:11 +0200 Original-Received: from localhost ([::1]:53386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBvD7-0007tv-Sd for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Aug 2021 04:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBvD0-0007qQ-9U for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 04:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBvD0-0005UP-2a for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 04:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBvCz-0001EC-R9 for bug-gnu-emacs@gnu.org; Fri, 06 Aug 2021 04:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Aug 2021 08:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.16282384524660 (code B ref 41343); Fri, 06 Aug 2021 08:28:01 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 6 Aug 2021 08:27:32 +0000 Original-Received: from localhost ([127.0.0.1]:49029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBvCV-0001D5-VU for submit@debbugs.gnu.org; Fri, 06 Aug 2021 04:27:32 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:58623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBvCU-0001Cq-C5 for 41343@debbugs.gnu.org; Fri, 06 Aug 2021 04:27:30 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8D6E8240008; Fri, 6 Aug 2021 08:27:21 +0000 (UTC) In-Reply-To: <83sfznhywm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 06 Aug 2021 09:26:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211300 Archived-At: >> It's too late to change how keys are implemented for tab-bar. >> The tab-bar keymap contains such keys as 'tab-1' and 'C-tab-2', >> and clicking mouse-1 on tabs emits such events. It doesn't emit >> 'mouse-1' and 'mouse-2'. > > How do we translate mouse clicks into the likes of C-tab-2? When mouse-1 is clicked on the close button, then the Control modifier 'C-' is added to the menu-item symbol tab-2 emitted as an event. > And what prevents us from emitting something like tab-close-2 when > mouse-2 is clicked? Then mouse-2 is still hard-coded and tab-close-2 is not much different from the previous patch that emits C-tab-2. Or in "tab-close-2" what does "2" mean: the button number 2 (mouse-2), or the tab number 2 (tab-2)? Should they then cover all combinations? tab-1-mouse-1, tab-1-mouse-2, tab-2-mouse-1, tab-2-mouse-2, ... >> It should be possible to implement normal key bindings mouse-1/mouse-2, >> but such change will not be backward-compatible. > > In what way will it be incompatible? Currently tab-bar-make-keymap returns a keymap with menu-items. This is like menu-bar is implemented. The menu-bar displays menu-items, and clicking on them emits events with their symbols. The tool-bar is implemented the same way: it displays menu-items, and clicking emits their symbols. The tab-bar is exactly the same: displays menu-items on the tab-bar, and clicking mouse-1 emits events with tab names, e.g. tab-2. Users already are using such add-advice that expect tab-bar-make-keymap returning a keymap with menu-items.