From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50042: 26.3; Post-command hooks slow with M-x commands Date: Sat, 14 Aug 2021 18:36:21 +0200 Message-ID: <87tujsq8ze.fsf@gnus.org> References: <87lf55edhd.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50042@debbugs.gnu.org, Stefan Monnier To: Simon Katz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 14 18:37:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEweo-0004y1-SM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Aug 2021 18:37:14 +0200 Original-Received: from localhost ([::1]:35036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEwem-0001jZ-Mg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Aug 2021 12:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEwec-0001jK-Ma for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 12:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEwec-0004gA-FU for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 12:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEwec-0006Bb-As for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Aug 2021 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50042 X-GNU-PR-Package: emacs Original-Received: via spool by 50042-submit@debbugs.gnu.org id=B50042.162895900623753 (code B ref 50042); Sat, 14 Aug 2021 16:37:02 +0000 Original-Received: (at 50042) by debbugs.gnu.org; 14 Aug 2021 16:36:46 +0000 Original-Received: from localhost ([127.0.0.1]:45321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEweH-0006Ax-K5 for submit@debbugs.gnu.org; Sat, 14 Aug 2021 12:36:45 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEweB-0006Ab-Le for 50042@debbugs.gnu.org; Sat, 14 Aug 2021 12:36:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VGy67w8oht9X0fp7wg0veD/nnUPyNYxCiyOcQKuxMCU=; b=G96ZO+6NMdCeKM/3/c+vhG5+5v w/HWvIXZyWUE/24WZeE1wC5CdU61XahqqS3GKmXOChhGRihY1CWFbAe4B8nTELk+gKgrr3zEcJywd eTqNQ1CTbcKiamTCyMf4tHtUAhlyjWXranoIULhxDR6FowQojOw7+V2/anE9FuxuktX0=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEwdz-0003GV-K4; Sat, 14 Aug 2021 18:36:28 +0200 In-Reply-To: <87lf55edhd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 13 Aug 2021 14:27:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211848 Archived-At: Lars Ingebrigtsen writes: > Simpler repro: > > (add-hook 'post-command-hook > (lambda () > (let ((inhibit-message t)) > (message "foo: %s" this-command)))) > (display-buffer "*Messages*") > > M-x previous-line [...] > `execute-extended-command' ends with > > (when binding > (with-temp-message > (format-message "You can run the command `%s' with %s" > function > (if (stringp binding) > (concat "M-x " binding " RET") > (key-description binding))) > (sit-for (if (numberp suggest-key-bindings) > suggest-key-bindings > 2)))))))) > > So presumably `post-command-hook' isn't run after that timeout has > completed. [...] > Could we yank this out of the flow and run it from a timer (fired > immediately) instead? Stefan, I forgot to put you on the CCs here -- I wondered whether you had any ideas here. I think lifting this out of `execute-extended-command' should be possible -- either by doing something a la (run-at-time 0 nil (lambda () (with-temp-message "The binding is foo" (sit-for 1)))) or making `execute-extended-command' set a variable and do the messaging from the "command loop" after running post-command-hook. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no