From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Sun, 15 Aug 2021 13:56:01 +0200 Message-ID: <87tujqoram.fsf@gnus.org> References: <87pmufb3u0.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18958"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50067@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 15 13:57:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFElI-0004lp-Pg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Aug 2021 13:57:08 +0200 Original-Received: from localhost ([::1]:41752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFElH-0004aW-H8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Aug 2021 07:57:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFElC-0004aJ-3w for bug-gnu-emacs@gnu.org; Sun, 15 Aug 2021 07:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFElB-0001lR-TZ for bug-gnu-emacs@gnu.org; Sun, 15 Aug 2021 07:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mFElB-0008Up-Pv for bug-gnu-emacs@gnu.org; Sun, 15 Aug 2021 07:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Aug 2021 11:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162902858532605 (code B ref 50067); Sun, 15 Aug 2021 11:57:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 15 Aug 2021 11:56:25 +0000 Original-Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFEkW-0008Ti-Fh for submit@debbugs.gnu.org; Sun, 15 Aug 2021 07:56:24 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFEkQ-0008TM-4e for 50067@debbugs.gnu.org; Sun, 15 Aug 2021 07:56:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U8hRI/6idegOzNlE9zzikT6PllUvTJBax/ksutgRmj4=; b=hj9j2dlwVqrJEPwefucX86U90L JAe8pogu0MvOcxedr4TUSnEky8mxqcVe0jO1RNdxCrYW/YuMTLwnfCaNc7a29rQq8bLDIwMuF1RMi rPQ1LCVLXMdYDgDfw9cKtIiLT2f/HaDF/MbkCiZdSk+POwMBZxcSfJw9Y427RJXWF9Pc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFEkF-0008HY-B9; Sun, 15 Aug 2021 13:56:07 +0200 In-Reply-To: <87pmufb3u0.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 15 Aug 2021 11:48:55 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211888 Archived-At: Juri Linkov writes: > The branch 'feature/context-menu' is ready for merging to master. > > It was created after the discussion in > https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00300.html > as a proof-of-concept. > > And after testing with different modes, it proved to be flexible enough > to support various needs. > > After merging it could be improved further with more development in master. I haven't tested the branch, but reading the diff, it looks like an excellent feature to me. Looking at the implementation of the stuff in various modes, I'm wondering whether the interface should perhaps be tweaked a bit: +(defun eww-context-menu (menu) [...] + (when (or (mouse-posn-property (event-start last-input-event) 'shr-url) + (mouse-posn-property (event-start last-input-event) 'image-url)) + (define-key menu [shr-mouse-browse-url-new-window] Perhaps the signature of the context menu functions should be: +(defun eww-context-menu (menu event) ? I'm also wondering whether we should add a `context-menu' text property. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no