From: Augusto Stoffel <arstoffel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50560@debbugs.gnu.org
Subject: bug#50560: 28.0.50; 'insert-file-contents-literally' on multibyte buffers
Date: Mon, 13 Sep 2021 14:44:24 +0200 [thread overview]
Message-ID: <87tuiomyqf.fsf@gmail.com> (raw)
In-Reply-To: <83pmtcelr3.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 13 Sep 2021 14:52:00 +0300")
On Mon, 13 Sep 2021 at 14:52, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Mon, 13 Sep 2021 08:58:06 +0200
>>
>> I thought 'insert-file-contents-literally' literally just inserted the
>> file contents, as bytes, but I noticed that in the following code
>>
>> (create-image
>> (with-temp-buffer
>> (set-buffer-multibyte nil)
>> (insert-file-contents-literally "picure.jpg")
>> (buffer-substring-no-properties (point-min) (point-max)))
>> nil t)
>>
>> the call to 'set-buffer-multibyte' is really essential.
>
> It is only essential for some very specific uses of the resulting
> buffer, but definitely not for all.
That's a good point. Maybe the issue is actually with 'create-image',
which seems to only work correctly when the data is passed as a unibyte
string, but gives no warning if you pass a multibyte one.
next prev parent reply other threads:[~2021-09-13 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 6:58 bug#50560: 28.0.50; 'insert-file-contents-literally' on multibyte buffers Augusto Stoffel
2021-09-13 7:10 ` Lars Ingebrigtsen
2021-09-13 7:16 ` Lars Ingebrigtsen
2021-09-13 8:13 ` Augusto Stoffel
2021-09-13 8:19 ` Lars Ingebrigtsen
2021-09-13 8:42 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 12:05 ` Eli Zaretskii
2021-09-13 13:18 ` Lars Ingebrigtsen
2021-09-13 21:37 ` Augusto Stoffel
2021-09-13 11:52 ` Eli Zaretskii
2021-09-13 12:44 ` Augusto Stoffel [this message]
2021-09-13 13:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuiomyqf.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=50560@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).