From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#46777: 28.0.50; ERC: NickServ identification: Prompt for password after other sources, overall simplifications Date: Thu, 16 Sep 2021 19:16:54 -0700 Message-ID: <87tuikymi1.fsf__40175.8925336011$1631845100$gmane$org@neverwas.me> References: <5495728.XOh7uYVVfo@ravel> <4764688.dQ8sKJKaaQ@ravel> <87sg01jzgk.fsf_-_@neverwas.me> <87ee9r4io8.fsf@neverwas.me> <87v931cck5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20828"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Olivier Certner , emacs-erc@gnu.org, 46777@debbugs.gnu.org, Lars Ingebrigtsen To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 17 04:18:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mR3S5-0005Cz-Ec for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Sep 2021 04:18:09 +0200 Original-Received: from localhost ([::1]:38024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR3S4-0000vk-8U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 22:18:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR3Ry-0000vY-MC for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 22:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR3Ry-0001Lf-Ee for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 22:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR3Ry-0000cB-8u for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 22:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Sep 2021 02:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46777-submit@debbugs.gnu.org id=B46777.16318450342303 (code B ref 46777); Fri, 17 Sep 2021 02:18:02 +0000 Original-Received: (at 46777) by debbugs.gnu.org; 17 Sep 2021 02:17:14 +0000 Original-Received: from localhost ([127.0.0.1]:58061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR3RC-0000b5-9O for submit@debbugs.gnu.org; Thu, 16 Sep 2021 22:17:14 -0400 Original-Received: from mail-108-mta233.mxroute.com ([136.175.108.233]:36391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR3R8-0000aq-ND for 46777@debbugs.gnu.org; Thu, 16 Sep 2021 22:17:13 -0400 Original-Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta233.mxroute.com (ZoneMTA) with ESMTPSA id 17bf18af8d900074ba.002 for <46777@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 17 Sep 2021 02:17:01 +0000 X-Zone-Loop: 70995ecc494ee884e5d041cde985d284a240a3c0e306 X-Originating-IP: [149.28.56.236] In-Reply-To: <87v931cck5.fsf@gnu.org> (Amin Bandali's message of "Thu, 16 Sep 2021 01:30:18 -0400") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214521 Archived-At: Amin Bandali writes: > 1. change the function's arguments in a backwards-compatible way > (i.e. by adding new &optional args as needed), and ignore the > arg we don't need anymore (the password in this case, and > make sure we don't accidentally expose it instead of a nick); I guess ignoring the password arg means some folks currently using this entry point in lisp code may have to call `erc-nickserv-send-identify' directly instead, depending on their needs. Works for me, but if that's the plan, I don't think the version I sent fits the bill entirely. > From a quick look at J.P.'s revised version of Olivier's patch, it > looks quite favourable to me Um, that was mostly me trying out my bandali impersonation (blasphemous, I know).