From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 19 Oct 2021 20:21:42 +0200 Message-ID: <87tuhcc1u1.fsf@gnus.org> References: <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24613"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 20:22:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mctko-00064d-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 20:22:26 +0200 Original-Received: from localhost ([::1]:35068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mctkm-0003fc-VL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 14:22:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mctkQ-0003dj-EX for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 14:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mctkQ-0006UC-4p for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mctkP-0002Ns-Lg for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 14:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.16346677179152 (code B ref 50752); Tue, 19 Oct 2021 18:22:01 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 19 Oct 2021 18:21:57 +0000 Original-Received: from localhost ([127.0.0.1]:51966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mctkK-0002NY-TM for submit@debbugs.gnu.org; Tue, 19 Oct 2021 14:21:57 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mctkJ-0002NJ-Ox for 50752@debbugs.gnu.org; Tue, 19 Oct 2021 14:21:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Waxz3ICDlaUCy7RrZi7HEfnk1CPJzBjFn2kiC1V/0Ps=; b=ZwRPWkH2eKHxeMMrQ2bIP1nWdy +8my8GyYS0ddoryTrK+yIIg7w2192gavTP94t5Hafn0daFwmmEA9mh/hFeRbdgMzavnAs8VqRNplP 2CKW36rk8QsLnsBTgigzqul6ovl9O5W8m2134vUMQm8uef7i7LYUIGhOSdfWAL5QvvKI=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mctk9-0008Ka-4f; Tue, 19 Oct 2021 20:21:47 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAMFBMVEX+/v7p6On56Oyt rK3R0dH42OD7yNXLO0PEJy7pjZnxqbX6t8bWWmO6Cw7ge4X////sHGcyAAAAAWJLR0QPGLoA2QAA AAd0SU1FB+UKExIMCtGDEU0AAAD2SURBVDjLY2DACRgVMMWYBICEsAOmBIsJkHDBZgxIkAnMEBRy FBQUEQQCRUeYIMgeFxdHIBJxARHIRosICSIBhqEBmBRwSLAm4ZBQr+jEqj5g+uqzh7BI8FU+Wx3R gM3q1ZkztxdgM4vzTPbcCdh0ZN5cWaOAVeLWmh5sEmorqrfNnYRFJnrHsd1rS7HoSJuxetbaMkwd aqsq0069PY0ZKprH28+cvDF7E4bEulk5NcdPLUvFMEuJiW3Vyp0BSti8zrQSq/CwAUxCOCSA2UoA q4SgIq7MJKiogF1CBFUD1nwuwoC9ZGAElQyMWJzChN15UNNwuAQA4Cc4V6cmE14AAAAldEVYdGRh dGU6Y3JlYXRlADIwMjEtMTAtMTlUMTg6MTI6MTArMDA6MDDq08GRAAAAJXRFWHRkYXRlOm1vZGlm eQAyMDIxLTEwLTE5VDE4OjEyOjEwKzAwOjAwm455LQAAAABJRU5ErkJggg== X-Now-Playing: John Zorn's _The Bagatelles (3): Trigger_: "bagatelle # 17" In-Reply-To: <83wnm8c3v3.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Oct 2021 20:37:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217597 Archived-At: Eli Zaretskii writes: >> The following patch seems to do the trick, and should be conservative >> enough for emacs-28, I think. > > I wouldn't start such experiments on the release branch. It's not an > urgent problem. Yeah, it's pretty obscure. > uniprop_table is somewhat expensive, and is definitely an overkill for > converting pure ASCII characters. Why not just set/reset the 0x20 > bit? I thought it made sense to be conservative here and do it "properly", instead of open-coding an A-Za-z upcase/downcase ourselves. And doesn't uniprop_table just return the table from char-code-property-alist here? So it's an assq from a short list. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no