From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 52888@debbugs.gnu.org, Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#52888: 29.0.50; font_{delete_unmatched,score} do not handle nil FONT_WEIGHT_INDEX
Date: Wed, 05 Jan 2022 14:55:02 +0100 [thread overview]
Message-ID: <87tuei8eyx.fsf@gmail.com> (raw)
In-Reply-To: <83tuei9x3v.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jan 2022 14:37:56 +0200")
>>>>> On Wed, 05 Jan 2022 14:37:56 +0200, Eli Zaretskii <eliz@gnu.org> said:
Eli> I'm far from being an expert on Fontconfig programming, but the above
Eli> use of 'range' looks strange: it's a pointer that starts pointing to
Eli> some random (potentially invalid) address, and you pass its address to
Eli> FcPatternGetRange, which presumably assigns to it a valid point. But
Eli> doesn't that valid pointer need to be released somehow after we use
Eli> it? Or does it point to static area(s)? I cannot find anything in
Eli> the Fontconfig documentation about the memory-management protocols for
Eli> FcValue objects, but maybe we should call FcValueDestroy on it after
Eli> we are done with it? Or maybe this is not needed, as this passage
Eli> from the docs says near the end:
Eli> void FcValueDestroy (FcValue v)
Eli> Frees any memory referenced by `v'. Values of type FcTypeString,
Eli> FcTypeMatrix and FcTypeCharSet reference memory, the other types
Eli> do not.
Based on an admittedly quick reading of the fontconfig code, itʼs not
our responsibility to deallocate the FcRange here; it ends up pointing
to memory previously allocated internally by fontconfig.
Robert
--
next prev parent reply other threads:[~2022-01-05 13:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 5:28 bug#52888: 29.0.50; font_{delete_unmatched,score} do not handle nil FONT_WEIGHT_INDEX Sean Whitton
2021-12-30 7:33 ` Eli Zaretskii
2021-12-30 17:13 ` Sean Whitton
2021-12-30 18:39 ` Eli Zaretskii
2022-01-01 0:30 ` Sean Whitton
2022-01-01 2:35 ` Sean Whitton
2022-01-01 7:15 ` Eli Zaretskii
2022-01-01 22:31 ` Sean Whitton
2022-01-03 2:04 ` Sean Whitton
2022-01-05 2:10 ` Sean Whitton
2022-01-05 12:37 ` Eli Zaretskii
2022-01-05 13:55 ` Robert Pluim [this message]
2022-01-05 14:08 ` Eli Zaretskii
2022-01-06 5:41 ` Sean Whitton
2022-01-06 12:29 ` Eli Zaretskii
2022-01-06 18:10 ` Sean Whitton
2022-01-12 14:56 ` Eli Zaretskii
2022-01-12 21:41 ` Sean Whitton
2022-01-13 6:52 ` Eli Zaretskii
2022-01-01 6:56 ` Eli Zaretskii
[not found] ` <87pmpbm8j2.fsf@melete.silentflame.com>
[not found] ` <83v8z2eizk.fsf@gnu.org>
[not found] ` <87pmp9wyo3.fsf@melete.silentflame.com>
[not found] ` <83r19pc8ax.fsf@gnu.org>
[not found] ` <87v8yzb1v7.fsf@melete.silentflame.com>
[not found] ` <83v8yy9ybv.fsf@gnu.org>
2022-01-06 18:20 ` bug#53058: etc/DEBUG could say more about --enable-check-lisp-object-type Sean Whitton
2022-01-06 20:11 ` Eli Zaretskii
2022-01-06 23:46 ` Sean Whitton
2022-01-07 6:58 ` Eli Zaretskii
2022-01-07 20:41 ` Sean Whitton
2022-01-08 6:55 ` Eli Zaretskii
2022-02-03 0:19 ` Sean Whitton
2022-02-03 7:28 ` Eli Zaretskii
2022-01-13 11:54 ` bug#52888: André Silva
2022-01-13 16:40 ` bug#52888: Eli Zaretskii
[not found] ` <CANfyKeBjec0z2c33Fph1=ESr-4ACH0BNKXq_wW-Vtr6sEfJ_VA@mail.gmail.com>
2022-01-13 18:13 ` bug#52888: Eli Zaretskii
[not found] ` <CANfyKeD2-sP4tO0dH0rbjbyD+rR+ahiDgBn+Pnx89EG1iKqiYg@mail.gmail.com>
2022-01-13 19:49 ` bug#52888: Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuei8eyx.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=52888@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).