From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53178: ert should use existing explainers for aliases Date: Thu, 13 Jan 2022 09:48:56 +0100 Message-ID: <87tue86mx3.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11247"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53178@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 09:50:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7voY-0002mS-Ki for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 09:50:34 +0100 Original-Received: from localhost ([::1]:45790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7voX-000186-Ic for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 03:50:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7vo2-00017k-O6 for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 03:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7vo2-0001aK-ED for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 03:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7vo2-0006Ze-5P for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 03:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53178 X-GNU-PR-Package: emacs Original-Received: via spool by 53178-submit@debbugs.gnu.org id=B53178.164206375425177 (code B ref 53178); Thu, 13 Jan 2022 08:50:02 +0000 Original-Received: (at 53178) by debbugs.gnu.org; 13 Jan 2022 08:49:14 +0000 Original-Received: from localhost ([127.0.0.1]:60089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7vnG-0006Y0-HL for submit@debbugs.gnu.org; Thu, 13 Jan 2022 03:49:14 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:51746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7vnC-0006Xd-Lv for 53178@debbugs.gnu.org; Thu, 13 Jan 2022 03:49:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SBNMmYgVvvE6xbxb+ZGZrUoTfYo88JUvsDDBrtFu/TM=; b=m6kjfxOoyB0tF24OLjglqvzuaU yewjxTqyry8qReUAT2hvH4p8/0aZv9FSWxUIkPv/5mSsgnRf8/gPCabNqPp74Igkhsl0NhBpkjlJA vzbgGDAqv7OiWgmw0ieryTtEJL4yGM0jcUAhaNmwchDxCQGWPVLOQfGJwwp1Otdb7BxI=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7vn3-0000bf-8X; Thu, 13 Jan 2022 09:49:04 +0100 X-Now-Playing: Alan Vega's _Alan Vega_: "Bye Bye Bayou" In-Reply-To: (Stefan Kangas's message of "Mon, 10 Jan 2022 23:17:40 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224075 Archived-At: Stefan Kangas writes: > There exists an ert explainer for `string-equal', but it is not used if > `string=' (an alias for `string-equal') is used in the test. > > This should be fixed such that an existing explainer is always used for > an alias. I started implementing this, but then I ran into the problem of possible defalias loops. I thought we had a function somewhere that would just return the defalias chain, but I can't find it anywhere. And indeed: (defalias 'a 'b) (defalias 'b 'a) And then `C-h f a RET' will infloop because (defun help-fns--analyze-function (function) [...] ((and aliased (not (subrp def))) (let ((f real-function)) (while (and (fboundp f) (symbolp (symbol-function f))) (setq f (symbol-function f))) f)) So I've now added a new function for this, fixed the infloop in help-fns, and fixed the explainer lookup in ert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no