From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#54173: 28.0.91; Training wheels for query-replace Date: Sun, 27 Feb 2022 14:46:18 +0100 Message-ID: <87tuckjuc5.fsf@gmail.com> References: <87a6edi8b3.fsf@gmail.com> <835yp0pzoh.fsf@gnu.org> <87wnhgwxo8.fsf@gmail.com> <83tuckogza.fsf@gnu.org> <87sfs4wv35.fsf@gmail.com> <83sfs4oe56.fsf@gnu.org> <87wnhgtxzv.fsf@gmail.com> <87tucksbey.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15492"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 54173@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 27 14:52:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOJy1-0003nn-Pg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Feb 2022 14:52:05 +0100 Original-Received: from localhost ([::1]:48328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOJy0-0004j7-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Feb 2022 08:52:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOJt8-0007rg-KS for bug-gnu-emacs@gnu.org; Sun, 27 Feb 2022 08:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOJt8-0000EG-5q for bug-gnu-emacs@gnu.org; Sun, 27 Feb 2022 08:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOJt7-0004bE-Ut for bug-gnu-emacs@gnu.org; Sun, 27 Feb 2022 08:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Feb 2022 13:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54173 X-GNU-PR-Package: emacs Original-Received: via spool by 54173-submit@debbugs.gnu.org id=B54173.164596959017632 (code B ref 54173); Sun, 27 Feb 2022 13:47:01 +0000 Original-Received: (at 54173) by debbugs.gnu.org; 27 Feb 2022 13:46:30 +0000 Original-Received: from localhost ([127.0.0.1]:57111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOJsc-0004aJ-0V for submit@debbugs.gnu.org; Sun, 27 Feb 2022 08:46:30 -0500 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:38807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOJsZ-0004a4-JH for 54173@debbugs.gnu.org; Sun, 27 Feb 2022 08:46:28 -0500 Original-Received: by mail-ed1-f51.google.com with SMTP id s24so13922267edr.5 for <54173@debbugs.gnu.org>; Sun, 27 Feb 2022 05:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=79hGP3Jtqtp4PEoJ0JrJ306eI2Gu//ah5irfI0wBIEg=; b=HgCLZVg1Zss5maoMVSe/lX5NSZQ9TG9kfpWbv4LNr4md/9K0n4Xf3Nsh6cOrvFxUMS q8HxJgZcXas9phJoIc16IsyZH65RX7GrhK+Jw6yLvIK7XwnJ1VI9wgbYDdDODo8mjO5Y j2rEyItVY3yMSWLvpdgrF3gr7muXNc35KH8pzPTZ51/Y/SLmiNZcccAxtgA6kWMa6J0Q jj8KE+4fsPRqGieBmC+oUPKf81c7eOpcyisCpsA1dVX14xznkW9WoqWRORq6x4vvcDV9 7JQ5zoh5ueVDk+WRj/9fbkW4aJKNW3DIlKs9Kq38pMAdTXnrSlVZO4mhq7ENy8bqocT1 CtcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=79hGP3Jtqtp4PEoJ0JrJ306eI2Gu//ah5irfI0wBIEg=; b=phGMiZUdA7gnmO9QkS7KNPQGPRc7t7W1k1imtHyy7wAqxwd8zgcwOLLlcW3zdSbUHb lkVKHl+Q83Sw34Q01suU4X3PTOV5ds7R2HOeIK0uZlxzhH9OKwk8D4DR7EOjOnmiBe7Q pXLYzFmuW15boOhwxQh4KsfKSuD+EZVVdbC0HEfOWAET/hGkGjfzR8Ne/Skl+ZKrxIDX SiCKZ1+cbK4FKntvBvWthiy/XO0QaQG/GjtmeqXXKjjmh04OLEiCHVF1RCEbN6vF2Tej ogOM7oFn5/zKUwGa7oEskeEx/hikpVgn48R6ycj8lcRZbP/RJYP+g6gLr9wx9WpC9cBJ armQ== X-Gm-Message-State: AOAM533FNtphQt9ryXP8VzqWegGCzyNJv8H3DtMunuHe6q/pOQGdmoH5 BMPJ+rMW5aahAZLBdfzcAJDzYy5lphMW+w== X-Google-Smtp-Source: ABdhPJwvKX+gDDCYl2/RTbWKbLVeArK4S0/3reEf9hGoSFcZf4BZL3kU1O5Q0EtrA0au9qwjZMFElA== X-Received: by 2002:aa7:c391:0:b0:410:83fb:abab with SMTP id k17-20020aa7c391000000b0041083fbababmr15371001edq.435.1645969581351; Sun, 27 Feb 2022 05:46:21 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::758e]) by smtp.gmail.com with ESMTPSA id d8-20020a170906304800b006cdf8a1e146sm3363441ejd.217.2022.02.27.05.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 05:46:20 -0800 (PST) In-Reply-To: <87tucksbey.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 27 Feb 2022 14:10:13 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227722 Archived-At: On Sun, 27 Feb 2022 at 14:10, Lars Ingebrigtsen wrote: > Augusto Stoffel writes: > >> - (define-key map "y" 'act) >> - (define-key map "n" 'skip) >> (define-key map "Y" 'act) >> + (define-key map "y" 'act) >> (define-key map "N" 'skip) >> - (define-key map "e" 'edit-replacement) >> + (define-key map "n" 'skip) >> (define-key map "E" 'edit-replacement) >> + (define-key map "e" 'edit-replacement) > > This seems unrelated, and just moves bindings around? This is so that 'substitute-command-keys' pick up the right key for each command, that is, the lower cased ones. >>> > (=E2=80=98y=E2=80=99/=E2=80=98n=E2=80=99, =E2=80=98.=E2=80=99 repla= ce & exit, =E2=80=98^=E2=80=99 back up, =E2=80=98?=E2=80=99 help) >>>=20 >>> I find this better than the status quo. I've attached the patch. >> >> Thanks. Let's wait a bit to let others chime in and express their >> opinions. > > I'm not sure I understood the patch. Is the proposal to append all that > to "Query replacing foo with bar"? It'll make prompts commonly be > longer than a line, and it's pretty noisy, so if that's the proposal, > I'm against it. Well, yes, that's the proposal... At least now that string is a defvar that you can set to nil if you want to save some columns :-) > The help is on `?', so I don't see the point, either. I think it's just nice to have a constant reminder of =E2=80=98.=E2=80=99 a= nd =E2=80=98^=E2=80=99. Of course I'll remember them after all this discussion, but until now I could never quite recall them when the occasion arose.