From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54481: 29.0.50; [PATCH] Rewrite hl-line Date: Tue, 22 Mar 2022 08:25:55 +0800 Message-ID: <87tubqkf3g.fsf@yahoo.com> References: <877d8o8vuk.fsf@dick> <87y213mjf7.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6125"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 54481@debbugs.gnu.org, dick To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 22 01:27:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWSND-0001PE-31 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Mar 2022 01:27:43 +0100 Original-Received: from localhost ([::1]:43588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWSNB-0004YK-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Mar 2022 20:27:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWSMZ-0004Xf-44 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 20:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWSMY-00081W-Gn for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 20:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nWSMY-0005ru-D1 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2022 20:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Mar 2022 00:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54481-submit@debbugs.gnu.org id=B54481.164790877422504 (code B ref 54481); Tue, 22 Mar 2022 00:27:02 +0000 Original-Received: (at 54481) by debbugs.gnu.org; 22 Mar 2022 00:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:38796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWSLl-0005qu-RW for submit@debbugs.gnu.org; Mon, 21 Mar 2022 20:26:14 -0400 Original-Received: from sonic303-22.consmr.mail.ne1.yahoo.com ([66.163.188.148]:44102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWSLj-0005qe-JB for 54481@debbugs.gnu.org; Mon, 21 Mar 2022 20:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647908765; bh=hukANVEOsm9SQHeH9S6QDkY022gVngl2nnnssESh9Iw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=tXuG/HbRmAubzvX25NgQV7jsp5FFI/PB/fQBzQj3pt6pH10kJY1YZ2XzcaG+xZyAUZiOt/jdjwSIVTi5lrTiN4CCACCoYrODEh3iUjEDjD06IIhqT/w5KOqLsKD7J+BoHfJX6bWDcoRg1skPK2Nsav8AIicWu/AJuSEJ2f2XR/NaLGojU6qpQOrjqnjSIwUuLmx2oUkI/cHxqU/Nahbw3sw/YflLRcFUOBWn6Ei+CaSIr0Wl4+o60xxer5nhgiQ5YXHl3knreIEgQA2OA5/ypT1h3F9PXiLA8jePn7bQkfxSnaft89GGFIWL+J8E5atfp6h/aV6ubF58UCTsKH+O7w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647908765; bh=EGYnazsC/XlnEjZANrezbcNY+AhvupF26IYuQXi1u+f=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uW07c/6O2dW29UhiLG4v3BIFoSKzvtkAKAQCdet+OUfAq5wkMrHwaI6rSED9/Tk3y6U30ENoGq+GCETnG2Xlpyz2QGvc/A5rRAEyvRI2wvi2FgX0EWMpm3ZGRlHosz5TennFYOD/jQJQueXfc+61pr9rnXHZobASl9koE2Xu1GUh++tFAxo0Ozy8D79DeFZ/FTwa0yfYnbb5dTnmjhskA+IM+kfbtoU4D4sTN+2GaRO3yaFPWH/TFWXRkB/Pysf1THmDVGrC2OcoDvM5G9TIj9Psny+E+s7oAEaRUlh4qpy53Wh7Yz0fZ1h1wvNsjUrzBNcvVTZDTwRGb9Sy05mnTA== X-YMail-OSG: 6wvqMKEVM1koe1fm2C4hcUMDa5xLT2ag5tpZXZMxNqwbsVS9V.R1..BUqKg40jP JyQz6vstCNut465IrKH2Yj0zrZDmlxba39CrjXItHahW0SlakuUnCV3sNAuF7R_q7q6hPtkochQq EWUPqkn21Ex_41.6jlApA61bxI0jXETyRJiIZ3EHGa6ysKa5rCk0444g5f.dHjd7GQRQVr8T4nlf 9nszgYfG.DNzX58TzEAkOuyU_G05hPmGfxAmvzHZhNZ14h.kx8Ghr09DY8uU4_FrUUaFRosy6Q2x G04vJp4E86WNp5ckvQTkQb8HEoGqEAhiSr0yrmGuQEAN6mHrisWEtwTURO5oHIDIPpIP4ycQaJ5x LXmIKKJoV7nXeP0M6pwbz3lrnwZig_iLlDLEUoMJmptGmU9VyN8kaJqy5hU7H.IX2fQPnQ4I6E0W Q97XnIBKSrJtm3m5EBqmybCuxdQY7QWIlMJ10PZO8z8yVk7uvo0H0yuqXCF3QyefKWxoirJV85Y1 grdENFs4gRS.O5q6oDRsBltQALUCRJIgxEFPEpqdsi_wzKgxsSkZtHvq59BGHoWs4WBHDyW8R02h 6PH6zLDB9CNlJvuJ_fRe4Gq8hCKCwYnqUhGVmnhe4VT7qbgXCT3yS4ZoO9WRS2YqMlUV3QAT1Wis HyxqgOOhXDy65Sueb.ZN8NyybQws2Zauj8.bCDaWGMiOVwzRg7KFOCYH0hzx3NatbZWDBwrUYQfa nDhziwABrE64hRT44cHgEid9kH7XWEXgL26Ao9mtxEmnskEme8Z38Xz4Dm9kezrSxyUqG6VmzwSp 0vQezrzrRkhQYNTUAM6PLDssUwRgdEugk.cMvYwmjj X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Tue, 22 Mar 2022 00:26:05 +0000 Original-Received: by kubenode508.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID dad9534d43705fbea4a04e5e8462a03b; Tue, 22 Mar 2022 00:26:00 +0000 (UTC) In-Reply-To: <87y213mjf7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 21 Mar 2022 16:09:32 +0100") X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228734 Archived-At: Lars Ingebrigtsen writes: > Makes sense to me, so I've applied the patch to Emacs 29. Now, ironically, that patch introduced at least two incompatible changes which are likely to affect users: `hl-line' is no longer a face, and `hl-line-face' (a variable) has been replaced by the face. Of course, with no updates to the version field, NEWS, or the documentation. I tried to fix it, but I might've missed something. > The one thing I was unsure about was things like this: > >> -(defun hl-line-unload-function () >> - "Unload the Hl-Line library." > > We normally don't remove functions like this, but just make them > obsolete. But in this case it seems unlikely to me that anybody would > actually ever use these functions, so I didn't alter that part. But if > anybody complains, we should take them the normal obsoletion route. With that change, unloading the hl-line feature leaves stray overlays around. Which I also fixed by restoring the old definition. This function is called by Emacs automatically when hl-line is unloaded, and is not for users to call anyway. Thanks.