From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#54473: 28.0.91; [PATCH] Eldoc: Handle invisible text when truncating strings Date: Thu, 24 Mar 2022 15:25:19 +0000 Message-ID: <87tubne5k0.fsf@gmail.com> References: <87o8203k0v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37530"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Augusto Stoffel , 54473@debbugs.gnu.org To: Andrii Kolomoiets , eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 24 16:25:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXPKu-0009a7-7t for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Mar 2022 16:25:16 +0100 Original-Received: from localhost ([::1]:36178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXPKt-00083A-2a for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Mar 2022 11:25:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXPKg-00080w-0h for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 11:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nXPKf-0001tA-MR for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 11:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nXPKf-0007As-JF for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2022 11:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2022 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54473-submit@debbugs.gnu.org id=B54473.164813546527512 (code B ref 54473); Thu, 24 Mar 2022 15:25:01 +0000 Original-Received: (at 54473) by debbugs.gnu.org; 24 Mar 2022 15:24:25 +0000 Original-Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXPK5-00079g-1g for submit@debbugs.gnu.org; Thu, 24 Mar 2022 11:24:25 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:41531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXPK4-00079S-6t for 54473@debbugs.gnu.org; Thu, 24 Mar 2022 11:24:24 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id h23so7118389wrb.8 for <54473@debbugs.gnu.org>; Thu, 24 Mar 2022 08:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HxxAxq4P4ob9eUNfVhrE5uIZ1x9Jynq4ucm7XV0f4RA=; b=pq2OYVUssXRe6OshAsK9/YjSm/8/79BmTZrrC4/yHr3lawyPRhdl8PW1ci7iOckr1w 12d2hSIvB8bzy/w3s59YBLeBHmN5posNMcFo0YM/0l3PZfQePpMKPIKaisjf+sAWDpTs mHYufoWZhB410CMTmf7XkbWAqdNWqo+9x5F5TPbLXl6NViH3O3qh+P0x+IYu4h1PYO8e /8X2uXiuK8BNHdovVuRiIixoGpq0Z0h4iI5iQQ+FzHe2991kAJarVrWC1qyZ2AoIKkRz +dUCq79v6e/s4XcJrZSj5Gi+i2Q6sQrMdJdmOHJy87B3Nil6Lo/mDonnXnyzXVggrxY6 16mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HxxAxq4P4ob9eUNfVhrE5uIZ1x9Jynq4ucm7XV0f4RA=; b=j2LkKFnLcz45O3fab7UUoTjBaVpkxGkAmuizJcaK9p4vIaUCFtQzNHuqucaOcjKFTj wSJymL9nWVlRE2ay9UxBeXUCCgCWvWUW5C5NF2hFdszNcssD+g5YRvRMQVF1imrfzsw3 UTTmIJkrquA3z2x4gjg+cm39ydKjVTQ1lbbT5jIMqZ1lB9nF5iB98aoH7ulQ8x408Oxx CbFWTf1K0r6/yW8Di/RHbXDNSTD4GXZW3xE9g6psIGhziMwDRj1VB1KS0uM2oXGI8zx5 ZcBzjNv7cY1xC6npLs+4ddJdwMKcbCLuLn0M6OL8VoC3gTPWi9ctJRihTVnkq0i/25WO uL0w== X-Gm-Message-State: AOAM531T8de6aPmyYd4NeJmBcTwIW4y2zXpxPbvU9AdjlPfm4q0CmJ5i +E+JvVlaT0J1CpflQxbCgY8i5aJv18W7zw== X-Google-Smtp-Source: ABdhPJw6aEdXCi93sdft8FTGdualyMhgDpw5p0OIm3QqB4tMJ0DNS0FYPdtVGNqUWSdwGf9HGagQ0Q== X-Received: by 2002:a5d:5987:0:b0:204:1f21:6a29 with SMTP id n7-20020a5d5987000000b002041f216a29mr5127780wri.716.1648135457952; Thu, 24 Mar 2022 08:24:17 -0700 (PDT) Original-Received: from krug (87-196-72-45.net.novis.pt. [87.196.72.45]) by smtp.gmail.com with ESMTPSA id j5-20020a05600c1c0500b0038ca4fdf7a5sm9614801wms.9.2022.03.24.08.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 08:24:17 -0700 (PDT) In-Reply-To: (Andrii Kolomoiets's message of "Sun, 20 Mar 2022 23:24:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228878 Archived-At: Andrii Kolomoiets writes: > Augusto Stoffel writes: > >> This should solve the Eglot-related problem described in this Github com= ment: >> >> https://github.com/joaotavora/eglot/issues/865#issuecomment-1065565845 > > I've tested this patch with recent Emacs master and Eglot versions, with > various values for the `eldoc-echo-area-use-multiline-p' variable > (truncate-sym-name-if-fit, 2, 1). > > All works as expected. > > Thanks Augusto! I've pushed this change to master and bumped the eldoc.el package version. Jo=C3=A3o