From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK. Date: Wed, 30 Mar 2022 21:34:25 +0800 Message-ID: <87tubfva1q.fsf@yahoo.com> References: <83bkxn8wpp.fsf@gnu.org> <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> <834k3f8tax.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Randy Taylor , 54633@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 15:58:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZYqA-0005pI-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 15:58:26 +0200 Original-Received: from localhost ([::1]:45518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZYq9-000566-8e for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 09:58:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZYUU-0003AR-EO for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZYUU-0008Jr-4p for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZYUU-0001O9-2n for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54633-submit@debbugs.gnu.org id=B54633.16486473055263 (code B ref 54633); Wed, 30 Mar 2022 13:36:02 +0000 Original-Received: (at 54633) by debbugs.gnu.org; 30 Mar 2022 13:35:05 +0000 Original-Received: from localhost ([127.0.0.1]:34818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZYTY-0001Mp-QX for submit@debbugs.gnu.org; Wed, 30 Mar 2022 09:35:05 -0400 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:46717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZYTU-0001M6-9b for 54633@debbugs.gnu.org; Wed, 30 Mar 2022 09:35:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648647294; bh=i4dymzqvtG+MfPPMsVk901CibPS5zt48COCIzcpRlfA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ff5+QZMdXNnK1xmUFs4Saex9er+M5f/hGRHYsIXof8Xt/0t9zYp6Qp94NztRSqNOCS+1HtThCcLDkgBNU2NxyjC/a3M0q40qpWVKz2LclAlOmIRj6jvKb/CUgN11ICE75ZURy0uDcdrcAhW5KJhYNqzIq5nxCompHdr5e1ShMc8owU9k6wov0hQKzcqqN+b/Po0TYsSCkl3Ay2KDA9uzgIr4kFBUZE/XYN8MiFjyQsTjCWQMCWyPhUeeU7Vi7tF241CpdoTJh7jYn0jbNWPUc089elJ4OF+Wyzzc0aZ9M9p8vf+sTk1huXBXav1Kff4JVVz1EQFcfS08jSEwVN+G8A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648647294; bh=JMOKvE8y47jlikjonreQ7H5M8+IJy24SxrKpXkDKatd=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=YkKoydqyG4AIdLcc4Mh/jRjAfdcMe6T+SoM3kGnvrWqyzQO4YXE3vhcI0kd7an09pqHmzlDh8s5Qx/vmjCk/JEtQjEk54t87n+uuX6ST/CdskLIdJYXyZgRuQ9Tc3oZpwBqDlZmoeFlTROMqQpLk5vG35NUuex9rmlSHHJlgLamlypIJHCInEmkwgzyzMwqbeL4nIejwWPjFlMz1hx7B2NRqbLRbAZyNHaghxv2fl4SpLLOMVwf3mbyZfQ/EHWexOtdbGNzSFMr9nyvpEcrg7ihSO660/f28zDuebipcLM18mfQHkw0r9fdI+UnOV4l0eBlmWvWGWCqCr1laQI7ICA== X-YMail-OSG: unMlfw0VM1k2Tlaw2b6Du0E5I92Y0TpmO3LzxvDLwWLN58L4DibKfMSzYiPCNnh TmylGw_AgQs7uipn0elLndaeABs2H100zhcGXFmU.V8clC5KsHmI.hRxGEBA_Tn.I6wuFDZ.vCoS z6yYLe.ZE07jY0JHXrh1zpr4_wBY8V9mXaHgmvpyOSZd6klHnlioCViteobTB5orcjIM0aHmzpNJ TgmVQkz0_5BUonaLXsBzyj0chRQE0Bgty9fTZV.IefBaONSKB6FnP7s8BtnJxVNLm552T9J3QZP. bHzOI482CT.esJGiTEGKDERWy3AFj0KP5NHDCbexsJEQqxpBkVPGivhcAJuPmNQaZQifedy2iC1M M3djYqJW2TMINHJtTAPkOzqoLHf6tgiEqjlR_78nwZlBy0XYTonSwF7AGCxg70z9spzPhyUoTvrV bTwya5xLYcT7NL2BtCk7yLz6CgPWiwhWgxl39rhjiCCiHxtaIoKoQM_roPrF.RWlvl958tUNM9mj OXa46Vz3PPOlhhrPhBb0xGSy3gvJZcx0TybVjryxKUhJTO_.37QcjlS3EejlqsPIcvro.iWq7QSk F31wtriQvBQUhNa3piVJFNwUhLjlpc4G3JaXJSqKMDY1StF46BTMhLKeWTOybPdyUAaVghFbQbAB BrlG5_TqUaxUY4AyusJBoBA4vllaz5B5MZ3O70uJUkyYvq3iWiirufxARw9FkTaQSP2FvZzWS7sO HAR80oQLV34aaZ.YgYrwyMeY_HzqcJbQGMzEK0ukVQR7VZoS0deX0WQVlQS4.imtC151QFau05lH SM0IZGA99QRAX.FaqrEGHwdkG7RE_fJ5m4JLcE_bhe X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Wed, 30 Mar 2022 13:34:54 +0000 Original-Received: by kubenode520.mail-prod1.omega.gq1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 0ad31502515b2ec6bd88672b17219ad1; Wed, 30 Mar 2022 13:34:48 +0000 (UTC) In-Reply-To: <834k3f8tax.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Mar 2022 16:27:02 +0300") X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229111 Archived-At: Eli Zaretskii writes: > Thanks. But your patch touched more than just the PGTK build. For > w32, for example, I see no reason to make any changes; do you? > Likewise for NS. > > Po Lu, do you agree that only PGTK needs a fix? If co, can you > suggest a fix for PGTK only? I didn't yet test this, but it should work correctly. Randy, please test. Thanks. Native image APIs are used on Haiku and NS for GIF image support, so this probably doesn't have to change. diff --git a/configure.ac b/configure.ac index 93c821eda0..99b2ecc669 100644 --- a/configure.ac +++ b/configure.ac @@ -4292,7 +4292,8 @@ AC_DEFUN fi elif test "${HAVE_X11}" = "yes" && test "${with_gif}" != "no" \ || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \ - || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk"; then + || test "${HAVE_BE_APP}" = "yes" || test "$window_system" = "pgtk" \ + && test "${with_gif}" != "no"; then AC_CHECK_HEADER(gif_lib.h, # EGifPutExtensionLast only exists from version libungif-4.1.0b1. # Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtensionLast.