From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#55414: 29.0.50; Byte compilation error for the modus-themes Date: Thu, 26 May 2022 08:55:00 +0300 Message-ID: <87tu9crg7f.fsf@protesilaos.com> References: <87lev296hl.fsf@protesilaos.com> <87zgjihlmw.fsf@gnus.org> <83zgjhiv8l.fsf@gnu.org> <83wnelirxq.fsf@gnu.org> <83tu9pinsj.fsf@gnu.org> <87tu9p8r7d.fsf@protesilaos.com> <83r14tii8m.fsf@gnu.org> <83ilpx7l8c.fsf@gnu.org> <87tu9gyki9.fsf@protesilaos.com> <83czg47bz7.fsf@gnu.org> <87v8tv7dht.fsf@protesilaos.com> <83mtf75grb.fsf@gnu.org> <87h75el2f5.fsf@protesilaos.com> <83r14h4uyi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: acm@muc.de, larsi@gnus.org, 55414@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 26 07:57:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nu6V2-0006qG-1K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 07:57:32 +0200 Original-Received: from localhost ([::1]:41534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nu6V0-0007l2-FO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 May 2022 01:57:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nu6Ta-0007ad-JC for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 01:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nu6Ta-0007fW-8U for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 01:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nu6Ta-0006dc-59 for bug-gnu-emacs@gnu.org; Thu, 26 May 2022 01:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 May 2022 05:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55414 X-GNU-PR-Package: emacs Original-Received: via spool by 55414-submit@debbugs.gnu.org id=B55414.165354451325439 (code B ref 55414); Thu, 26 May 2022 05:56:02 +0000 Original-Received: (at 55414) by debbugs.gnu.org; 26 May 2022 05:55:13 +0000 Original-Received: from localhost ([127.0.0.1]:56930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nu6Sn-0006cD-4Y for submit@debbugs.gnu.org; Thu, 26 May 2022 01:55:13 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nu6Sj-0006bt-Eh for 55414@debbugs.gnu.org; Thu, 26 May 2022 01:55:11 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 55D5240002; Thu, 26 May 2022 05:55:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1653544503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+Wvq2KtdpkGP3el9y4VnVd716d6noUwcGTenPCFO4gk=; b=HN4mf0cAk7mKt9pyDDxFBBzVRcF2/jM8KM27K9MOp85ao/jFZL83hzJi2YLbjpsQAp3Eca OzabA0rjcVtlqPwi11oD4R3xI7/5bXhnrqvbi+GzUElkK4TQK679GKXCt1PPB//sFAaeWO yDW1kMxm6czPp+ZvzOB/t/CmUTNmronV3QUdnTNocazsYc4tPQF86wsHgWrRMLVonkzSiZ p/cPSup9xc0a2oFhzHoeFGZr4/LZUW+wuR9sYpdzIUxFCscZMYoNuMmbA6Vw5nJJLO6ruj gQE5mm1bGxniudw+2YavWyvBPy8UsMz+AjnCA3riAtmMct6AAkH74lGXiGpZAg== In-Reply-To: <83r14h4uyi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233093 Archived-At: > From: Eli Zaretskii > Date: Wed, 25 May 2022 16:12:37 +0300 > >> From: Protesilaos Stavrou >> Cc: acm@muc.de, larsi@gnus.org, 55414@debbugs.gnu.org >> Date: Wed, 25 May 2022 06:24:46 +0300 >> >> The first approach was to add the following at the end of the relevant >> files: >> >> ;; Local Variables: >> ;; max-lisp-eval-depth: 3000 >> ;; max-specpdl-size: 3000 >> ;; End: >> >> Then M-x byte-compile-file with modus-operandi-theme.el: the local >> variables were ignored. Same for: >> >> (package-install-file "/preferred/path/to/modus-themes") >> >> The second approach I tried was to add those variables in a >> .dir-locals.el file which was located in the same directory as the >> modus-themes. The contents of that file looked like this: >> >> ((emacs-lisp-mode . ((max-lisp-eval-depth . 3000) >> (max-specpdl-size . 3000)))) >> >> Again, the values were ignored. > > How about advising package-install-file? You mean at the theme level? I am not sure how that would work and what its potential downsides are. > Also, how do other packages overcome similar problems? Surely, this > isn't the first or the second package that needs such measures? I am not aware of other such cases. This one is specific to the recent changes in Emacs 29 (as noted earlier in this thread). > And finally, any ideas why a package that is just a theme need such > large values of these variables? Because the theme covers about 3300 faces. Assuming other things constant, to get it to byte compile again I need to remove more than 1200 faces, including popular groups like those of Gnus and Helm. >> These methods work for other variables but not those two. Perhaps >> because they are considered "risky" as file-local? > > No, I think that's because these facilities visit the file literally. I see. Thanks! >> > If the above misses the point, please tell more how you compile the >> > package and how you tried to enlarge the values of those variables. >> >> I don't use a Makefile. The recipe I shared in the first message to >> this bug report affects installation via package.el and, by extension, >> GNU ELPA. > > If all else fails, perhaps package.el should acquire a feature whereby > these variables could be overridden during byte-compilation. I am happy with whatever is best for Emacs. Though I do not know enough about package.el to have an informed opinion on the matter. -- Protesilaos Stavrou https://protesilaos.com