unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 55940@debbugs.gnu.org
Subject: bug#55940: macOS: <ns-show-prefs> displayed as keybinding for \\[customize]
Date: Sat, 18 Jun 2022 14:06:09 +0200	[thread overview]
Message-ID: <87tu8i18i6.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmk8gwCaRu8_kCZOHDis-ztfeE4dDir6Q0L4iWQJrkTv7w@mail.gmail.com> (Stefan Kangas's message of "Sat, 18 Jun 2022 00:40:14 +0200")

Stefan Kangas <stefan@marxist.se> writes:

>> `where-is-internal' should never return these "synthetic" events (that
>> are only created to have a way to have Emacs process them in the normal
>> event loop).  So perhaps we should just mark these symbols with a
>> special property to make `where-is-internal' ignore them?
>
> Sounds good to me.

These "keys" are added in places like:

      (when (featurep 'ns)
	(setq system-key-alist
	      (list
	       ;; These are special "keys" used to pass events from C to lisp.
	       (cons  1 'ns-power-off)
	       (cons  2 'ns-open-file)
	       (cons  3 'ns-open-temp-file)
	       (cons  4 'ns-drag-file)
	       (cons  5 'ns-drag-color)
	       (cons  6 'ns-drag-text)
	       (cons  8 'ns-open-file-line)
;;;	       (cons  9 'ns-insert-working-text)
;;;	       (cons 10 'ns-delete-working-text)
	       (cons 11 'ns-spi-service-call)
	       (cons 12 'ns-new-frame)
	       (cons 13 'ns-toggle-toolbar)
	       (cons 14 'ns-show-prefs)
	       ))))

Adding a symbol property like `non-key-event' to these symbols would be
easy enough, but perhaps we should have a bit of infrastructure to make
this easier to do.  Uhm...  Just adding a little helper function here
does the trick, I think.

Now pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-06-18 12:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 12:01 bug#55940: macOS: <ns-show-prefs> displayed as keybinding for \\[customize] Stefan Kangas
2022-06-13 12:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-13 15:07   ` Stefan Kangas
2022-06-14  6:07     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14  9:02       ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14  9:46         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 10:58           ` Stefan Kangas
2022-06-14 11:20           ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-13 15:07 ` Lars Ingebrigtsen
2022-06-13 15:16   ` Stefan Kangas
2022-06-13 15:20     ` Lars Ingebrigtsen
2022-06-14 12:05       ` Lars Ingebrigtsen
2022-06-17 22:40         ` Stefan Kangas
2022-06-18 12:06           ` Lars Ingebrigtsen [this message]
2022-06-21 12:39             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu8i18i6.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=55940@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).