From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Tue, 05 Jul 2022 20:53:33 +0100 Message-ID: <87tu7vpc8y.fsf@gmail.com> References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: terra@diku.dk, 56407@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 05 21:53:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8obk-0006nW-Ls for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 21:53:16 +0200 Original-Received: from localhost ([::1]:36732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8obj-0005i7-A6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 15:53:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8obX-0005hb-7H for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 15:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8obW-0006qa-A3 for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 15:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8obW-0007BG-8w for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 15:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jul 2022 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165705074427531 (code B ref 56407); Tue, 05 Jul 2022 19:53:02 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 5 Jul 2022 19:52:24 +0000 Original-Received: from localhost ([127.0.0.1]:51764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8oau-00079z-6Y for submit@debbugs.gnu.org; Tue, 05 Jul 2022 15:52:24 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:38844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8oas-00079g-IL for 56407@debbugs.gnu.org; Tue, 05 Jul 2022 15:52:23 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id g39-20020a05600c4ca700b003a03ac7d540so10347063wmp.3 for <56407@debbugs.gnu.org>; Tue, 05 Jul 2022 12:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=AlIAF4gqJ2aAURiu8Sj23J2Iw+9lnBhB4RPh7voYbeM=; b=eHUICjwJa0Vxqzta02TxAVeMTW0tAq+sQTxIpJxw/CS8qqXlyYpZROZeS9CKHBCsmk /TyWmE0Y4JSHRStffFPLS6pCrWpau92YGXF85FBSsjyi1yjLVb06OItTuEF7fy9eIM+U 5mRMwu7G1p9Z58Irdi6z6GR6BIcKkkrSJ/dJdpQwOo9ofoxWOziwr83YO2tKnHrtFAej hai1uQ27QSjrvV2WhiWm5OMuY7VVRCLKJHVVZDLrAak+dZ4mCilhqZ17Xz+LAWJJqNcP P7sFFSCvKyUkNNkvPdYsYiRDGzcHijk9JpiZf/L0xDb6YXKku9XHwp8zU8eLtLc95CGN /IAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=AlIAF4gqJ2aAURiu8Sj23J2Iw+9lnBhB4RPh7voYbeM=; b=RVoDvYx4plM+PvrS1LTNyTNxntFg0owVuaZYMZ580f4DLNh60KPhDoqmoX7xulwJ5I m/IyTsIOoeXthK9IiVt5dGWSlUSlfHhXadriVgWCku418iw7GbjnEwpNwNj8bf6CAbkG q/kmWVUUB5FlRu3icC6GFzzIMFOsVKFFMkscr0BSwXKW3Vtte3qKRVWmEpalMz4wDPyb vTCknPbztP5asQWxj81fICCWSYdYHsN5WUbbE78Th2+Q/dEdk4/u5IZXv4aH4rDA/7WH K+C8O2YypupF2i5bGJI5WUgY00fChiwfr5jPcH9JRWSX4fxsozpNfi63p4Ko+m3q9JPU Nhow== X-Gm-Message-State: AJIora9aWwZD3XnqZkf66BbbJGrIqnpE+aSIA7hMgnsCcJZAT7SHD92V wOnC56C5KDLp6QjKyeZjw6w= X-Google-Smtp-Source: AGRyM1tR45juzrZIGwKNA5hi1Ou2WBXGrkpX9ka8N8lx6PvyhMDwr//L70GNakeqtNpApxFUzP5Mfg== X-Received: by 2002:a05:600c:4fc8:b0:3a1:987c:82d4 with SMTP id o8-20020a05600c4fc800b003a1987c82d4mr18875724wmq.26.1657050736518; Tue, 05 Jul 2022 12:52:16 -0700 (PDT) Original-Received: from krug ([87.196.73.211]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b0021d7050ace4sm3227563wru.77.2022.07.05.12.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 12:52:16 -0700 (PDT) In-Reply-To: <83v8sb73ga.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 Jul 2022 22:40:53 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236178 Archived-At: Eli Zaretskii writes: >> I confirmed this with a stack trace requested from the user and came up >> with this workaround in the user's config: >>=20 >> (add-to-list 'desktop-minor-mode-handlers >> '(eglot--managed-mode . ignore)) >>=20 >> This works, but we should come up with something better. > > But why is the above not good enough? You could also use > desktop-minor-mode-table, which is a defcustom. At first I thought it was a customization variable and that would make it user-specific overwritable etc. But I see now that evidently it is not. According to the docstring of d-m-m-handlers, eglot.el could just just contain the above invocation, indeed. But that has the downside that eglot.el must require "desktop.el" which IMO opinion too strongly couples the two packages. I think I like Lars's solution best. Jo=C3=A3o