From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 19:21:24 +0200 Message-ID: <87tu6lwcx7.fsf@gnus.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83lerxtkfu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13867"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57079@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 19:25:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLSz3-0003Rt-CR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 19:25:37 +0200 Original-Received: from localhost ([::1]:36546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLSz2-00049P-FH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 13:25:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLSvb-00014o-O7 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLSvb-0004tD-E8 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLSvb-00033T-A5 for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 13:22:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 17:22:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.166006569711659 (code B ref 57079); Tue, 09 Aug 2022 17:22:03 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 17:21:37 +0000 Original-Received: from localhost ([127.0.0.1]:44782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLSvA-00031z-NW for submit@debbugs.gnu.org; Tue, 09 Aug 2022 13:21:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:51878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLSv8-00031k-0L for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 13:21:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T59o3o+gdc+pXUWLhsSpL9dnghmX/SL9ReiXIQ62T5c=; b=l7c236EFTn0o+8v7zjOPDCmo2z UhsLe9s9xOjBYSMX5gAj79V7vwQ4LDqnOy1XFHT9kR/32kVCeCdHBwMGCj9KYvFvYZW7ls34EVcI2 tMYprNgdBfJHjQbWpU91nwfCPpOeRrGY8gqfuLfMFx0WjyuQ6v1777VOlgud8A03mhEs=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLSuz-0005tQ-9r; Tue, 09 Aug 2022 19:21:27 +0200 In-Reply-To: <83lerxtkfu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Aug 2022 20:07:17 +0300") X-Now-Playing: Hood's _Cold House_: "The River Curls Around The Town" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239177 Archived-At: Eli Zaretskii writes: > No one said that was a problem in these cases. I haven't audited the callers, but changing code that used to be non-destructive to be destructive isn't to be taken lightly. Anyway, I've now made seq-uniq faster. This used to take 27 seconds, and now takes 1.4s. (let ((list (seq-map-indexed (lambda (_ i) i) (make-list 10000 nil)))) (setq list (append list list)) ;;(benchmark-run 10 (gnus-delete-duplicates list)) (benchmark-run 10 (seq-uniq list)) )