From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Mon, 15 Aug 2022 08:39:51 +0200 Message-ID: <87tu6ec8nc.fsf@gnus.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> <83fsi5tj31.fsf@gnu.org> <87k07hwbgs.fsf@gnus.org> <838rnxti1k.fsf@gnu.org> <878rnxwayl.fsf@gnus.org> <837d3hth7r.fsf@gnu.org> <86mtcdnrad.fsf@mail.linkov.net> <878rntr49y.fsf@gnus.org> <87lertnhdc.fsf@web.de> <87pmh4jraj.fsf@gnus.org> <87wnbboprt.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 57079@debbugs.gnu.org, stefan@marxist.se, Juri Linkov To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 08:41:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNTnJ-0000Ug-8L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 08:41:49 +0200 Original-Received: from localhost ([::1]:37290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNTnG-0006Br-7a for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 02:41:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNTmZ-00069r-R5 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 02:41:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNTmZ-0001iL-GY for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 02:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNTmY-0000LI-Ch for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 02:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 06:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.16605456031183 (code B ref 57079); Mon, 15 Aug 2022 06:41:02 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 15 Aug 2022 06:40:03 +0000 Original-Received: from localhost ([127.0.0.1]:40433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNTlb-0000J0-6W for submit@debbugs.gnu.org; Mon, 15 Aug 2022 02:40:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNTlZ-0000IP-7A for 57079@debbugs.gnu.org; Mon, 15 Aug 2022 02:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IP47DMfpIJT61ax07bKBbcxKz1wxInaE9SCy7LNfbns=; b=dnAg5Kdv2oPJRa96exaug514YD 1BodLAswHgrrHWrsWADotgb30TWF7n35jdswn29NXLhcbIPejytCg+gBz2gU0V2xElhTOl4GZ5c+B nRBpJ8rqeO/tvJ52qIg9VSrdCtU/B9qYF8VfCyaXclXHGt+1P/ZfSpCJd5vto1snoPIg=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNTlQ-0004XV-9f; Mon, 15 Aug 2022 08:39:54 +0200 In-Reply-To: <87wnbboprt.fsf@web.de> (Michael Heerdegen's message of "Sat, 13 Aug 2022 22:24:38 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW6ub0TExZaWl// ///b7+IJAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YIDwYdNL6P7bMAAAHBSURBVCjPLZFBi9swFIQn Bpe174Ylp7CgkuRXJLklJ2M8QvZJNZsl9q9wDIF1T70obHNyCgrJ/so+byuQ4NPTG0kzAO3VMPPJ MY8ArqKUafgW6VBgo4yASRghqFfuPwQIm1VyYBZq5eYIh059CHDiY7BU/Bo/SDB3ZCqzHKGSXStV 7QjfyypSZFijD7V3r0lNbrd4d/q7w6QomNWQloztRM7mCbajaNfTUSuIjuK7YkGu4Zo86SvvS+7/ gAfro1I9zPnzLpfWPLI+8uZLyGUi11TcsgB1Un742IY1azBlc5sFbaDdA6cqX97aEdQOfW+WEAD7 DreFmeFFKqweMIV5xqxrJ/IPeaiZtnPVXse3nQpzGWI3XLXvoXZWD9/us/j1kcHtMt6jdojPysAV jcDh12JPDceYh8A8L8QFOH0RmE1/j75FWckmsNNSJ1v87ATQCoQbqEp+A1ykUiHRlRNw9djj2PIw wpcaNzQCxX5MoVwlVpL9PLscizerLF7cp+aAcJ/GA2L3oBiypp2n/8AjpX3KReAxpqCdXSpxoJdQ 4b19CiXRiHWN/TqdT6R5wtMezOw8kEAjiUu8Hubifhdp8i8Ngbq/aYpF5AAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMi0wOC0xNVQwNjoyOTo1MSswMDowMDyZ7KQAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjItMDgtMTVUMDY6Mjk6NTErMDA6MDBNxFQYAAAAAElFTkSuQmCC X-Now-Playing: Prince's _Dirty Mind_: "Uptown" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239732 Archived-At: Michael Heerdegen writes: >> I think we're into cl-lib.el territory then -- seq doesn't do KEY. > > It would make lots of uses much faster, call it as you like, don't think > about how it's used in CL, it makes sense to add it as functionality to > this function - that's the important part. We can find a different > interface if you prefer that, e.g. allow the test function to be > (TEST F) or something like that. My point is that the seq library doesn't do KEY, it only does TESTFN, presumably because the person who wrote it was inspired by functional languages. We have virtually all the same functions in cl-lib.el, and the inspiration there is from Common Lisp, so all those functions take KEY (and a dozen other keyword parameters). Myself, I'd prefer that virtually all the functions in seq.el take a KEY, too, but that's not what that library is. Adding KEY to just `seq-uniq' doesn't make sense from a library design standpoint.