From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Tue, 23 Aug 2022 10:53:12 +0000 Message-ID: <87tu63usdu.fsf@posteo.net> References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> <877d3049c1.fsf@gnus.org> <87sflo2s52.fsf@posteo.net> <87k0702rwd.fsf@gnus.org> <87k0702jze.fsf@posteo.net> <87o7wc15cv.fsf@gnus.org> <87a67vsgtb.fsf@posteo.net> <87r117tgw1.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3709"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57334@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 23 13:12:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQRpK-0000oG-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Aug 2022 13:12:10 +0200 Original-Received: from localhost ([::1]:53140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQRpJ-0007l9-Fx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Aug 2022 07:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQRpC-0007jA-G8 for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 07:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQRpC-0005zu-7O for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 07:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQRpB-0005Yt-Ny for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 07:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Aug 2022 11:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57334-submit@debbugs.gnu.org id=B57334.166125309021341 (code B ref 57334); Tue, 23 Aug 2022 11:12:01 +0000 Original-Received: (at 57334) by debbugs.gnu.org; 23 Aug 2022 11:11:30 +0000 Original-Received: from localhost ([127.0.0.1]:42800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQRof-0005Y9-Rr for submit@debbugs.gnu.org; Tue, 23 Aug 2022 07:11:30 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQRoc-0005Xu-TI for 57334@debbugs.gnu.org; Tue, 23 Aug 2022 07:11:27 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8AE29240027 for <57334@debbugs.gnu.org>; Tue, 23 Aug 2022 13:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661253080; bh=n4hhZiVdal1z+K7Nqk/Uj/z6FRF0b3FncwuHa+rclEY=; h=From:To:Cc:Subject:Date:Autocrypt:OpenPGP:From; b=V/nHM73fIRhxXdyEydN4dzEuvCcs16uZtRqLwtgpQh4UXmjgUh9sD9NuESXNqRR5r Uj59s6wAjT6UKZjHFcY1ZF7KMiZT8DQ7k4KPIrOI7BDaWHU7COyvDKtBUxQ9XqNNcc i2drhxAp+JDRl9CbsVru+YzuTSqq8yzhoVkq/vdFX2p7DwMRze9B+M1kWaSOyGMYuT PnwVJVmIAM1tgyRIN0rzeJTO5trDaty6U3uptrRHnNZlkWa4jpEx1dTCPxhDQ/tGbf zb0mOn38SkgsqOF6mkRMh9OUneUtMmQ9+ik3yst32OekLIFZCj00fsOKPrbUo3GIVf GBk85zgkWO3KA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MBmkb2LrCz6tnD; Tue, 23 Aug 2022 13:11:16 +0200 (CEST) In-reply-to: <87r117tgw1.fsf@gnus.org> Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQa OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240525 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Lars Ingebrigtsen writes: > Thierry Volpiatto writes: > >> The tests succeed with following patch (avoid setting dired-directory to >> nil). > > Michael noted that there's more fundamental problems in this area, Indeed there is other problems, like Michael mentionned but also Eli. I had also problems with `wdired-get-filename` which at the end use (concat dir file) instead of (expand-file-name file dir). If filename is absolute we endup with e.g. "/home/you/tmp//home/you/tmp/foo.txt" instead of "/home/you/tmp/foo.txt". Curiously this happen in emacs-28 but not in 29 (why I submitted no patch for this). > so perhaps more work is needed later, but your change makes sense > anyway, I think, so I've now pushed it to Emacs 29. Great thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmMEtc0THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk0pXC/0cXB+dXhMLAxnYsptzHP96uY930fr+ c0a01Sz+wDjBofORMVpy0TRVwsy9//GfM2GiAaz8rMRJ5iZPJUX4SJp+nTPNrmJ7 SP+AtlZX4vGRi4ljNGKSJ2q7Yrx5V/nTCUHlcM6Qv6t2bokPM9Km1dPHib2Z12L3 cZNZ7B3/JsjnsZTLQDPlekQECLIujyJ5h3lWPRxaC4AoPqiKvtLr2eRibB8wbKyY C7Va1pq00GpGb8rWlWKxSbLJFsqXCzgFS+DI7YTCmdwEQilk5mtZqXWfG1KkEYT5 Gvb49nbU5jujMljIQ/PnqRZTfS/q2axOkkyDwVv8jcLhElZAn1j5vVdkgBz+UemS w/1UBoea33ATRHaFYrPSG+7voRIdJi2iUhe0YKR/iGQ56XV1ItTBx9J7gJru+P9M NxRkrVikr+wzUsdGo8WAFL527OLFEnvd0AbT2POBtXI6N/Nj6aSovvsor22yQ6Uk vN4Dzc2U+tybQSdg6bGNjGizeECSWI6LP1A= =E7qM -----END PGP SIGNATURE----- --=-=-=--