From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Fri, 26 Aug 2022 12:05:07 +0000 Message-ID: <87tu5zky6k.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <83sflj1dbo.fsf@gnu.org> <87fshjmeje.fsf@posteo.net> <83mtbr1b6l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57400@debbugs.gnu.org, ane@iki.fi To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 14:07:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRY7Y-0000tw-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 14:07:32 +0200 Original-Received: from localhost ([::1]:36504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRY7X-0008Ee-5a for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 08:07:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRY67-0008DS-3B for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 08:06:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRY65-0006ey-UG for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 08:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRY65-0000hi-Jc for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 08:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.16615155182641 (code B ref 57400); Fri, 26 Aug 2022 12:06:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 12:05:18 +0000 Original-Received: from localhost ([127.0.0.1]:52547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRY5N-0000gV-PJ for submit@debbugs.gnu.org; Fri, 26 Aug 2022 08:05:18 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:41999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRY5M-0000gF-1w for 57400@debbugs.gnu.org; Fri, 26 Aug 2022 08:05:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 07E37240106 for <57400@debbugs.gnu.org>; Fri, 26 Aug 2022 14:05:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661515510; bh=N38R6UoP3m4mn/EtwaAZtYa5KDCKQoHK375FWtK/H7I=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=hYRtH2Q6Bw46TkyqehQy3Jae4G0YsbClteSTSMLeLwYrjS1L4beVkTWzSb04RBEmo Rrinx3uGXR+xMK/rBxfLQSafKjuhJGwZh0OCn7nHwH8ytJuG0sCf9cIwi1St9IRaWg Bw9zegWIKj5rLkwm2TV6JmUEuh8I41Sv9Z8NSOOZZtNi9h49IJnt9c5uamP8S7fwcN nrLF6Pub8AWkU5xFc/7z5sOoZCA6+5Si6TdxuvVf0UK3HdK/tGBURfN2zred+FnBBR RuiO21vcJLXx6pqbtT2LqF00ziu4r0j+KxiTThBurgtqd4i8kO0B6C091KJSyV6hqM HWjUcCDu03EHw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MDdnK17k6z6tm6; Fri, 26 Aug 2022 14:05:08 +0200 (CEST) In-Reply-To: <83mtbr1b6l.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Aug 2022 14:44:34 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240821 Archived-At: Eli Zaretskii writes: > >> From: Philip Kaludercic >> Cc: Antoine Kalmbach , 57400@debbugs.gnu.org >> Date: Fri, 26 Aug 2022 11:26:29 +0000 >> >> Eli Zaretskii writes: >> >> >> 5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the >> >> next patch, `C-c C-k` cancels the whole thing. >> > >> > Please don't hard-code message-mode. Please honor the user setting of >> > mail-user-agent instead. >> >> Is there a generic way to handle any mail-user-agent? > > For some value of "generic way to handle", yes. For example, > compose-mail does that. > >> E.g. if you want to add attachments, is there any better way that >> just doing a case distinction on known user agent implementations? > > Not sure about attachments, but we could either add another property > to mail-user-agent, like we do with composefunc property, or dispatch > on the agent itself. That sounds like a good approach. >> > Also, I'm not sure why we'd need to send each patch file separately. >> > Why not add them one by one as attachments to the same email message? >> >> This wouldn't work if we are sending patches to a mailing list that >> assumes patches are sent out by git send-email, and that the messages >> can be filtered through git am. > > "git am" handles attachments without any problems, I do it all the > time. Only if the MUA can recognise the patch and pipe it into a git am process. But if we are trying to re-create the behaviour of "git send-email" (as I think is necessary if we want the feature to be of use outside of Emacs circles, such as sending a patch to the Linux Kernel Mailing List), then we need to consider people using clients like Mutt or Aerc (https://aerc-mail.org/) that just pipe the entire message through "git am". > But I don't object to having optional behaviors here. My point is > that we should allow sending all the patches together, as that is the > preferred/usual practice in Emacs development. Of course, the idea that was proposed on emacs-devel was to have this behaviour be controlled by a (file-local) variable that could be set on a per-project basis.