From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50507: New function in Emacs GnuTLS implementation Date: Mon, 26 Sep 2022 13:03:16 +0200 Message-ID: <87tu4u8kjv.fsf@gnus.org> References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40913"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50507@debbugs.gnu.org, Eli Zaretskii To: Nikolaos Chatzikonstantinou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 26 13:05:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oclvA-000AMN-Hw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 13:05:08 +0200 Original-Received: from localhost ([::1]:41070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oclv9-0008J4-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Sep 2022 07:05:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oclu8-0008Ei-7y for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 07:04:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oclu7-0006DL-Fj for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 07:04:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oclu6-0007oF-8x for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 50507-submit@debbugs.gnu.org id=B50507.166419020929978 (code B ref 50507); Mon, 26 Sep 2022 11:04:02 +0000 Original-Received: (at 50507) by debbugs.gnu.org; 26 Sep 2022 11:03:29 +0000 Original-Received: from localhost ([127.0.0.1]:49406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocltY-0007nR-RE for submit@debbugs.gnu.org; Mon, 26 Sep 2022 07:03:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocltV-0007nD-RT for 50507@debbugs.gnu.org; Mon, 26 Sep 2022 07:03:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5GsUKF/Sq6+YkN4NxI71XRp41N0K4kH7KwpL0xnt5fk=; b=ZFiSLL6JiJLdyLMI8/+tBcbjpD W4xBZJ7yLS3a2ERzY29pxSOQXagsR35a4otmhBejrLUp1OxLXAFvDBsUJH2E57NiS3ozHp6pK46jc A+94GHy7uFjXcZEsxTY2iAhnBNaVddQV1z+kHq3QM18RCEv9oiFF/qg2HyiWhNuIzUTs=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocltN-0007G0-4h; Mon, 26 Sep 2022 13:03:19 +0200 In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Mon, 26 Sep 2022 05:56:27 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUiHy9ANEEaGDPL e0n///8Oec6aAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJGgoyLOxCOvEAAAGpSURBVDjLbZSJdcQw CEQBNwBSA1hpIIr77y0Durx5YS+vvmEAIROFsRneL1Om5u1fAyB6L7DJAGlywIVAJT2W66QXxOQA p/m/MZG3A4RV2UtqwNlYBnBhaeKKyy97oNLLBOSCe7mEh6l1m6G8Qfo2/c5orZWlAT0UZF352Vlm KpByLPbGtezKE4QEVxG6+yeI+kzDcQPKbNEwMnL19vjLw4VMHB7O0v2IO0n+qOAWe2sgEGo3C8wn lGTv+UG2Uf1LI7ekPiD4umb7EzhpgjCk8OnxLFNawP8CeQHmuVyPxxisCWrfIG1pdzYAmr3yCQzA qC4glP27sopvgDLFMyeuhrsxBnj90EgowzEcVK+I9pSI7u2A3vFBXqlBEaqdbAeIjY6B9jgfBxg8 IqNRi64eookx3kS7JYPEfI6aF7AM1iPrD7BUaoI2Qo2ErQ51Mx9jsFoZIIsfYE37FEG7dG1t+GAS cQZGrHliAHDYWQ0NzuoxW+s4axwh4+65WYZ2vA4nmoks7xqR9sA5ltijO3Kb7sdEAMRyWiYjQj5L cHfb6yspOhezRcOFfgEKDG6WHUUrNgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0yNlQxMDo1 MDo0NCswMDowMOd/rFEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMjZUMTA6NTA6NDQrMDA6 MDCWIhTtAAAAAElFTkSuQmCC X-Now-Playing: Fire Escape's _Abandon Head_: "Getaway People" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243636 Archived-At: Nikolaos Chatzikonstantinou writes: > However, I suspect that this API is not used by most > packages. Instead, these functions are called from Emacs' > make-network-process and friends in src/process.c. If I just dump new > gnutls functions in src/gnutls.c, they might not be accessible for > use, or I might duplicate functionality. I'm not sure I understand what you mean here. The point was to use gnutls_certificate_set_x509_key_file2 instead of gnutls_certificate_set_x509_key_file in gnutls.c -- so that should be an internal change in gnutls.c that nothing else should need to know about. > Before I make sensible changes to src/gnutls.c, I would need to > understand better how the functions are used in > src/process.c. However, that file is lacking function > comments. Therefore, since I'll be studying it anyhow, I suggest that > my first patch will be C documentation for those functions in > src/process.c. process.c has an abundance of comments already, but if there's further comments that would be helpful, that's welcome, of course.