From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#58406: 29.0.50; Bars refactoring? Date: Mon, 10 Oct 2022 10:37:18 +0200 Message-ID: <87tu4cyszl.fsf@elite.giraud> References: <87a6641648.fsf@elite.giraud> <87bkqkm777.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58406@debbugs.gnu.org, Manuel Giraud To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 10:40:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohoKd-0006Nm-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 10:40:15 +0200 Original-Received: from localhost ([::1]:35698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohoKc-0001Am-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 04:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohoIU-0007OT-P5 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohoIU-0003h2-Aa for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohoIU-0000kT-1L for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58406 X-GNU-PR-Package: emacs Original-Received: via spool by 58406-submit@debbugs.gnu.org id=B58406.16653910442832 (code B ref 58406); Mon, 10 Oct 2022 08:38:02 +0000 Original-Received: (at 58406) by debbugs.gnu.org; 10 Oct 2022 08:37:24 +0000 Original-Received: from localhost ([127.0.0.1]:45905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohoHs-0000jb-Hk for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:37:24 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:40026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohoHq-0000jS-Km for 58406@debbugs.gnu.org; Mon, 10 Oct 2022 04:37:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=aMqrMHlHXJjtiK9I B5ntIRaviuvK5kELCLEv8j9Bk7w=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Erx1mzOfRTXgU/bR7nn7LY3Kamkuj7g3BCuLir WbqzrZ9iDkCTfIbUJhgYKm2YuiNQhseBbSwrwbvsA2iaQ/ZCeU2fdnK7raNbe8pZ5S4HqJ efRH+U56Wj7Xy60EiI60fmQBzDWuQ/PDiXspyYNooKrsW8pTAIEUEiHrORzu40o3WvU0ZZ v0b5uZnEwwvZ9cKRdJKtgJU9NpmHaSyTsD/47/AhLhuuq1Vy9Y0ZF5gvzg8RJGkS4+J8Sp 9I6k93s2BXEWW7Wn59WnadA6JYk/PMD2Z5iqUpFfsaqxSSO9AzdznbbEa8wCwhC+65/4HJ cOzmQkSpu1np4kxZpGtvQI9w== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id d7c67829 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 10 Oct 2022 10:37:19 +0200 (CEST) In-Reply-To: <87bkqkm777.fsf@yahoo.com> (Po Lu's message of "Mon, 10 Oct 2022 16:08:44 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244994 Archived-At: Po Lu writes: > Manuel Giraud writes: > >> I'm trying to have some kind of highlight feature on the no-toolkit menu >> bar. As this feature is already present in tool/tab bar, I'd like to >> mimic those. > > What kind of highlight? mouse over highlight: like the relief on tool bar button or, even better, with highlight face like on the modeline. >> +enum bar_type >> + { >> + MENU_BAR, >> + TAB_BAR, >> + TOOL_BAR >> + }; > > These enums are definitely named too generally. They could conflict > with other libraries down the road. Ok. [...] > Why ENUM_BF? A mistake. I thought it was the way to use enum types in emacs. > BTW, I really don't recommend doing this kind of refactoring so close to > cutting the Emacs 29 branch. Last year I and Alan Third found and fixed > several obscure bugs related to the tab bar code being a poor cargo cult > of the tool bar code, introducing subtle differences between both pieces > of code. Any refactoring there is likely to introduce more bugs, or to > reintroduce old ones, and those bugs are much too subtle to find before > November (or even February.) I understand that it is too close to Emacs 29. Do you think the menu bar could be made to mimic some feature of the tool bar (like tab bar did)? Or do you think it would add to the cargo cult? -- Manuel Giraud