From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59986@debbugs.gnu.org, Jean Louis <bugs@gnu.support>
Subject: bug#59986: 30.0.50; Can't trash file with broken symbolic link
Date: Thu, 15 Dec 2022 01:13:04 +0100 [thread overview]
Message-ID: <87tu1xttgv.fsf@web.de> (raw)
In-Reply-To: <837cyunp81.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Dec 2022 14:29:02 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> Meaning that you don't remember whether the file which was already in
> Trash in bug#47135 was or wasn't a symlink?
AFAIU it had been - the original report says:
| In my trash there is this file:
|
| lrwxrwxrwx 1 175 Jun 18 2019 Rock-and-Mineral-Identification.pdf -> /home/...
I think there is indeed a problem with those `file-exists-p' tests in
`move-file-to-trash' that check whether the file name to add (in the
trash) already exists: when that name is the existing name of a broken
symlink the result is `nil'.
Those tests probably need to handle symlinks specially (using
file-symlink-p I guess).
Michael.
next prev parent reply other threads:[~2022-12-15 0:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 6:51 bug#59986: 30.0.50; Can't trash file with broken symbolic link Jean Louis
2022-12-13 3:51 ` Michael Heerdegen
2022-12-13 8:00 ` Jean Louis
2022-12-13 12:42 ` Eli Zaretskii
2022-12-13 13:49 ` Jean Louis
2022-12-13 14:44 ` Eli Zaretskii
2022-12-13 19:24 ` Jean Louis
2022-12-14 12:29 ` Eli Zaretskii
2022-12-15 0:13 ` Michael Heerdegen [this message]
2022-12-15 7:12 ` Eli Zaretskii
2022-12-15 14:54 ` Jean Louis
2022-12-15 16:07 ` Eli Zaretskii
2022-12-16 6:39 ` Jean Louis
2022-12-16 15:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu1xttgv.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=59986@debbugs.gnu.org \
--cc=bugs@gnu.support \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).