From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon Date: Tue, 14 Feb 2023 11:56:58 +0100 Message-ID: <87ttzoo6px.fsf@web.de> References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20769"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61460@debbugs.gnu.org To: Ulrich =?UTF-8?Q?M=C3=BCller?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 11:58:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRt0r-0005FB-Et for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 11:58:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRt0d-0005ZU-NJ; Tue, 14 Feb 2023 05:58:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRt0c-0005ZI-D3 for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 05:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRt0c-0001Zv-3s for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 05:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRt0b-0002K2-Lq for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 05:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 10:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61460 X-GNU-PR-Package: emacs Original-Received: via spool by 61460-submit@debbugs.gnu.org id=B61460.16763722378857 (code B ref 61460); Tue, 14 Feb 2023 10:58:01 +0000 Original-Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 10:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:52697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRszs-0002Im-Tr for submit@debbugs.gnu.org; Tue, 14 Feb 2023 05:57:17 -0500 Original-Received: from mout.web.de ([212.227.17.11]:52501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRszr-0002IY-6I for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 05:57:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676372219; bh=q7RwmBshbSIzGAFDB1enFVYuwkmOWm5HXkQhjvgVLz8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=FOEtOafTVKrpKYJc29EA3wKAPfq1jnIOx6CprLToFh5QfNXxjOnAvr/nA1DzOG5sy P99kWeMbCZdccFJ2J3V47ubc/olErnFSceov8FGpwo1NWhFR7wuT2j0qY0QRE7RHel I6DCI5o/JPEjd7T6rkHcekp4woMWb4dWj6hvS2QwhtBLirY/f1n8oFJ3xd94sqn8JR 2r0Ixb9i2xOo8oU5jpb1ysNlNY2Mbeu96uUEAl0hsP6UCzFP72FkCRtYsGFElpODWe 15geva2JKRGJi08jCxhmX2imgqf98OewnMIJ3gQnQGiRoiaw+CLCTKornnQ1VjqSIM ynfCdatVC7K1g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N8Epu-1oWjxD0ioa-014E1H; Tue, 14 Feb 2023 11:56:59 +0100 In-Reply-To: ("Ulrich =?UTF-8?Q?M=C3=BCller?="'s message of "Tue, 14 Feb 2023 11:22:56 +0100") X-Provags-ID: V03:K1:gUroPRIo9uTQg04CsVxmVnezDEeMDSMeAohAApRLZFchB2MKQTr FtMetuxyKmKdPtQt6EbbW798nDalY2dXpMTrP0H0GQoOJLphvEtlcapmvEQZ8TKPHQJytIw gUmu274vQPDhy22FSmcpmLEdxzGrEL5BPrjNHJ6VvqZP5rMLamz/HxG6Cx0A5UyezeenoPG cd7Nsup3J3MgLyFhMAQIg== UI-OutboundReport: notjunk:1;M01:P0:/IRvhSPbfSU=;jpTuHzdrd5Jw2+WeSA71ZrP1xKA Bs1U8L30x9MJk5Fy3DiW1chhne9jZ2YqOzzCgfmGtU2t6qZCJMRCahJiDOR0nHz1V+B6i6RTI MkdC5C0zAVc44PlHkzIR9fNeJoDXTnBvJ50beEmyVYzcfALXc73cbTvedm5ASRX+WK1Dh9pIr ClUxaM1LOqRKWxDnMqTZUFPNU7c6WLJmkORjQgHVVqEEI34WG1dxAALcAtCBMUaVylL+tWewE tj5Td6ioXOW8e8lRitwa2Z7QsX/4aFsH3r4gNELi91IBd04+TqhIniGADtuE5q3ZAw+fi6alv zKHb7GMsqK772PldgOBMUlK4guPPCMztlOR73aSXKiVmzVubaitA/s7R4DwPPQR850wZlxAAt 9o5EpLuv+CaNzRnNm3s1hL7esNP4j9mqJsnztBpty/SmAsweUZlwpgXFdcLYqKikuifMdHBVI 2PxVwWqcghLnefwE0BhOsTb0abiqOvCl0bQbnDlYKkhdwiAv7ba18c+zVSWitgmw8Q9rLCa3O DLU3su2Mk6GKScM03DdE5dCI4g9bloe5mrAy83BuBN/yFoq6CtJugKIblR7igP4qXcMpPrhIe cF/lUIFy9vm1UAo3on0stjpHN/xJPk1eBO9uFgezTzjTkVZDqbnzv5s3/1N3YWIP/S9hO3CSx h++p1Hl3hSLQO5DlKbS/Qyp6Xnd21kHAolAm2RH4JpevbHvWBoxg5NhT3Wu/EtUB1bD+nK7XT 968NiCSzatbYhQDF5F6R2+5rQ8VuErtsfOsenB/Pvcom5q82VQE5VncdORlB9E0Dmmh0BYWM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255566 Archived-At: Ulrich M=C3=BCller writes: > Next round: The following simplifies the calculation and IMHO makes it > much easier to understand. Results are identical, and tests pass. Yes, thanks. I want to suggest to get rid of the successive rebinding to the variable `moon-lat' and use a different name (`node-distance' maybe?) since that calculation is not just a simple conversion of units. > Alternatively, we could leave the result in degrees (as all other > calculations in lunar.el are in degrees) and change the values in the > final cond to 13.9 and 21.2 degrees. This would also get rid of the > excessive number of digits. Good idea. The conversion to radians is a bit artificial and not really useful, just harder to read. Michael.