From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61639@debbugs.gnu.org
Subject: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired
Date: Mon, 20 Feb 2023 14:35:42 +0100 [thread overview]
Message-ID: <87ttzgtq6p.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <83sff0v6wz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Feb 2023 14:49:00 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sun, 19 Feb 2023 21:09:47 +0100
>> From: Manuel Giraud via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> This patch prevent errors when using image-dired on non image files.
>
> Why is it better to show a message than to signal an error? The
> former could go unnoticed, especially if some other message is shown
> in the echo-area soon enough.
I don't think it is better. But for some image-dired usage, I do not
find it convenient. Example: you carefully select some images from a
dired buffer and hit `C-t d' to see them in image-dired. But your
selection was not correct and one of those file is not an image: you
receive an error (and have to correct your selection) and don't get to
see any of the correctly selected images.
So my idea was: yes, it is an error but it should not be one that
unwinds all. Maybe it is a job for `warn' but having a *Warnings*
buffer that pop up is a bit too much too IMO.
--
Manuel Giraud
next prev parent reply other threads:[~2023-02-20 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 20:09 bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:49 ` Eli Zaretskii
2023-02-20 13:35 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-20 13:46 ` Eli Zaretskii
2023-02-20 14:13 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 14:45 ` Eli Zaretskii
2023-02-20 16:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 12:01 ` Eli Zaretskii
2023-02-21 12:16 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-21 13:03 ` Eli Zaretskii
2023-02-21 14:23 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-22 13:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttzgtq6p.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=61639@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).