From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Thu, 02 Mar 2023 14:12:43 +0100 Message-ID: <87ttz3jnzo.fsf@ledu-giraud.fr> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25266"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61816@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 14:13:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXikM-0006R5-H3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 14:13:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXikC-0007h7-Pw; Thu, 02 Mar 2023 08:13:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXik2-0007Xx-Ot for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 08:13:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXik2-0008Jj-Fw for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 08:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXik2-0001cj-BB for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 08:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.16777627706224 (code B ref 61816); Thu, 02 Mar 2023 13:13:02 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 13:12:50 +0000 Original-Received: from localhost ([127.0.0.1]:56141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXijq-0001cK-20 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 08:12:50 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:34053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXijm-0001c7-PI for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 08:12:47 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=781Efekj fn2xypTnogp2CSJeeWqYnLYdhV/UBiPu/+0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=GV2CHuOYsnDGmoRJLDAkOmvN2sWGJz 2TkOT7a0yF8Q5nfGJrqkV75SucWR745Z+PHotHoOBmemiYSIZggU5eCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=781Efekjfn2xypTn ogp2CSJeeWqYnLYdhV/UBiPu/+0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=tK9EpOTLWN8fCmSRbGDB/ttvUzxHKCUuUhHwpZ L/KJjJfDZfrU44AwX0yoYCNknn8qmvTOIkA6psPw2NjKcwD/1sdHPVPs80P1KTsy18pfmk /o6VTJH9UbuLny+c9qSzt/HT2OmO61XxowdlwpBnFGwEZyG8WAhQ0av8dxyF9q2ZS6VjLT +bQ2iro76J4Y7+nblJlXF4iTaYK78yExsCAb35LYYl9GDSvLejQiu04u9gwClb6dFS4AII RfH1Hd29k+bm0cDh1H7OCrG4xl8+OZb8Z6X9Z+J5JkyUp9DHcWxXyOwghN5UtbMkG1aVaj G4ECWcs/cughuymRfpj5d2fQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c3efec62 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 14:12:45 +0100 (CET) In-Reply-To: <838rgfe39g.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 14:39:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257153 Archived-At: Eli Zaretskii writes: >> Date: Sun, 26 Feb 2023 16:33:02 +0100 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Here is a new user option to make DocView, with SVG backend, honor the >> current theme colors. > > I have nothing against the feature, but wouldn't it be better to > modify DocView to use faces for this, and then themes could override > those faces? Why not but I have two issues with this: - we had to set those new faces in every Emacs' themes and also wait for any theme maker to use them - those are really just two colors not real faces as the rendering is controlled by an external tool anyway -- Manuel Giraud