From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61816@debbugs.gnu.org
Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
Date: Thu, 02 Mar 2023 14:12:43 +0100 [thread overview]
Message-ID: <87ttz3jnzo.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <838rgfe39g.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 14:39:23 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sun, 26 Feb 2023 16:33:02 +0100
>> From: Manuel Giraud via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> Here is a new user option to make DocView, with SVG backend, honor the
>> current theme colors.
>
> I have nothing against the feature, but wouldn't it be better to
> modify DocView to use faces for this, and then themes could override
> those faces?
Why not but I have two issues with this:
- we had to set those new faces in every Emacs' themes and also wait
for any theme maker to use them
- those are really just two colors not real faces as the rendering
is controlled by an external tool anyway
--
Manuel Giraud
next prev parent reply other threads:[~2023-03-02 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 15:33 bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 12:39 ` Eli Zaretskii
2023-03-02 13:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-03-02 13:56 ` Eli Zaretskii
2023-03-02 15:40 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 15:51 ` Eli Zaretskii
2023-03-02 15:57 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 15:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-02 16:32 ` Eli Zaretskii
2023-03-02 18:20 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-09 10:06 ` Eli Zaretskii
2023-03-03 2:28 ` Visuwesh
2023-03-03 7:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttz3jnzo.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=61816@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).