From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Thu, 06 Apr 2023 19:39:36 +0200 Message-ID: <87ttxssyef.fsf@gmx.de> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile9t5uj.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21926"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62694@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 06 19:40:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkTav-0005YO-6i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Apr 2023 19:40:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkTag-0004Vi-Fz; Thu, 06 Apr 2023 13:40:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkTac-0004VO-Lc for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 13:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkTac-0000nX-86 for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 13:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkTab-0003x7-Ux for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 13:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Apr 2023 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.168080278615159 (code B ref 62694); Thu, 06 Apr 2023 17:40:01 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 6 Apr 2023 17:39:46 +0000 Original-Received: from localhost ([127.0.0.1]:55088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkTaL-0003wO-Ni for submit@debbugs.gnu.org; Thu, 06 Apr 2023 13:39:46 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:56269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkTaJ-0003w5-NP for 62694@debbugs.gnu.org; Thu, 06 Apr 2023 13:39:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680802776; i=michael.albinus@gmx.de; bh=USBFCEULhZLGMYPaH2Wz8KG2szuWLAlvRbBsgByRvLc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=uC18NWm6stvXDVXYkfjvhhuzSyglZkENWgU3IOLviWnQBaX4WSp1nT261DahwB/kt v4Zxiwz1adj1Td6+Vk54vOxPtA3YGHBZy1t3iONWhRLARo3Cc973VmdVIlBtbgYGun bM1HzkoZDMd/jbWUgULJdWJkLEE5rYbF/rVoZj513GnDZNqoc2Lu4B7juOVXbZt6Yz 218L4VC8OHln9bceJ0txNRSdXZKqbXDRQ78/p44unpNn5w6yrqIv8Fn4zwJxs+imAt dO4aihQyTSRYNThwf18+yBw3EKuC4fDCn63j9rFctldTFPSE2wdWJ3XDT+DXIDuEfW 084+i5M2RrdQg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.0]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mz9Z5-1qf4Cx2pL1-00wAR6; Thu, 06 Apr 2023 19:39:36 +0200 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 6 Apr 2023 17:59:21 +0100") X-Provags-ID: V03:K1:bGSNvtvpHlXzRC0E2Lc/750Cy5+v33ZorldWMOBYKowFXwKDxbd 67yppzQzjeZX23eWL2IDc4oSD0i2zvRF9ZSy9nmpb7QzSF2B9u7L0T713ba9ps5QT8hvIKZ g/D4SkkfTdfnFe3rAyKf3UYOPxmbnoGx8tWQoufGYEk4YG05kxF+DYGkFwobrjRTJJSLZEl MNG0jKgviAibLkgbAUypQ== UI-OutboundReport: notjunk:1;M01:P0:w4QD6flf7Dk=;M+eLuXwx9eejQlX8NVY2J4GhizI xr9Lg6tCi5k1Bv/46OlTG73Pk/SqZR4AwOg/ylzE0toOiRx+elDpSKlCyByNVqvKpY/ouuq28 q9tVLE9Vg1nbFh9v//WEwcS/+9uG9h4ddjoSII3kZ3L3WbMpWMQjojrxTQfYSl0q0UBz/JfzO 2OV+bI5pW1mz91FVrBQ2elbs7BgUbSnpFx/MVP0uvTlsbkQB9+RRybuxnkMv4XSUX4ZzibjYn pj7eY45SGxS5SUVBA3gtIIPqiU6ATK+R8LpiM/fzSiDqZXWuONcj3OY6EeH1ScMc7h0z1wtAR +OAjHlMcSapM4Igtw/Y5JXAGcZh/29qVGCriwvJSJy6ppvXYIEiD1GsNMax3movIkuMTT2mC8 2Grd/4lRzs4iSlp+EGbnXmc26cXF0PPEVvsbJzXyhTXfezVgxufIvbxtIkpzuZVNQatRVSNfr b/ZRr1AcLGSYU8IBt6tPcBeUtt1Z3wslrpboOabjwwUCWJgJZbHqbTApWM2dC2n53AV4LXChn LG20PbwYHcRA0K5/EXJsIFJ2AH/DHwUyeOjSjv3bvdRjQwTMko7wgmhdZO9wqrQ3HyX7Pmowx KcdyclK1TB3sYe3f0ZE7gVXaAQ21MmkLvqa//Ca9XuH80WRT7iN/9JI8ZvzZBp/EUWrGB7Vf1 gdA8dbGIkJPTwLVUWI1eHoZ9NEBxEJPdDg4gIuKqvHJCEllyREaSNaM5cljnEZTGT0Zguqi3H rHLWEn5JCZ72gWEvNFdupT0alDkkPcOERnvJZaf0Y87iikB0h8Rb9hTFo8OpMG8cDmMvShy2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259338 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi Jo=C3=A3o, >> I don't doubt. But you cannot expect that everybody uses "the number one >> recommended pylsp installation method". > > I expect that. The same way I expect people to install Eglot from ELPA, a= nd > use a normal installation of Emacs, not some "Doom" or "Spacemacs". Or the > same way I expect people not to have advice in their configurations. > Many times my expectation fails, and yet I expect these things, because > that's what I programmed against. > > So if they don't use that method, then maybe they should. More > importantly, here we're talking about the much smaller universe of Emacs > developers, not regular users. I don't speak about eglot (pylsp) users. They will know what to do. I speak about ordinary Emacs users, not interested in eglot, who could see Emacs errors when they run "make check". Just because eglot-tests.el doesn't check its prerequisites sufficiently. As we have seen, (skip-unless (executable-find "pylsp")) is not sufficient.=20 >> Again, I'm not speaking about eglot users. They shall know what to >> do. But eglot-tests could fail for everybody who has installed a pylsp >> package, for example from Debian, w/o even being interested in eglot. > > That package is faulty to some degree in that it does not work exactly > like the recommended installation of pylsp. Likely yes. But people might have it installed, because they use Debian. Why don't you check this wrong installation of pylsp in your skip checks? This would solve it sufficiently, I believe. > Even if that's a problem for some hypothetical hardcore Debian > user who happens to also be an Emacs developer and who uses pylsp > but not in Eglot, and for some reason won't install anything from anywhere > else in his development machine, we have yet to hear from the hordes of > users at the intersection of all those conditions. The don't need to be pylsp users. A package could be installed for several reasons. And we haven't heart from them, because there doesn't exist an Emacs release with built-in eglot and eglot-tests yet. People, who install eglot from ELPA I don't care about, they know what they do. > In your case in particular, I'd say you have control over what you > install in your machine and what you install in EMBA. And I've > given you the recommended way to fix this, if you really must have > pylsp there. Again, can you answer what is preventing you from using > `pip install` in your machine or in EMBA scripts? The point is not Emba. It is just a mean to demonstrate what could happen. And yes, I try to make the environment according to what people use in general. And not to install special 3PP, not included in Debian, just to "let the tests succeed". That's not the idea of regression tests. > Also, what is moving you so resolutely to install pylsp at all in EMBA? > Are you programming Python with some other LSP client on EMBA. Is > anyone? No, I'm neither interested in python nor in eglot myself. I'm interested in a stable Emacs. And I know, that people providing tests should ensure that their tests do not harm. Yes, any failed test in the wild is a harm. > Are you just trying to get the best possible coverage from eglot-tests.el? > Thanks, but then I'd focus on rust-analyzer first, or the Java jdtls serv= er. > The latter would be really useful as the GitHub CI isn't currently > installing it and the test is being skipped there. If you could show me the Debian way to install rust-analyzer or jdtls in Debian, I'm your man. I didn't find a corresponding package (but honestly, I haven't tried for days). In case such packages don't exist yet for Debian, I would be willing to install them differently, for a while. >> > I don't have Debian. We can overhaul the sanity checks, but I don't >> > immediately see how. Or why. So it's hardly a priority. >> >> See above. With the instructions I have added to admin/notes/emba, it >> should be simple. > > Thanks, I'll have a look one of these days. Thanks. > Jo=C3=A3o Best regards, Michael.