From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#62990: 30.0.50; UDP server closes connection upon receiving an empty packet Date: Wed, 26 Apr 2023 12:35:21 +0200 Message-ID: <87ttx3rkwm.fsf@gmail.com> References: <87wn21br45.fsf@gmail.com> <87ttx49yg0.fsf@gmail.com> <87354nt37h.fsf@gmail.com> <83v8hjszp3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17666"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62990@debbugs.gnu.org, mail@vasilij.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 26 12:36:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prcVs-0004OX-Jn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Apr 2023 12:36:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prcVI-0006fC-5I; Wed, 26 Apr 2023 06:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prcVG-0006e7-19 for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 06:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prcVF-0002OJ-Pc for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 06:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1prcVF-00049H-Lc for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2023 06:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Apr 2023 10:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62990 X-GNU-PR-Package: emacs Original-Received: via spool by 62990-submit@debbugs.gnu.org id=B62990.168250533015909 (code B ref 62990); Wed, 26 Apr 2023 10:36:01 +0000 Original-Received: (at 62990) by debbugs.gnu.org; 26 Apr 2023 10:35:30 +0000 Original-Received: from localhost ([127.0.0.1]:54367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prcUk-00048X-7D for submit@debbugs.gnu.org; Wed, 26 Apr 2023 06:35:30 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:46108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prcUi-00048G-Fp for 62990@debbugs.gnu.org; Wed, 26 Apr 2023 06:35:29 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-2f917585b26so6336397f8f.0 for <62990@debbugs.gnu.org>; Wed, 26 Apr 2023 03:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682505322; x=1685097322; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=E6l06H4P3j/OMi4ZpKduwstLvArmvUx3ILg2uG+9At4=; b=h57Qn5AuLdUlhKpcsSur6D+fPCoI27hOrOfNliGtyHamhWDbLf8pkNJOX1mXh6F5wg fe9Av96O101tiR6noBOJMc2VH2BvtFagsRiwmob1xFVyYG29nNUt20KMW7sS6e+sKGhZ 4K71hQi7qVLuSQ2olwQjregAsDuSjrJlrvYwX46sSr6xxkRUSuo6oTQ8T74Ul0bsN3He EdIU+vw4os8+Is9JlGVaq3uurcuwg8LkjwLAIKXs4DXvIEah5XG4KKZP4HCaTZboIDKs sFERfsqMN+OIPjDU1ByjsT9rQb3veQexIdhTrSk4ioBIrKDSFOWVMLyYlqGmZuLKesGj uIjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682505322; x=1685097322; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6l06H4P3j/OMi4ZpKduwstLvArmvUx3ILg2uG+9At4=; b=BYiMwIHflSF5vkVF7TTesr9Tymvp9bE76guJLhYHY6UYcZ00AQ54tcEe6OKaW8bhx6 zvYrP5tdk0LxRuHaBqnWVv68EiVXl5QF1bGpuP7sbNKZusa79G8RX45hImO+JL+f2Z2R XTPH/JL/yrEcUJEIzye30a4ASX6lGg6c7KGw0bp4S0KsZwanMH9Lsc3jT5dQadXLd0B8 VBnpRT+LItcIykcZg9G44+IP4cr0Vh2Bh9GVL4z7z1p1rTOvjJjnx11RW2sXSwKf2y4e qvYqYb/IRV35gSjqhXS10DaM3DjHIwDmuugya8HQtzXc1Y0Ech1AuR1Hn5xqsf9SsKI3 dNJg== X-Gm-Message-State: AAQBX9fiwLMmzS6KW2rDT2y5+pua9r0pia+FnI6+TAgns9cPDiCWAVSo dooBPS43xopjTZnu8HrfPhi1IMdRXnk= X-Google-Smtp-Source: AKy350ZlnRJx4g6pQqynicFCw6+CQ9Xilj+78vwOArqiWvO4fAFcs2+CW9beeu6X+f+P5t+/Aak9HA== X-Received: by 2002:adf:edcc:0:b0:2f4:fcd:98dd with SMTP id v12-20020adfedcc000000b002f40fcd98ddmr14575955wro.4.1682505322436; Wed, 26 Apr 2023 03:35:22 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id z14-20020a5d4d0e000000b002efb4f2d240sm15420429wrt.87.2023.04.26.03.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 03:35:22 -0700 (PDT) In-Reply-To: <83v8hjszp3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Apr 2023 13:30:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260662 Archived-At: >>>>> On Wed, 26 Apr 2023 13:30:32 +0300, Eli Zaretskii said: >> Cc: 62990@debbugs.gnu.org >> From: Robert Pluim >> Date: Wed, 26 Apr 2023 11:14:42 +0200 >>=20 >> So allowing emacs to send 0-length UDP packets turned out to be not >> too hard. Patch for both below. Eli, is this OK for master? It does >> change 2 behaviours: >>=20 >> 1. Receiving a 0-length UDP packet will no longer cause an error >> 2. Calling (process-send-string proc "") now actually sends out a >> packet for a UDP process (an empty one). Eli> Do we want some variable to get back the old behavior, in case some Eli> application out there depends on that? For which one? Does it help if I say that [1] is a security fix? =F0=9F=98= =9C I can=CA=BCt think of anything that would be negatively affected, but we=CA= =BCve all been wrong before. Eli> Otherwise, fine by me, thanks. Vasilij, does the patch work for you? Robert --=20