From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads Date: Thu, 04 May 2023 17:15:30 +0200 Message-ID: <87ttwsnn59.fsf@gmail.com> References: <87ild8tnbg.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Basil Contovounesios , Philip Kaludercic To: 63260@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 04 17:20:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pualJ-0001ka-UA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 May 2023 17:20:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puakv-0000qO-Er; Thu, 04 May 2023 11:20:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puage-0000Kb-Fx for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 11:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puage-0002aM-5N for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 11:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puage-0004Tk-06 for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 11:16:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 15:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63260 X-GNU-PR-Package: emacs Original-Received: via spool by 63260-submit@debbugs.gnu.org id=B63260.168321333917108 (code B ref 63260); Thu, 04 May 2023 15:16:03 +0000 Original-Received: (at 63260) by debbugs.gnu.org; 4 May 2023 15:15:39 +0000 Original-Received: from localhost ([127.0.0.1]:51769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puagF-0004Rr-8r for submit@debbugs.gnu.org; Thu, 04 May 2023 11:15:39 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:53332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puagE-0004R6-04 for 63260@debbugs.gnu.org; Thu, 04 May 2023 11:15:38 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f19a7f9424so6597415e9.2 for <63260@debbugs.gnu.org>; Thu, 04 May 2023 08:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683213332; x=1685805332; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4iawT47iVBXEZlo5QORmbk22inkR/AFIXpuayUsVjdQ=; b=LhtJ/bswBpNRcEFbFpSGQnQyU5Mt/cpTFvcczS/qL6WuE1343RV1WZI9yNoQSTtSMI UyGVCETsAaKfxdxpc8fB3g3+RTkh27rKmifNJAM9Z1atNgXyoEby9uErKYk79mjRkSUB UXxMVN5bL6/GaqpK/j0Cq1kZNu01jPJ1GuAyRCCHU0wrhTgYFjdKOZUC7GrvBdlqydi3 9w3DcyhwOZM6e6UXvzpJ5NaHn0TJ/hMiv3oytNkN8SdoXOvYnM+tmhjg2g+7+uEUHy5H biKibN0DTHOnl6hOO2Ni5w22AGVWY0tl6RB7zDSciibkg3oZ5610tSXbY4FlnFAppVfn u04Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683213332; x=1685805332; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4iawT47iVBXEZlo5QORmbk22inkR/AFIXpuayUsVjdQ=; b=h9cYEXV7sk3WY0F6CoNSjPD6piUZ0NkpPHqUeN5YX2vx/Y2wBSvJ2z2oX5NtzzsUIh GN0XI5XkPbiTWeVKtUq1RkbbS+sMN6LtVrvWyemo3+fqt0FWy7yXxIbng3WnIRUflJSJ EX7Vv7DVhxpYild4+42LnH6hEIPKxK+/FzO8ms/OvKjW6BS429PgCm4a1lQ8V5YFbj99 t/h2+MHlwym0B8cCa/c1qZTGmEDLiX3qQ34cIc4nfPv1tHJ/TY9kDZlu+Jk/NU04j5bY gkyjR3Ujf3xkijsoRgMnyJWn9S2A3BeCKyxYqFlWEnJx4iY4wb9AKSdmSmfNkXzIi8wl FfWA== X-Gm-Message-State: AC+VfDy+qecG3Fz4EpDxE1VR+9v6hy6N8VX48rIcMAhMK/ep2l6tthDv +nuJV6spkNa36vnAIvm7Kp4= X-Google-Smtp-Source: ACHHUZ4dq7X3UxjsiISv0Q+Sa6teYbhSBdBlG9hGSu/brMA5IxdmFT3Z3fDzhj/oO68i+rYtBHthxA== X-Received: by 2002:a7b:cd85:0:b0:3f1:6fb3:ffcc with SMTP id y5-20020a7bcd85000000b003f16fb3ffccmr8601wmj.22.1683213331609; Thu, 04 May 2023 08:15:31 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id u20-20020a05600c211400b003f183127434sm5184170wml.30.2023.05.04.08.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 08:15:31 -0700 (PDT) In-Reply-To: <87ild8tnbg.fsf@tcd.ie> (Basil Contovounesios via's message of "Thu, 04 May 2023 12:15:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261022 Archived-At: >>>>> On Thu, 04 May 2023 12:15:15 +0200, Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: Bug> This change: Basil> Prevent generating empty autoload files Basil> dd21003878d 2023-04-30 18:42:58 +0200 Basil> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=dd21003878d Basil> seems to have reintroduced the following issue: Basil> https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html Basil> First start Emacs 29 (or 30) with a clean slate: Basil> $ cd "$(mktemp --directory)" Basil> $ export HOME="${PWD}" XDG_CONFIG_HOME="${PWD}/.config" Basil> $ emacs Basil> Then try to install the sicp package (which lacks autoloads) from MELPA: Basil> 0. C-x b RET Basil> 1. (setq package-archives '(("melpa" . "https://melpa.org/packages/"))) Basil> C-x C-e Basil> 2. M-x package-install RET sicp RET Basil> 3. C-h e Basil> 4. C-M-S-v Only when `package-quickstart' is non-nil, right? How about this: diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 0919ce34448..42d47ed259c 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4498,7 +4498,8 @@ package-quickstart-refresh (pfile (prin1-to-string file))) (insert "(let ((load-true-file-name " pfile ")\ \(load-file-name " pfile "))\n") - (insert-file-contents file) + (when file + (insert-file-contents file)) ;; Fixup the special #$ reader form and throw away comments. (while (re-search-forward "#\\$\\|^;\\(.*\n\\)" nil 'move) (unless (ppss-string-terminator (save-match-data (syntax-ppss))) Robert --