From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62116: RFE: eglot: support window.showDocument LSP RPC Date: Fri, 05 May 2023 17:51:02 +0100 Message-ID: <87ttwqsow9.fsf@gmail.com> References: <87jzznxx8f.fsf@gmail.com> <83fsabwhpg.fsf@gnu.org> <87v8j7vy48.fsf@gmail.com> <83r0tuv62t.fsf@gnu.org> <874jp8gu8a.fsf@betli.tmit.bme.hu> <838re3jowg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3992"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sebastian.poeplau@mailbox.org, adonovan@google.com, 62116@debbugs.gnu.org To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 05 18:49:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puycQ-0000l2-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 May 2023 18:49:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puycC-000352-SW; Fri, 05 May 2023 12:49:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puycB-00034j-8c for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 12:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puycB-0001FU-0K for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 12:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puyc9-0006B1-Rh for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 12:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62116-submit@debbugs.gnu.org id=B62116.168330533723733 (code B ref 62116); Fri, 05 May 2023 16:49:01 +0000 Original-Received: (at 62116) by debbugs.gnu.org; 5 May 2023 16:48:57 +0000 Original-Received: from localhost ([127.0.0.1]:57330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puyc5-0006Aj-G6 for submit@debbugs.gnu.org; Fri, 05 May 2023 12:48:57 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:54543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puyc3-0006AU-Ht for 62116@debbugs.gnu.org; Fri, 05 May 2023 12:48:56 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-30639daee76so1405266f8f.1 for <62116@debbugs.gnu.org>; Fri, 05 May 2023 09:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683305330; x=1685897330; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fI/WblfkfkjvqepvF28mJVVIIMqeEHdYXSZlC8qvXHY=; b=KQ8FBNRrKYEVygwbUK3CExY6E+xTWR2EnXI55ff8SNlnkFwtrr2XGrwkWoZTqJ7Tf6 hOLm82oDRp3HEV/OX+VVZOKFZO/phFnMD0ag9j/WL/MFyWdO4jwD3+y2GcNAdR+09lC2 BZf4jk3t5cTotALh5CKiY1Yy1HXowQq6v+Y2qpKa6neL5TJJ1mq5q588MllL2kA4kn9L PQ+sfT8gdq6SxM/Xr8ibSHRM27459YeBFabh5AVmmmwEleeA2MDkaFFVWfNYjQ7mIQ7V 7yoQDDY0zA4ObjZtLsjZ1+36tmbYOSImkH5SHliAR8inLfmgwqlC09WbTk5CICraJ4Zl x1OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683305330; x=1685897330; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fI/WblfkfkjvqepvF28mJVVIIMqeEHdYXSZlC8qvXHY=; b=FsBc1XHqnIZ4uLOljGTMkZcI3/d/s6FT9AUOrbToxGDm6vTEWMhr+uth/4+Dr2BdMw Kz+wwUpY4HKeXZQ6fXo3iVM8NqbbrrTfMXntfg9CnKb3bUO/OCAvPHhmGPyEfOB5PdFc sSjLqS7Ugf9wriPzh20uT5KTIjzskLpJ3y+Op0N71Nh5xMUP2UEyBsN5TncYFih6t5Xj vFZgRFfy6A2qEGcDc2f98tfR6SJ8kXenbvIe7n+sax6JNIs7pnB5eHShNCPKXMD0vovb KMP9FlVTfarqZ20sz98UUQnTuktBqg7SXy6ES/5eazxyxZGx1yaeUkeNREhqUdKB1bmz ourA== X-Gm-Message-State: AC+VfDxy/0ERbCshrBLka2dVVw1TOCIWkWlVgyzLG5T0bNNxK6kkGAEg u+49VW13op5pqEcExcpZowE= X-Google-Smtp-Source: ACHHUZ6DitTx4sGxDycm3ccZYg9KtAEins420KCUY4Sg4UA24sT4jh6WnF0aS/tfOZGUwofZWK5/Yg== X-Received: by 2002:a5d:5404:0:b0:305:ed26:8576 with SMTP id g4-20020a5d5404000000b00305ed268576mr1662808wrv.9.1683305329622; Fri, 05 May 2023 09:48:49 -0700 (PDT) Original-Received: from krug (87-196-74-197.net.novis.pt. [87.196.74.197]) by smtp.gmail.com with ESMTPSA id l8-20020a5d4bc8000000b0030631f199f9sm2853605wrt.34.2023.05.05.09.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 09:48:49 -0700 (PDT) In-Reply-To: <838re3jowg.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 May 2023 09:03:27 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261121 Archived-At: Eli Zaretskii writes: >> From: Felician Nemeth >> Cc: Jo=C3=A3o T=C3=A1vora , >> adonovan@google.com, Eli Zaretskii >> , Sebastian Poeplau >> Date: Sat, 22 Apr 2023 11:08:05 +0200 >>=20 >> This is a continuation of the thread=20 >> https://lists.gnu.org/archive/html/emacs-devel/2023-04/msg00206.html >> , where Jo=C3=A3o suggested we should proceed with my simpler patch unti= l we >> hear from Alan. This message summarizes the current situation: >> https://lists.gnu.org/archive/html/emacs-devel/2023-04/msg00339.html >>=20 >> I tested my patch with Sebastian's ada example. Felici=C3=A1n, can you show your full patch again, perhaps with a unit test using the ada language server? Also, can you comment on why you think Alan Donovan's patch has that non-synchronous find-file mechanism? Since Alan, doesn't reply, what do you conjecture is the reason his patch goes through this trouble? I'd also like someone to address my comments of that patch, which is similar to yours: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62116#10. Among others 1. if you think the Emacs frame should be raised and/or focused when a window.showDocument comes in. 2. if browse-url should be used for non-file: urls (it might open a browser window outside of Emacs, which IMO is fine.) Jo=C3=A3o