From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64298: 29.0.92; Fixes for several todo-mode bugs Date: Tue, 27 Jun 2023 14:50:21 +0200 Message-ID: <87ttutrrw2.fsf@gmx.net> References: <87leg6v9yg.fsf@gmx.net> <835y7axx44.fsf@gnu.org> <87y1k5rznu.fsf@gmx.net> <83bkh1w2yq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64298@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 27 14:51:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qE8AL-0008Sb-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Jun 2023 14:51:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qE89y-000348-I3; Tue, 27 Jun 2023 08:51:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE89v-0002xO-FF for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 08:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qE89u-0003sK-4v for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 08:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qE89t-0004me-LP for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 08:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2023 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64298 X-GNU-PR-Package: emacs Original-Received: via spool by 64298-submit@debbugs.gnu.org id=B64298.168787023318350 (code B ref 64298); Tue, 27 Jun 2023 12:51:01 +0000 Original-Received: (at 64298) by debbugs.gnu.org; 27 Jun 2023 12:50:33 +0000 Original-Received: from localhost ([127.0.0.1]:47845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE89Q-0004lu-FU for submit@debbugs.gnu.org; Tue, 27 Jun 2023 08:50:32 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:40537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE89M-0004lc-EH for 64298@debbugs.gnu.org; Tue, 27 Jun 2023 08:50:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1687870222; x=1688475022; i=stephen.berman@gmx.net; bh=cYfGBmCUgTsjslQluILJklM09OV/aQVbmRSxGVg43O0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=WN8SvPTFY4X82VBpLJm2hjKUHO8TH6aWOVWHOXEk0mzDAZR7FyAk91rz7jBx34tuj8QvzhW q6ds+BQgQPSe1CNSb+Du6CSdtVPqdsJ7TPjN2Hi/4W1OkVIQ52kj6f2eBPHC1o2reT7c/6FLd +VdZXOtbFPnJl9dEp5KQdtmQ0x5BppFeqflvtoThRx7CmAXdHuOXfBFcL1LeSI69DqqSAzrS1 wusTOGLyv2vs6xHGjvngz+wgiXNo5mOsFdCaKbr00grsOUBk4oLOVYy6yvg8hCjM9v9K1Hc3j 7U7TJboAsooYi22ch/ZY9XD2MtgPUartC+O6OIf5KkttgQ20izvA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([89.246.36.44]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MC30P-1qM8N124bt-00COzO; Tue, 27 Jun 2023 14:50:22 +0200 In-Reply-To: <83bkh1w2yq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Jun 2023 14:37:33 +0300") X-Provags-ID: V03:K1:yAniPy4DBGwPJ7P1ucxz9v5KEIWOz1quy564GLYTP/HBo5zLxBr T405snLvqDKxMnfh6w1GbRxIyqyQaflcDBVAQGaTXox4Vc0lNWc4xJfguwqYd1/GSxN0hIV eOTUOmJUIwdKUFyqQtXhQEZHjZks8+NbfTolKqqunJ6SbBlDV5bF7jWxkOeWoOEoIsWZKGq M578UKHGfW71yq9nJOULw== UI-OutboundReport: notjunk:1;M01:P0:i6q2Rbvp5es=;tB68NonCw5xySSGUGxOq4FedDiE O48BHP8tmZda9+8XCxN5Zgn/Ka+tjYANQ4fYcJnNmCh+1TjCUtGEZktHhTQOzJZbjhQvjzbiM to/L8AOE/W/ox+peJtGEH2U1E7CFVin9WR3a8MPApfmXtHBkcdt8zOHz8imVWw9d4+iwcVfXn SHs0fmzwgMKeMe1a2+dGrkOYtbYNEiKFhw1Whlg/4IJChNMqythdXYZPWr6Rx4YLsPVlZaB3I UecZjuL4mOcb6qT0Ry56m487WcnS/KuxlNfk2luMnSiluoJOGFMXUUSv/tvZFHa4gJ3joFM9m 9T9AS+Y0nZkA8LiYCbQsPFwIC4wiFFQeLlg2cdG/TOevZ1e+pmUsPtdGNrek50MlVFGZF88jh qY5ySg1nsE+gSvuxxEE07Cjnmu3ksN8v3U8QKKmog0B3F4CJbiM3tgK5C4xlvt6r2ajUDOMxy ML2HdLvjXe9jhu/P6J1fAIm94NnZduLRGC0jzyr0Ia8Rl3NzEbDT3dUvjFW1MT36vB7+tanR5 Wqfcs0tD+FQMIUvQ8/1zOUxv4sS2Pkm5xXLDmb9KlfeoGttod8skQs44zwEnbKC7OS3vQbAE7 3uFSjshzdm1WM2zGzTASQ1pONKiIDZQzngWnJNJYXr6WMC8eAFEdkHZU3lXyGZ73snzX2AQi0 DmjT+W/gqaPOu35G0p2yr3MRRsguv0Qt6e6LUY+a/Ykmo+yfs6LMduY8sHEJ3dFL7a4f93MuA LNj0SiQZaVGg095a5anToIgtUy6Ti8XUmHgwwfr3YpPjVcZwi3dDFhgXquQ1g7g2J58ijxEi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264156 Archived-At: On Tue, 27 Jun 2023 14:37:33 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 64298@debbugs.gnu.org >> Date: Tue, 27 Jun 2023 12:02:29 +0200 >> >> I cannot guarantee that all possibilities are now accounted for, but >> systematically going through all combinations of commands and the >> conditions under which they are executed would be very tedious and >> time-consuming, and I think it's better to include fixes for the known >> problems in emacs-29 rather than waiting for a possibly more >> comprehensive fix. > > OK. > >> One of the two cases, that of moving a todo-mode category from one todo >> file to another, also revealed a bad UX effect. Moving the category >> requires applying `widen' (since todo-mode uses narrowing to show only >> the current category's items), but in the current code the user is >> prompted for the target file after widening, which makes the file's >> internal structure visible, which is ugly and unnecessarily confusing. >> I fixed this with the second attached patch (applied after the first >> one) by narrowing again before the prompt and later widening again to >> delete the content of the moved category. This is a straightforward an= d >> no-risk fix, so I hope it's also acceptable for emacs-29. > > It looks safe, but it is also not very urgent, since this problem > existed since long ago, right? So how about doing this on master > instead? All right. >> > The 2nd patch is the scariest. How grave is it, and if it's grave, >> > how come it was not reported until now? In general, I'd prefer to >> > have the 2nd patch on master, not on the release branch, at least for >> > now. (We could consider backporting it after Emacs 29.1 is released.= ) >> >> I'm surprised you find this patch scary; what specifically do you think >> is dangerous about it? > > The non-trivial dance with regular expressions, of course. Due to using todo-item-end instead of todo-forward-item? Well ok, I can't readily prove your reservations are unwarranted. >> AFAICT such problems don't lead to data loss and with some effort can b= e >> repaired, but they shouldn't happen in the first place, and with the >> fix, they don't. And I don't think the fix can cause any other >> problems, at least I haven't seen any in testing it. >> >> As for why there has been no previous report of this bug, I guess it's >> due to a combination of involving a relatively seldom needed command, >> having triggering conditions that probably also don't occur very often, >> and above all, there being presumably very few regular users of >> todo-mode. Admittedly, that combination speaks against the urgency of >> committing the fix to emacs-29, but again, the problem is, if not grave= , >> at least very confusing, and AFAICT the fix works and is low-risk. > > I'd like to release Emacs 29.1 _soon_. The only way to ensure this is > not to install on emacs-29 anything that doesn't _have_ to be there. > So please look at this from my vantage point, and try to play "devil's > advocate" against yourself. Then tell me what you think. I understand and appreciate your concerns. So I'll push the revised buffer-read-only fix, the print-{length,level} fix and the two doc fixes to emacs-29, and install the other two patches in master (after the emacs-29 fixes have been merged to master). But if someone else does report bugs against emacs-29 that the those two patches fix, I'll come back to you about backporting them ;-). Steve Berman