From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vladimir Sedach Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Thu, 29 Jun 2023 13:24:58 -0600 Message-ID: <87ttuqax6d.fsf@t510.orion.oneofus.la> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> <87wmzmb5fl.fsf@t510.orion.oneofus.la> <83a5wita0p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2442"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.2 Cc: 64311@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 29 21:26:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qExHM-0000O8-AP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Jun 2023 21:26:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qExHI-0007mu-4Z; Thu, 29 Jun 2023 15:26:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qExHG-0007mW-Bt for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 15:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qExHG-0004S4-1r for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 15:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qExHF-0004C8-R4 for bug-gnu-emacs@gnu.org; Thu, 29 Jun 2023 15:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vladimir Sedach Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2023 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168806670316047 (code B ref 64311); Thu, 29 Jun 2023 19:26:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 29 Jun 2023 19:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:54053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qExGJ-0004Ak-CC for submit@debbugs.gnu.org; Thu, 29 Jun 2023 15:25:03 -0400 Original-Received: from robust-software.ca ([174.136.98.50]:17074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qExGG-00049t-W1 for 64311@debbugs.gnu.org; Thu, 29 Jun 2023 15:25:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=virgo1; bh=A4uKSliP86iT1 S2SH+Y42o9yDbmWurMmPXGYKwy4nec=; h=date:in-reply-to:subject:cc:to: from:references; d=oneofus.la; b=jwoO3lJpL2RH0S18Zus0t7US69DPL9rkGZVVd LM3TIkPmSf0btqhhCBrRQt35HnlK4Bfw1p9UQMxdbuuJdGS34pSoIAfQEtSQsPil2kN3LE 9SwYuVl04LZ3JWGQL1NVjLooL+2bqrpaUGsCWXdLminqrki4+uQyt2F6LMql/C1I= Original-Received: from t510.orion.oneofus.la (node-1w7jra28qzk6xj57njf87zz1o.ipv6.telus.net [2001:56a:f913:3c01:6067:9d9:8a35:d32c]) by virgo1.oneofus.la (OpenSMTPD) with ESMTPSA id c4b3b2e4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 29 Jun 2023 12:24:59 -0700 (PDT) In-reply-to: <83a5wita0p.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264293 Archived-At: Eli Zaretskii writes: > Am I? Asking about the root cause of the problem is not wrong, > because it indicates how best to fix it. The root cause of the problem is the redundant variable shell-dirtrackp, not its value. It is the variable aliasing in the 2018 commit 9c3eeba4db26ddaeead100beea7a96f9fa640918 that introduced the bug. This is why my patch addresses the root cause of the problem, instead of setting the value of the variable (which commit 9c3eeba4db26ddaeead100beea7a96f9fa640918 did not touch). > Why would we bother about that? With the exception of the default > value, what harm does that variable cause by existing? It is misleading for someone trying to customize shell-mode, or work on shell.el. I found it confusing on both counts. If it were not confusing for you too, we obviously would not be having such a long back-and-forth conversation about this bug. -- Vladimir Sedach