From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#65022: 29.1; Tramp resets file buffer encoding to UTF-8 Date: Thu, 03 Aug 2023 16:58:49 +0200 Message-ID: <87tttgxjdi.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17033"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: nephrite@inbox.ru To: 65022@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 16:59:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRZnG-0004DV-Rq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 16:59:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRZn6-0005qe-S2; Thu, 03 Aug 2023 10:59:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRZn5-0005kp-4L for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 10:59:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRZn4-0005yx-Sa for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRZn4-0008AS-Dk for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65022 X-GNU-PR-Package: emacs X-Debbugs-Original-To: =?UTF-8?Q?=D0=93=D0=B5=D0=BE=D1=80=D0=B3=D0=B8=D0=B9_?= =?UTF-8?Q?=D0=9F=D0=BE=D1=82=D0=B0=D0=BF=D0=BE=D0=B2?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 65022@debbugs.gnu.org, =?UTF-8?Q?=D0=93=D0=B5=D0=BE=D1=80=D0=B3=D0=B8=D0=B9_?= =?UTF-8?Q?=D0=9F=D0=BE=D1=82=D0=B0=D0=BF=D0=BE=D0=B2?= Original-Received: via spool by 65022-submit@debbugs.gnu.org id=B65022.169107473831385 (code B ref 65022); Thu, 03 Aug 2023 14:59:02 +0000 Original-Received: (at 65022) by debbugs.gnu.org; 3 Aug 2023 14:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:52690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRZn0-0008A9-BN for submit@debbugs.gnu.org; Thu, 03 Aug 2023 10:58:58 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:41719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRZmy-00089w-5u for 65022@debbugs.gnu.org; Thu, 03 Aug 2023 10:58:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691074730; x=1691679530; i=michael.albinus@gmx.de; bh=IsZ799f52YSG2sTYAvMdONsC4aaauROcE45J9SfO1J4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=p7+fgJq7jSXbZOt4Av9xF82vn9iXvru08cqSsqKHrjBIJAIkIXMlq/Pb0QhLxw3xjI5GPg5 dYX9/kfPydYfnFGcHybxALUpm6KNQUzIVjgVHlln3j5Ugk+Jn1UQL1Ft7G6UKQgTJKkMw272B 7cAOWlEhZo92kO0/pVqVfRM3+GazLrb5iGT1Zh4yfvw3JzUg8LddxClcKWU2UbHGgQSfRrI7D p9hwFRCAEr+gGLYyY69n5jnxEZHAi9esA31qBwOWQKSf834NFkNqvQID1zYsFb6a8J0/1VGG7 N1a3loJIf/NdL+Qo88GsBl/2cyxdC3hI9XP6F1PsbcbBoABkyOBg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1My32L-1pd56L10et-00zZ5f; Thu, 03 Aug 2023 16:58:50 +0200 In-Reply-To: ("=?UTF-8?Q?=D0=93=D0=B5=D0=BE=D1=80=D0=B3=D0=B8=D0=B9_?= =?UTF-8?Q?=D0=9F=D0=BE=D1=82=D0=B0=D0=BF=D0=BE=D0=B2?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Wed, 2 Aug 2023 16:11:49 +0300") X-Provags-ID: V03:K1:oguYIywJ7AQsgwbmKmpbFxkfbhyO0PyCOTxT5xlsvtorWFVkprZ /DX6Pktt2WW5fKi+dxjrUCqKuyhsexSddfZ7sUNoNX2vkWIIwTmMma1F09tFJZ+LUxWf85d POK+ZHfuLUnl+hcymH13g1hUO3bq/Vu86HkwMJGqQpYRQ6MTXvt+0ZoO25CAJIVmxcRSbiw J9SEfyKZ2+9X2uZpefRcg== UI-OutboundReport: notjunk:1;M01:P0:F7jO2xfke+s=;r4nr3EfNC3rC+PDO7YBgWWvgD9H Q5sezS5bIZmjywF3IGm42/DWLCYue+P11xblhDrg0sjvCjGLz0uhXaSb/1lgXu2nRYs4bQZIl VkbmJ8xUTlXbg3gnvBTnDnEnFS+XKotj30oaL4HQEJH3kFz0s1sxcHpHKJID8WLgnNVS8f7Ej lI1FDiX37S7bCLKEgVe/rM32MLEbfO8Evzi55eITU8g7wnUgI+4IGz/B1DOhui9lHYjthVFqP QB+DQ0jr0W3ZhQk7CzRw1KBKrNUfxh8S/FcsXTYWcJmPPsTwECTFlSd3a9Rw980j0yMHs9W3X 1mOn7dryOBWbZ3oh2KSWVo1NVQEc3DKURBlOBv3NNWNrhkdTDXK7/RgXFbuV7x+dw+8papozU uuM4NdbZZwcvAXf1acq8jugVr+n29IrjBpR16WmhNeaAXxyLJ8ubISuV9loQPokAxg0VbTzJi f1iwTL6Uyol49TPXBT/lyEZwn9MfTmJ9HSqGFH/yLfv1ZIPMagwkdWJnXsjG7F9d+1gtZ9s0k UTJuh7dYcZiT/AmRjV/jNJoAQ0VsePliPRqn5qsZqM+8gl19b4noLB9fvsaKf/3BJ64MP6Qx7 v39uBruoTdxJgEmHsOtJsC4tDzoL6R5VDn4b4Ei3CdqNc7eygiyMO9trAaibor7tJoDlFjGdX XnQRrOzo84OmnxWZ00SEk3Sj9ZXLpsiTqXRhAoh7HZQfzrqicTcnWwapVZcg9b3NGAH9QAvWd raZOAMGKKQFCS6lxg+cI1EgwORwjenf42yM06/J6edzWC/sUbJJaydqfTENh4OZflN8zceIn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266591 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =D0=93=D0=B5=D0=BE=D1=80=D0=B3=D0=B8=D0=B9 =D0=9F=D0=BE=D1=82=D0=B0=D0=BF= =D0=BE=D0=B2 via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: Hi Georgij, > I edit my files in cp1251 encoding. > > This works fine on local host but when I save files on remote host > using tramp it resets encoding to utf-8 constantly. Thanks for the report. I could reproduce the problem locally. It took me a while for debugging, but finally I could fix it. It was a stupid scoping error when changing something between Emacs 28 and Emacs 29. The fix, which works for me, is appended. It is a little bit tricky to install the patch, because it is in a defmacro of tramp.el. This macro is used in tramp-sh.el. You must compile both files in this order. Could you pls check? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index 29361f8a113..a052b054f03 100644 =2D-- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el @@ -3640,7 +3640,7 @@ tramp-skeleton-write-region ;; Set the ownership. (when need-chown - (tramp-set-file-uid-gid filename uid gid))) + (tramp-set-file-uid-gid filename uid gid)) ;; Set extended attributes. We ignore possible errors, ;; because ACL strings could be incompatible. @@ -3662,7 +3662,7 @@ tramp-skeleton-write-region (when (and (null noninteractive) (or (eq ,visit t) (string-or-null-p ,visit))) (tramp-message v 0 "Wrote %s" filename)) - (run-hooks 'tramp-handle-write-region-hook)))))) + (run-hooks 'tramp-handle-write-region-hook))))))) ;;; Common file name handler functions for different backends: --=-=-=--