From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65042: 30.0.50; alpha-background doesn't effect background of stipple in emacs 30.0.50 pgtk Date: Fri, 04 Aug 2023 09:52:41 +0800 Message-ID: <87tttfa80m.fsf@yahoo.com> References: <875y5wf6ti.fsf@web.de> <87y1irabhw.fsf@yahoo.com> <87tttfh9iv.fsf@web.de> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25125"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65042@debbugs.gnu.org To: Felix Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 03:53:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRk0P-0006Qz-4r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 03:53:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRk07-0006Aq-3Q; Thu, 03 Aug 2023 21:53:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRk03-0006Ad-Lw for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 21:53:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRjzy-00014m-Do for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 21:53:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRjzy-0000Md-0O for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 21:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 01:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65042 X-GNU-PR-Package: emacs Original-Received: via spool by 65042-submit@debbugs.gnu.org id=B65042.16911139781386 (code B ref 65042); Fri, 04 Aug 2023 01:53:01 +0000 Original-Received: (at 65042) by debbugs.gnu.org; 4 Aug 2023 01:52:58 +0000 Original-Received: from localhost ([127.0.0.1]:53128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRjzt-0000MI-QZ for submit@debbugs.gnu.org; Thu, 03 Aug 2023 21:52:58 -0400 Original-Received: from sonic315-21.consmr.mail.ne1.yahoo.com ([66.163.190.147]:37198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRjzr-0000M2-2v for 65042@debbugs.gnu.org; Thu, 03 Aug 2023 21:52:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691113969; bh=Q9rn/5LauKxpBtu72Mn2DDYfzxk2GXPUlbH7FJBn1V8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=japYikxytZIYxPsaAmpivam2G1Kw3jpTPCWrCy/SkoY5kOBjp/uUEtrscjSCJ1+SkPyEWFsUROEcoC3t52KTs9Ds0CqhG1imNT4ToaHvzCh80Ku68/BPEFJQf1HwpV1prV4pTVrm4PcbBEC4ma0xJF3i/EM7Gu5ouhvrlAooh4RAjCrmSW4gvnndzKC0uD9lhJOTVe98+qZ6/Sx4jksGQ426Pwu6xSr7t+yCHCRr2T+6j+PwNcwEHX3cX15Z6Jow5cZhVp6Dwfi2X3V01xdX9W+Iv+EY8SuFUKWNv39Hy1As3bJlb4fRJCoqk+LIrvJ5TcQHzvGM4boRKuMXtmdWKA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1691113969; bh=IQNTrdHl2sDuiOGShwsutV/a+jSbRDQudxYVC5Bdt8U=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=BOe5nZM2uuohnFb9n1O0CctHYlhe9TsZ2T5Ll6kRbxf6hgVoV9dhD8KC84O66JZb7qYOp7tW7Ur4E5ck5f0loNLEoDtJBceAOmAAx9CysrDsHB34zp6TE2GP5ga2QAsxjismMN6Tc67WLsikG4FjhILba5BezP80t1I51TrYCr93y1KiNZhGT+SUhZ8zDJHobdYlyJEveMDWX7TVZTN24uzF5ieiXZpNfYw/Bvap3nUvz1+kB0lJTwnpgX3qEygpjed2QahkXfjP0G7kGufkAMAW4WPYSrk41NmZXiR8tB/VhJE6YbBLFdHXt4uYaDyTNIkvg6mKJyppBUPN5GzSjw== X-YMail-OSG: ibXk4fUVM1lzRpINin7p9cCjC5ksosdXfT.Gu5jUeiFhct5l3eSweo1EXwVH1CD DTD5ycfoqIbowG6OLh37_VzcNdxSqBXOtBLY8LNjfAnyPsV8WlpRKyFQ57JONrokKOR8lRWHjCLb qxFHHxjQTB2ZDhPgiyMBkrhNYRcaf.jM16RFCTPkZPuw5kl6kWPQakGDMbky_8FcF1.ao4Cqwmbt 8_Q_4bTA_xd1rZi4BHud_aZtaNMFZYUIVLZiO6bHG1w3GGl9bvtM2zS54tWVL4YEJNwunKo3h.cb KLzj5D85C0Exd8CSo9LlrSHaIIrv_iYE5ax0TB9DACrtTLBdt_aZJ3orfJ6viQa6hF7mzNvn8Vf4 RuWc.M.M4_lW8p.j4SxDENlmPG6OOZNnBHvnjrmCiRvsMLWHDI8QnzJ2tqfCltWcaOlKfhMIyg_u 3txzvxakcQhx94Vql.Ig1Vsom6rrDjPTAfduGpHq4T0mCPxNn3rp1DV8JqOHtwiR4aObMe7ZJ8dd OnOMFQpbI1_RhZS0PQZHH2quPVergeoNF.UoPaDwdZrMBwNgpfpc96U4dIYJdcnWED2mcqt.eSvA Ch5Sf0SZ.w4DP0GxUQAkqxwBDrQ.kIWVZXQ6lTAEGS76YFsGVJ6ZgkeMDQiCbfOnz1V34lSQ760D 8NfEse1L7MIudTxzWX74TwlglizsVX6gBDAvbElepnPvUsUwFqrI6CbH2l3OvgiSDVJG6VIC_ser hsFQtGBJTPG8kbOj85y1OX3y55i8Pv2gP1cBvqfZDbwMFziYMKkPlZbujpGZENFcT4M8reY5fr5U NUNKDpDwraePYQPB2gdqN57oGovPkFE99rcbO6zdRv X-Sonic-MF: X-Sonic-ID: 104f73ae-b2a6-4d1a-a8c0-d80d9d947d7f Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Fri, 4 Aug 2023 01:52:49 +0000 Original-Received: by hermes--production-sg3-6b8fc8d58f-875mb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5ce8a3d290887455de4ba6be04a039f4; Fri, 04 Aug 2023 01:52:46 +0000 (UTC) In-Reply-To: <87tttfh9iv.fsf@web.de> (Felix's message of "Fri, 04 Aug 2023 03:32:27 +0200") X-Mailer: WebService/1.1.21685 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266634 Archived-At: Felix writes: > Po Lu writes: > >> Felix writes: >> >>> The background of stipple stays opaque with alpha-background parameter >>> set for transparency. >>> This came up in the use of the new package 'indent-bars'. >>> The github issue: https://github.com/jdtsmith/indent-bars/issues/8 >>> I tested this with 'emacs -Q' only enabling the needed packages (compat >>> and indent-bars). >> >> Thanks. Do stipples start displaying adequately with this change? >> > No it doesn't. > But it gives weird artifacts (doubling the character one > line above or something like that) How about this? diff --git a/src/pgtkterm.c b/src/pgtkterm.c index 9c1fc7bef4e..a7c687d811d 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -1328,14 +1328,17 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y, int width, int height) { cairo_t *cr = pgtk_begin_cr_clip (f); + double r, g, b, a; + cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE); cairo_rectangle (cr, x, y, width, height); cairo_clip (cr); - double r = ((face->background >> 16) & 0xff) / 255.0; - double g = ((face->background >> 8) & 0xff) / 255.0; - double b = ((face->background >> 0) & 0xff) / 255.0; - cairo_set_source_rgb (cr, r, g, b); + r = ((face->background >> 16) & 0xff) / 255.0; + g = ((face->background >> 8) & 0xff) / 255.0; + b = ((face->background >> 0) & 0xff) / 255.0; + a = f->alpha_background; + cairo_set_source_rgba (cr, r, g, b, a); cairo_paint (cr); if (face->stipple != 0) @@ -1343,10 +1346,10 @@ fill_background_by_face (struct frame *f, struct face *face, int x, int y, cairo_pattern_t *mask = FRAME_DISPLAY_INFO (f)->bitmaps[face->stipple - 1].pattern; - double r = ((face->foreground >> 16) & 0xff) / 255.0; - double g = ((face->foreground >> 8) & 0xff) / 255.0; - double b = ((face->foreground >> 0) & 0xff) / 255.0; - cairo_set_source_rgb (cr, r, g, b); + r = ((face->foreground >> 16) & 0xff) / 255.0; + g = ((face->foreground >> 8) & 0xff) / 255.0; + b = ((face->foreground >> 0) & 0xff) / 255.0; + cairo_set_source_rgba (cr, r, g, b, a); cairo_mask (cr, mask); }