From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64536: 30.0.50; Make cl-print put buttons on ellipses Date: Mon, 14 Aug 2023 11:01:20 +0000 Message-ID: <87ttt1q45b.fsf@localhost> References: <87msyyt3oo.fsf@localhost> <87sf8o3b8i.fsf@localhost> <87v8djjnse.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31585"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gemini Lasswell , 64536@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 14 13:03:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVVLm-0007yC-9B for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Aug 2023 13:03:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVVLb-0002d0-75; Mon, 14 Aug 2023 07:02:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVVKl-0002ah-5O for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 07:02:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVVKk-0002kT-EP for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 07:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVVKk-0002IK-6O for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2023 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64536 X-GNU-PR-Package: emacs Original-Received: via spool by 64536-submit@debbugs.gnu.org id=B64536.16920108678666 (code B ref 64536); Mon, 14 Aug 2023 11:02:02 +0000 Original-Received: (at 64536) by debbugs.gnu.org; 14 Aug 2023 11:01:07 +0000 Original-Received: from localhost ([127.0.0.1]:32998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVVJo-0002FX-1n for submit@debbugs.gnu.org; Mon, 14 Aug 2023 07:01:07 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:36253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVVJl-0002Ej-Of for 64536@debbugs.gnu.org; Mon, 14 Aug 2023 07:01:02 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B975E240104 for <64536@debbugs.gnu.org>; Mon, 14 Aug 2023 13:00:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692010855; bh=UAcX58KEhwlolTec52FdDXJ1LTfNBsjp4wW18BHjqFo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=L/v/Jp+Fc1wWfAJalsyYOCPfd0yue/XeA1JdudpPBM6ydBnLL18A+hgJAJWG5Nohi B92SqL/1jtPnJvY0Yw7od7i2kI+3lFBnfThrCpGBfo/Tw9lZOGw27aCYoY3E/DKKSl M+c++Trt226yb6EOFSh5FuWIfEbXGs7p4NZvZ4MFCXYjWsAz5dyiYXDPrsFC403OkO YIMrlCHP0vyNz4H8MDXpepccBhnAlx9jy91YAkVjgpDVSrdokettmDeUv6TuUkM8W3 wBuzJkI1SSyWTBIg8WulnWNJcEUIs5UZ7qKjGD4/ilciSHoaZQ+fcGsATYXsRie4bx TLjqq7KhATvfw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RPWfG5z4gz6txV; Mon, 14 Aug 2023 13:00:54 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267405 Archived-At: Stefan Monnier writes: >> I am pretty sure that some uses of `backtrace-ellipsis' have nothing to >> do with printing Elisp values. > > Could you expand on what makes you think so? Theoretical backward-compatibility considerations. > I grepped for it in Melpa and couldn't find any use of it at all, FWIW. You are right. I also searched in https://github.com/search?q=backtrace-ellipsis+language%3A%22Emacs+Lisp%22&type=code&l=Emacs+Lisp&p=1 And found nothing apart from Emacs forks and inspector.el. So, it should likely be safe to remove this button. >> At least, there is no reason why they should be limited to. > > It was rather tightly integrated with `cl-print`, tho: > the button called `backtrace-expand-ellipsis` which itself looked for > a `cl-print-ellipsis` text-property and called > `cl-print-to-string-with-limit` and `cl-print-expand-ellipsis` on it. I see. Another +1 to silent removal. I thought that is it less specialized (given that its name is public). >>>> May it be possible to create an obsolete alias for this button type? >>> And I don't think we have such aliases. >> May it be added? > > Patch welcome (especially if it comes together with some kind of > obsolescence mechanism). I am not sure if this can be done on byte compiler level. For runtime, after skimming through button.el, it looks like `button-category-symbol' might be used to throw a warning when obsolete button type is being used. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at